From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Felipe Balbi <balbi@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Gross <agross@kernel.org>,
Linux USB List <linux-usb@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names
Date: Wed, 10 Feb 2021 22:33:25 +0300 [thread overview]
Message-ID: <20210210193325.inp7rgpsfr624zhd@mobilestation> (raw)
In-Reply-To: <YCQse9EtEHtLVe9A@builder.lan>
On Wed, Feb 10, 2021 at 12:56:59PM -0600, Bjorn Andersson wrote:
> On Wed 10 Feb 12:40 CST 2021, Serge Semin wrote:
>
> > On Wed, Feb 10, 2021 at 12:17:27PM -0600, Rob Herring wrote:
> > > On Wed, Feb 10, 2021 at 11:29 AM Serge Semin
> > > <Sergey.Semin@baikalelectronics.ru> wrote:
> > > >
> > > > In accordance with the USB HCD/DRD schema all the USB controllers are
> > > > supposed to have DT-nodes named with prefix "^usb(@.*)?". Since the
> > > > existing DT-nodes will be renamed in a subsequent patch let's first make
> > > > sure the DWC3 Qualcomm driver supports them and second falls back to the
> > > > deprecated naming so not to fail on the legacy DTS-files passed to the
> > > > newer kernels.
> > > >
> > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > > > ---
> > > > drivers/usb/dwc3/dwc3-qcom.c | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> > > > index c703d552bbcf..49ad8d507d37 100644
> > > > --- a/drivers/usb/dwc3/dwc3-qcom.c
> > > > +++ b/drivers/usb/dwc3/dwc3-qcom.c
> > > > @@ -630,7 +630,8 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev)
> > > > struct device *dev = &pdev->dev;
> > > > int ret;
> > > >
> > > > - dwc3_np = of_get_child_by_name(np, "dwc3");
> > > > + dwc3_np = of_get_child_by_name(np, "usb") ?:
> > > > + of_get_child_by_name(np, "dwc3");
> > >
> >
> > > Is there some reason using compatible instead wouldn't work here?
> >
> > I don't know for sure. The fix has been requested in the framework of
> > this discussion:
> > https://lore.kernel.org/linux-usb/20201020115959.2658-30-Sergey.Semin@baikalelectronics.ru/#t
> > by the driver maintainer Bjorn. To get a firm answer it's better to
> > have him asked.
>
> My feedback was simply that it has to catch both cases, I didn't
> consider the fact that we have a compatible to match against.
>
> > As I see it having of_get_compatible_child() utilized
> > here would also work. At least for the available in kernel dt-files.
> > See the affected dts-es in:
> > https://lore.kernel.org/linux-usb/20210210172850.20849-11-Sergey.Semin@baikalelectronics.ru/
> >
> > A problem may happen if some older versions of DTS-es had another
> > compatible string in the dwc3 sub-node...
> >
>
> Afaict all Qualcomm dts files has "snps,dwc3", so you can match against
> that instead.
Ok then. I'll replace of_get_child_by_name() here with
of_get_compatible_child() matching just against "snps,dwc3" in v7. Can you
confirm that noone ever had a Qcom-based hardware described with dts having
the "synopsys,dwc3" compatible used as the DWC USB3 sub-node here? That
string has been marked as deprecated recently because the vendor-prefix
was changed sometime ago, but the original driver still accept it.
Alternatively to be on a safe side we could match against both
compatibles here as Rob suggests. What do you think?
-Sergey
>
> Regards,
> Bjorn
next prev parent reply other threads:[~2021-02-10 19:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 17:28 [PATCH RESEND v6 00/10] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name Serge Semin
2021-02-10 17:28 ` [PATCH v6 01/10] arm: dts: ls1021a: Harmonize DWC USB3 DT " Serge Semin
2021-02-10 17:28 ` [PATCH v6 02/10] arm: dts: keystone: Correct DWC USB3 compatible string Serge Semin
2021-02-10 17:28 ` [PATCH v6 03/10] arc: dts: Harmonize EHCI/OHCI DT nodes name Serge Semin
2021-02-10 17:28 ` [PATCH v6 04/10] arm: dts: lpc18xx: " Serge Semin
2021-02-10 17:28 ` [PATCH v6 05/10] powerpc: dts: akebono: " Serge Semin
2021-02-10 17:28 ` [PATCH v6 06/10] arm: dts: keystone: Harmonize DWC USB3 " Serge Semin
2021-02-10 17:28 ` [PATCH v6 07/10] arm: dts: stih407-family: " Serge Semin
2021-02-10 17:28 ` [PATCH v6 08/10] arm64: dts: apm: " Serge Semin
2021-02-10 17:28 ` [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names Serge Semin
2021-02-10 18:17 ` Rob Herring
2021-02-10 18:40 ` Serge Semin
2021-02-10 18:56 ` Bjorn Andersson
2021-02-10 19:33 ` Serge Semin [this message]
2021-02-12 17:33 ` Serge Semin
2021-02-12 18:01 ` Bjorn Andersson
2021-02-12 17:49 ` Bjorn Andersson
2021-02-12 19:51 ` Serge Semin
2021-02-10 18:59 ` Rob Herring
2021-02-10 17:28 ` [PATCH v6 10/10] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name Serge Semin
2021-02-10 18:21 ` [PATCH RESEND v6 00/10] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 " Florian Fainelli
2021-02-10 18:43 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210193325.inp7rgpsfr624zhd@mobilestation \
--to=sergey.semin@baikalelectronics.ru \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).