From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 2/6] USB: host: isp1362: remove dentry pointer for debugfs
Date: Tue, 16 Feb 2021 15:46:41 +0100 [thread overview]
Message-ID: <20210216144645.3813043-2-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <20210216144645.3813043-1-gregkh@linuxfoundation.org>
There is no need to keep the dentry pointer around for the created
debugfs file, as it is only needed when removing it from the system.
When it is to be removed, ask debugfs itself for the pointer, to save on
storage and make things a bit simpler.
Cc: linux-usb@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/host/isp1362-hcd.c | 8 +++-----
drivers/usb/host/isp1362.h | 1 -
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/isp1362-hcd.c b/drivers/usb/host/isp1362-hcd.c
index 2cecb36d241b..d8610ce8f2ec 100644
--- a/drivers/usb/host/isp1362-hcd.c
+++ b/drivers/usb/host/isp1362-hcd.c
@@ -2164,15 +2164,13 @@ DEFINE_SHOW_ATTRIBUTE(isp1362);
/* expect just one isp1362_hcd per system */
static void create_debug_file(struct isp1362_hcd *isp1362_hcd)
{
- isp1362_hcd->debug_file = debugfs_create_file("isp1362", S_IRUGO,
- usb_debug_root,
- isp1362_hcd,
- &isp1362_fops);
+ debugfs_create_file("isp1362", S_IRUGO, usb_debug_root, isp1362_hcd,
+ &isp1362_fops);
}
static void remove_debug_file(struct isp1362_hcd *isp1362_hcd)
{
- debugfs_remove(isp1362_hcd->debug_file);
+ debugfs_remove(debugfs_lookup("isp1362", usb_debug_root));
}
/*-------------------------------------------------------------------------*/
diff --git a/drivers/usb/host/isp1362.h b/drivers/usb/host/isp1362.h
index 208705b08d37..74ca4be24723 100644
--- a/drivers/usb/host/isp1362.h
+++ b/drivers/usb/host/isp1362.h
@@ -435,7 +435,6 @@ struct isp1362_hcd {
struct isp1362_platform_data *board;
- struct dentry *debug_file;
unsigned long stat1, stat2, stat4, stat8, stat16;
/* HC registers */
--
2.30.1
next prev parent reply other threads:[~2021-02-16 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 14:46 [PATCH 1/6] USB: host: isp116x: remove dentry pointer for debugfs Greg Kroah-Hartman
2021-02-16 14:46 ` Greg Kroah-Hartman [this message]
2021-02-16 14:46 ` [PATCH 3/6] USB: host: sl811: " Greg Kroah-Hartman
2021-02-16 14:46 ` [PATCH 4/6] USB: host: uhci: " Greg Kroah-Hartman
2021-02-16 14:46 ` [PATCH 5/6] USB: typec: fusb302: create debugfs subdir for the driver Greg Kroah-Hartman
2021-02-16 15:24 ` Guenter Roeck
2021-03-02 7:32 ` Greg Kroah-Hartman
2021-03-01 15:15 ` Heikki Krogerus
2021-02-16 14:46 ` [PATCH 6/6] USB: typec: tcpm: " Greg Kroah-Hartman
2021-02-16 15:22 ` Guenter Roeck
2021-03-01 15:16 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216144645.3813043-2-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).