From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D012C433ED for ; Thu, 8 Apr 2021 07:05:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7E4461154 for ; Thu, 8 Apr 2021 07:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229605AbhDHHFt (ORCPT ); Thu, 8 Apr 2021 03:05:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbhDHHFt (ORCPT ); Thu, 8 Apr 2021 03:05:49 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4B3EC061761 for ; Thu, 8 Apr 2021 00:05:36 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id ba6so1111972edb.1 for ; Thu, 08 Apr 2021 00:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=XL6pmCtw0aisCTAx5Q6WwykJOY4mYuR7CXn8H4btvug=; b=Owl162V8kudYfYtPsncmax2C072JwylJVebGsB5rQAL30MnnWhGh+T6LGVUq5bi39X SR8kXtUf+vxCFUEfQ8wjV8yEbgyLgGCbr+iQVlJ/HQHQ712zlbNtzUqfcX8ssd/MJQkD ZpXpCoJ+18sSgLABWd4LOPyKeDaJw7l6g3iSqKf9zLkIWhKZ+BaE0Fj8nDU7vT5+fXOW q3vPfsFZjy6sSexu0gmxEErXXQRMI5Mr4gGTCSFUryxpjn76rAS8YzBTwirCqvMfC4tT 9/LhSa6e12LHLr4brEF2Z10xkMta7BYvJlKoSvbe9GWQef6eK+I7I3BgcRE4LT8/aUN9 acgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=XL6pmCtw0aisCTAx5Q6WwykJOY4mYuR7CXn8H4btvug=; b=RZUCAvMNP27lc0a1oN03d3nvQSJ1JAb5rY9B7OaDSN3BjJM3LplbQEgzwiaBJ5gkxI bP3KQRnnXvIngeZaN4G5Rtua2TR7nYmUJiJj7ZulwHhvKfOMVUl74KnaMSQ39iemsE6w j1Is+ZrripgH2h4mRBZn9MQsgywRXLOaCPENu2Sx2nXSqopmfMX381eYciw0vftD/Va+ m4R2cyiWepV7+ClP/tG6x4yDL2O8qlM7rfz+LNouNHFlmqhaDaA2p+PGMEvldJTnKA9P E0GLlAEYNSQoB7lUtFVKS8dAJRYoU+hIX4ob7enLmPFvCT0AL6U3TDniH1eDVzoR2XEK 186A== X-Gm-Message-State: AOAM533uK2ZFJ88hssDkytJHWuv21PQVmu5CuFSWuRswSkGOtIq4FVBL cox+zQ41iO+IkwdEx8wrbT8KAA== X-Google-Smtp-Source: ABdhPJx8S1/cfXx06iS59ZXxOeX0+0ye0uZDtA0so3LsG7W52/duDSZFCJrS89Ki1+SDvYEJm3X/0w== X-Received: by 2002:a05:6402:b0e:: with SMTP id bm14mr9307439edb.148.1617865535369; Thu, 08 Apr 2021 00:05:35 -0700 (PDT) Received: from dell ([91.110.221.215]) by smtp.gmail.com with ESMTPSA id q20sm13598289ejs.41.2021.04.08.00.05.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 00:05:34 -0700 (PDT) Date: Thu, 8 Apr 2021 08:05:33 +0100 From: Lee Jones To: Benjamin Tissoires Cc: lkml , Jiri Kosina , message to , Linux USB Mailing List , "open list:HID CORE LAYER" Subject: Re: [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Message-ID: <20210408070533.GB2961413@dell> References: <20210326143458.508959-1-lee.jones@linaro.org> <20210326143458.508959-8-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, 07 Apr 2021, Benjamin Tissoires wrote: > On Fri, Mar 26, 2021 at 3:35 PM Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on > > > > Cc: Jiri Kosina > > Cc: Benjamin Tissoires > > Cc: message to > > Cc: linux-usb@vger.kernel.org > > Cc: linux-input@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > drivers/hid/usbhid/usbkbd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c > > index d5b7a696a68c5..d0c640be8a885 100644 > > --- a/drivers/hid/usbhid/usbkbd.c > > +++ b/drivers/hid/usbhid/usbkbd.c > > @@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = { > > * new key is pressed or a key that was pressed is released. > > * @led: URB for sending LEDs (e.g. numlock, ...) > > * @newleds: data that will be sent with the @led URB representing which LEDs > > - should be on > > + * should be on > > nitpick: checkpatch complains about spaces before tabs here. > > I amended locally and will push the fixed version. Those are usually highlighted in my editor. I wonder how I missed them. Thanks for cleaning it up though. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog