From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB9EC433ED for ; Sat, 10 Apr 2021 01:06:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B7776115A for ; Sat, 10 Apr 2021 01:06:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235319AbhDJBGx (ORCPT ); Fri, 9 Apr 2021 21:06:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:54924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235215AbhDJBGw (ORCPT ); Fri, 9 Apr 2021 21:06:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F020F61108; Sat, 10 Apr 2021 01:06:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618016799; bh=s8osdEXEHWK0uXbZb3OoiNNhqDzjRjCPWvJu8aGIU10=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dSnWl81LkF8fs/Vl1jFFifVH75VDgdKPn6NuNMaMkoXN9M70hzU1+n3gVLMRO/ZNt E6uOo3tOQen8ZOc6+4Rma9m0cPXTsAuAQIJ6oy96mbP+woCoqWvxbcHafCOsMwt3aF pvCC/8mvGuFJ/JdX9KNgsoFk2va4B+eYhQX5TbAt2/PtNknDKknX05aTmm2/J67Y1O b1WgSwfwYtdJ/H9/OM6anR59uE4nXRS9Mkdfz6PAqoegzRQJFMguWulOS24xw22uPj iFAT+tGFWNqodSeD4rghJaEt/Qplv9jSg7VC78mRE9bNaoDbuaYeNxu5aYZWK1B3HG E7DRCjdrYy3FA== Date: Sat, 10 Apr 2021 09:06:31 +0800 From: Peter Chen To: Dinghao Liu Cc: kjlu@umn.edu, Pawel Laszczak , Roger Quadros , Aswath Govindraju , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: cdns3: Fix rumtime PM imbalance on error Message-ID: <20210410010631.GA3862@b29397-desktop> References: <20210407052226.1056-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210407052226.1056-1-dinghao.liu@zju.edu.cn> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 21-04-07 13:22:26, Dinghao Liu wrote: > When cdns3_gadget_start() fails, a pairing PM usage counter > decrement is needed to keep the counter balanced. > > Signed-off-by: Dinghao Liu > --- > drivers/usb/cdns3/cdns3-gadget.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c > index 582bfeceedb4..ad891a108aed 100644 > --- a/drivers/usb/cdns3/cdns3-gadget.c > +++ b/drivers/usb/cdns3/cdns3-gadget.c > @@ -3255,8 +3255,11 @@ static int __cdns3_gadget_init(struct cdns *cdns) > pm_runtime_get_sync(cdns->dev); > > ret = cdns3_gadget_start(cdns); > - if (ret) > + if (ret) { > + pm_runtime_mark_last_busy(cdns->dev); > + pm_runtime_put_autosuspend(cdns->dev); > return ret; It doesn't need to delay entering runtime suspend, I prefer using pm_runtime_put_sync directly. -- Thanks, Peter Chen