From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EFC3C43460 for ; Mon, 12 Apr 2021 22:45:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85A066121E for ; Mon, 12 Apr 2021 22:45:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343864AbhDLWpq (ORCPT ); Mon, 12 Apr 2021 18:45:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343843AbhDLWpo (ORCPT ); Mon, 12 Apr 2021 18:45:44 -0400 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97874C06138F for ; Mon, 12 Apr 2021 15:45:25 -0700 (PDT) Received: by mail-ot1-x334.google.com with SMTP id w21-20020a9d63950000b02901ce7b8c45b4so14360271otk.5 for ; Mon, 12 Apr 2021 15:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=saYSSeNUB6f68qHbPtH0lWIscbgYxiJh/N21MR4VVmM=; b=plFvgQqlpcEZlby5QGnwVmREibuowaQLgHzWBNoa/mTnoRU67HMFunVGQFFEhnLMKz NZ6WyPOUM+oi3vGnS4FXCTkj610vgq30Yj39v+Q0JP50Yqfu0ZNGO2XrIk/3vOjSDpt9 kXEbIeDIAUX00IVZQEfISNrhd6OFoMhP+oD+Gx2li1w0iX7pmM2R8N5wGtiNc/8jEFrd tGO//Bu4OTfw+W8oBf+LPYL2Vx5f8yZhRCqIs3HH+6HLAyX7SsWd8jY+97DsanA2pK+w 7Cwglg8h7wtKoF49dd0za6rbt7H7OWybqtfAJFhSibWg8eoG4bpGwMfk1IX/iL2Q5xMv 9lIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=saYSSeNUB6f68qHbPtH0lWIscbgYxiJh/N21MR4VVmM=; b=lUVGxwHlGTGVs6dxaZpwJ0zL55vcJPF/6ZsZH2ewZ5cvn9xPMNqsNNj/luxpC2XwgH wuZW8R6jLsBH4HL0FNtmEXpwldXkdmeBczqCH6Aej5R7IAF2N+CQSHaIBgpy4G3QGQrh wp4U5dhyePWfd1OiK4wuUZMnfxD+2uZmDyD1eUwzljRXtqbpmYyyGEV4hFPNUc8jq1bK r34ar4bop9wz95L56ODrJfGfbdZeex38Bb6RQBZ8aouskeArJSdBa8k78EupfC2Doa4W kL1fjZFh1GrIOhQEu/vaRSrpy+DMDH5m/Ct7gm5pwPKVw0st4YvLAMBILaIfyT+4Ix7h +yMg== X-Gm-Message-State: AOAM533hwYTbT5MdlZutbkD6NJGD2My/8aXHkkzL2qP0Mze5JfR1DwkZ tem2Gxy67Nb8xLxdTCVfs4fv9A== X-Google-Smtp-Source: ABdhPJwSrXb3rCW0eBQ/8ooZbCrX0MY2r8U7shLWpwEX/QnDafcbmvQ1e6C+mwZA1aTioz5PkSkJKg== X-Received: by 2002:a05:6830:109:: with SMTP id i9mr25724854otp.47.1618267525004; Mon, 12 Apr 2021 15:45:25 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id s84sm2539988oie.39.2021.04.12.15.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 15:45:24 -0700 (PDT) Date: Mon, 12 Apr 2021 17:45:22 -0500 From: Bjorn Andersson To: Bixuan Cui Cc: Andy Gross , Felipe Balbi , Greg Kroah-Hartman , Philipp Zabel , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] usb: dwc3: qcom: Remove redundant dev_err call in dwc3_qcom_probe() Message-ID: <20210412224522.GD1538589@yoga> References: <20210410024818.65659-1-cuibixuan@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210410024818.65659-1-cuibixuan@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri 09 Apr 21:48 CDT 2021, Bixuan Cui wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot > Signed-off-by: Bixuan Cui Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/usb/dwc3/dwc3-qcom.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index e37cc58dfa55..726d5048d87c 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -774,7 +774,6 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > > qcom->qscratch_base = devm_ioremap_resource(dev, parent_res); > if (IS_ERR(qcom->qscratch_base)) { > - dev_err(dev, "failed to map qscratch, err=%d\n", ret); > ret = PTR_ERR(qcom->qscratch_base); > goto clk_disable; > } >