* [PATCH -next] usb: dwc3: qcom: Remove redundant dev_err call in dwc3_qcom_probe()
@ 2021-04-10 2:48 Bixuan Cui
2021-04-11 12:07 ` Felipe Balbi
2021-04-12 22:45 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Bixuan Cui @ 2021-04-10 2:48 UTC (permalink / raw)
To: cuibixuan, Andy Gross, Bjorn Andersson, Felipe Balbi,
Greg Kroah-Hartman, Philipp Zabel
Cc: linux-arm-msm, linux-usb, kernel-janitors
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
drivers/usb/dwc3/dwc3-qcom.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
index e37cc58dfa55..726d5048d87c 100644
--- a/drivers/usb/dwc3/dwc3-qcom.c
+++ b/drivers/usb/dwc3/dwc3-qcom.c
@@ -774,7 +774,6 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
qcom->qscratch_base = devm_ioremap_resource(dev, parent_res);
if (IS_ERR(qcom->qscratch_base)) {
- dev_err(dev, "failed to map qscratch, err=%d\n", ret);
ret = PTR_ERR(qcom->qscratch_base);
goto clk_disable;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] usb: dwc3: qcom: Remove redundant dev_err call in dwc3_qcom_probe()
2021-04-10 2:48 [PATCH -next] usb: dwc3: qcom: Remove redundant dev_err call in dwc3_qcom_probe() Bixuan Cui
@ 2021-04-11 12:07 ` Felipe Balbi
2021-04-12 22:45 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2021-04-11 12:07 UTC (permalink / raw)
To: Bixuan Cui, cuibixuan, Andy Gross, Bjorn Andersson,
Greg Kroah-Hartman, Philipp Zabel
Cc: linux-arm-msm, linux-usb, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 339 bytes --]
Bixuan Cui <cuibixuan@huawei.com> writes:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] usb: dwc3: qcom: Remove redundant dev_err call in dwc3_qcom_probe()
2021-04-10 2:48 [PATCH -next] usb: dwc3: qcom: Remove redundant dev_err call in dwc3_qcom_probe() Bixuan Cui
2021-04-11 12:07 ` Felipe Balbi
@ 2021-04-12 22:45 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2021-04-12 22:45 UTC (permalink / raw)
To: Bixuan Cui
Cc: Andy Gross, Felipe Balbi, Greg Kroah-Hartman, Philipp Zabel,
linux-arm-msm, linux-usb, kernel-janitors
On Fri 09 Apr 21:48 CDT 2021, Bixuan Cui wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index e37cc58dfa55..726d5048d87c 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -774,7 +774,6 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>
> qcom->qscratch_base = devm_ioremap_resource(dev, parent_res);
> if (IS_ERR(qcom->qscratch_base)) {
> - dev_err(dev, "failed to map qscratch, err=%d\n", ret);
> ret = PTR_ERR(qcom->qscratch_base);
> goto clk_disable;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-12 22:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-10 2:48 [PATCH -next] usb: dwc3: qcom: Remove redundant dev_err call in dwc3_qcom_probe() Bixuan Cui
2021-04-11 12:07 ` Felipe Balbi
2021-04-12 22:45 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).