From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Chen <peter.chen@kernel.org>
Cc: Pawel Laszczak <pawell@cadence.com>,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
kurahul@cadence.com
Subject: Re: [PATCH] usb: cdnsp: Useless condition has been removed
Date: Fri, 30 Apr 2021 07:52:48 +0300 [thread overview]
Message-ID: <20210430045248.GG21598@kadam> (raw)
In-Reply-To: <20210430034349.GB3842@nchen>
On Fri, Apr 30, 2021 at 11:43:49AM +0800, Peter Chen wrote:
> On 21-04-29 10:49:14, Pawel Laszczak wrote:
> > From: Pawel Laszczak <pawell@cadence.com>
> >
> > Patch removes the warning "variable dereferenced before
> > check 'pdev->dcbaa'" from cdnsp_mem_cleanup.
>
> You may describe the real problem you fix, but not the warning
> message from some auto build system.
>
I really feel people have become too lost in the weeds of what matters
and what does not. For internships, people want picky feedback in case
they're forced to deal with the ultra drill sargent maintainers. But
really the important thing in a commit message is if you can understand
the problem and the fix. In this case everyone who is capable of
understanding the patch can understand the commit message.
Also if you're going to criticize someone's commit message then just
write it the way you want so they can copy and paste. I had someone
yesterday say that my commit message where I deleted a NULL check and
related dead code was not clear enough that the behavior was
"intentional" and I took that to mean that they wanted me to say that
deleting the dead code did not change runtime behavior. I'm still not
sure that's what they wanted me to add... The point is no one can read
your mind, if you want a commit message to say something specific then
just say it instead of hinting around the bush and we have to send a v2
and v3 commit message.
regards,
dan carpenter
next prev parent reply other threads:[~2021-04-30 4:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 8:49 [PATCH] usb: cdnsp: Useless condition has been removed Pawel Laszczak
2021-04-30 3:43 ` Peter Chen
2021-04-30 4:52 ` Dan Carpenter [this message]
2021-04-30 7:11 ` Peter Chen
2021-04-30 11:51 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430045248.GG21598@kadam \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kurahul@cadence.com \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).