From: Kyle Tso <kyletso@google.com>
To: linux@roeck-us.net, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org
Cc: badhri@google.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, lkp@intel.com,
Kyle Tso <kyletso@google.com>
Subject: [PATCH v2 0/2] Fix some VDM AMS handling
Date: Sun, 23 May 2021 09:58:53 +0800 [thread overview]
Message-ID: <20210523015855.1785484-1-kyletso@google.com> (raw)
Changes since v1:
-----------------
usb: typec: tcpm: Properly interrupt VDM AMS
- fix the bug reported by "kernel test robot <lkp@intel.com>"
- add Reviewed-by: tag from Guenter
usb: typec: tcpm: Respond Not_Supported if no snk_vdo
- no changes in code
- add Reviewed-by: tag from Guenter
v1 cover letter:
----------------
usb: typec: tcpm: Properly interrupt VDM AMS
- If VDM AMS is interrupted by Messages other than VDM, the current VDM
AMS should be finished before handling the just arrived request. I add
intercept code in the beginning of the handler of the three types of
requests (control/data/extended) to ensure that the AMS is finished
first.
usb: typec: tcpm: Respond Not_Supported if no snk_vdo
- The snk_vdo is for the responses to incoming VDM Discover Identity. If
there is no data in snk_vdo, it means that the port doesn't even
support it. According to PD3 Spec "Table 6-64 Response to an incoming
VDM", the port should send Not_Supported Message as the response. For
PD2 cases, it is defined in PD2 Spec "Table 6-41 Applicability of
Structured VDM Commands - Note 3" that the port should "Ignore" the
command.
Kyle Tso (2):
usb: typec: tcpm: Properly interrupt VDM AMS
usb: typec: tcpm: Respond Not_Supported if no snk_vdo
drivers/usb/typec/tcpm/tcpm.c | 35 ++++++++++++++++++++++++++++++++++-
1 file changed, 34 insertions(+), 1 deletion(-)
--
2.31.1.818.g46aad6cb9e-goog
next reply other threads:[~2021-05-23 1:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 1:58 Kyle Tso [this message]
2021-05-23 1:58 ` [PATCH v2 1/2] usb: typec: tcpm: Properly interrupt VDM AMS Kyle Tso
2021-05-24 10:22 ` Heikki Krogerus
2021-05-23 1:58 ` [PATCH v2 2/2] usb: typec: tcpm: Respond Not_Supported if no snk_vdo Kyle Tso
2021-05-24 10:22 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210523015855.1785484-1-kyletso@google.com \
--to=kyletso@google.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).