From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75431C4320A for ; Thu, 29 Jul 2021 12:29:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A8BE60F0F for ; Thu, 29 Jul 2021 12:29:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236993AbhG2M3r (ORCPT ); Thu, 29 Jul 2021 08:29:47 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53471 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236868AbhG2M3q (ORCPT ); Thu, 29 Jul 2021 08:29:46 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C298F5C00BC; Thu, 29 Jul 2021 08:29:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 29 Jul 2021 08:29:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=6 Fzowjt81NyaUnF7+p0gjmnL8GZGPKJTWRJZvkPp5zI=; b=t5hVYCm7duDUEFcP6 3WwSXJaFRoCc4zRc3hX+btqmFT+DyvnNUJ4sRbdle+jxSXIETePlw0gzeAtwm7VE J93QgY4ygk6rKzrxizRV/eWXAs7wzsWQ3r+1BuMGr+zsmA31sxqe2Q+n5oNLKSgz Lcjkpn1v6Oh2IrIDqyyyILloohEKQ5Jg/tlPYyzqDBhuoazkDUcNIB7eXWjNjmOZ /FybOC5O3faOf6QR4tqcQADTrx93FxwlwAetYWnxqlSkr1xlAum1Znfo+siQOJgW r4jQ24UczLcLXJw+y+y3f0bje7j5cLuZCNYmfXyVO9m0gF4e0HLaQQnHXsl/ej7p O8sDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=6Fzowjt81NyaUnF7+p0gjmnL8GZGPKJTWRJZvkPp5 zI=; b=keTZeIBGLbbkPxUAgv2Hafk98V4NlP0BFbHN01qov27OJTv6gMSe2QUc+ IFZkF08DEyhC3eR8iRvWb1XH2SOZGXDkAMzUPVeNhrvbGvElg7LOnepHrhSCIsO5 HRcPBMAjgP7p+nNKX8zZTZbIh1IKE0ydeAiLPRiyYNYbg/hzoFdhZ8BGWSN2INsd hUSO4BZz6XwQYXC0xOuBvwxafKd+t3lHS9ly3Wzc1rPSvQf/F4bJ/L+QQadmejAq dvD1pXksY2FQwN1MqtleVGsEF6vrXlajAkBX+/50mDHtt0vzhTgFN6KCqiv1QPaN HLNVcuuQG8saKYN4eEIBM7xpr0mFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrheefgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepgfejtedtjefggfffvdetuedthedtheegheeuteekfeeghfdtteejkeeludeg vddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Jul 2021 08:29:40 -0400 (EDT) Date: Thu, 29 Jul 2021 14:29:38 +0200 From: Maxime Ripard To: Rob Herring Cc: Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, Frank Rowand , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH 35/54] dt-bindings: usb: dwc3: Fix usb-phy check Message-ID: <20210729122938.t432abpl2dm2p46c@gilmour> References: <20210721140424.725744-1-maxime@cerno.tech> <20210721140424.725744-36-maxime@cerno.tech> <20210723221530.GA2684283@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210723221530.GA2684283@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Rob, On Fri, Jul 23, 2021 at 04:15:30PM -0600, Rob Herring wrote: > On Wed, Jul 21, 2021 at 04:04:05PM +0200, Maxime Ripard wrote: > > The original binding was allowing any combination of usb2-phy and > > usb3-phy in the phys and phy-names properties. > >=20 > > However, the current binding enforces that those properties must be a > > list of usb2-phy and usb3-phy, with exactly one element, effectively > > making usb2-phy the only value being valid. >=20 > Huh? If 'maxItems' is not specified, then it's the length of 'items'=20 > list. Even if minItems is set? This doesn't really change anything to my issue though. """ - phy-names: from the *Generic PHY* bindings; supported names are "usb2-ph= y" or "usb3-phy". """ The YAML binding has phy-names: minItems: 1 items: - const: usb2-phy - const: usb3-phy which means that only usb2-phy is accepted (and possibly usb2-phy, usb3-phy) but only usb3-phy isn't anymore, while it was valid according to the original binding and used in multiple DT across multiple vendors (arch/arm64/boot/dts/hisilicon/hi3660.dtsi, arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi) > > Let's rework the properties description to allow either one or two > > element picked with values either usb2-phy or usb3-phy. The rest of the > > tooling makes sure that we don't get any duplicate value, so this should > > be what we want. >=20 > Is it really valid to have only a USB3 PHY and what you want here? That= =20 > would mean the USB3 phy also handles USB2, right? IIRC that's how it works for the H6 at least yes. Maxime