From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41177C4338F for ; Wed, 4 Aug 2021 01:38:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EE4660F43 for ; Wed, 4 Aug 2021 01:38:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233811AbhHDBiZ (ORCPT ); Tue, 3 Aug 2021 21:38:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:41654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233389AbhHDBiZ (ORCPT ); Tue, 3 Aug 2021 21:38:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5A38B60F43; Wed, 4 Aug 2021 01:38:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628041093; bh=bk+spCsV4AgC1emyrz5YNXIRikPuxzecGwY4jsyB5y8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OTgRclDdCe9kNNC/9ldoL/1fzXVofXEaikXmpBmjZaOP7Ok59ROE18ZnBsVcjv2tN XFKCfoJHzmedCSORJnKChaveejcClE5fv6rLdCGFkv4PhbcAWliTHn+oAwevaIXM+W wIlf+4XwGqhPKbHZ1taEl4OT0hPonSsxpRgCVONDoSeKMyuAOVJXyFF97neZ8zSwNR 5VYcYcqb/8GPIgXI1zz49VP3AZp8FDPsOCW8GGuPBnMF13X0CXYaoO1geTNrEY/Elp 4eQXng7qrlu4Xey1cg2SMSsS6IegPkw3YZTQVCupcN0IVnaYXJJ437Xrn1H8H40jC4 L+j3nWFJPD3tw== Date: Wed, 4 Aug 2021 09:38:09 +0800 From: Peter Chen To: Salah Triki Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: chipidea: get lock before calling usb_[disable|enable]_autosuspend() Message-ID: <20210804013809.GA16676@nchen> References: <20210802215212.GA1350820@pc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210802215212.GA1350820@pc> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 21-08-02 22:52:12, Salah Triki wrote: > Based on the documentation of usb_[disable|enable]_autosuspend(), the > caller must hold udev's device lock. > > Signed-off-by: Salah Triki > --- > drivers/usb/chipidea/otg_fsm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/chipidea/otg_fsm.c b/drivers/usb/chipidea/otg_fsm.c > index 6ed4b00dba96..2d4174250432 100644 > --- a/drivers/usb/chipidea/otg_fsm.c > +++ b/drivers/usb/chipidea/otg_fsm.c > @@ -518,12 +518,14 @@ static void ci_otg_loc_sof(struct otg_fsm *fsm, int on) > if (!udev) > return; > > + usb_lock_device(udev); > if (on) { > usb_disable_autosuspend(udev); > } else { > pm_runtime_set_autosuspend_delay(&udev->dev, 0); > usb_enable_autosuspend(udev); > } > + usb_unlock_device(udev); > } > Acked-by: Peter Chen -- Thanks, Peter Chen