From: Salah Triki <salah.triki@gmail.com>
To: Keith Packard <keithp@keithp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: misc: chaoskey: remove useless else
Date: Fri, 13 Aug 2021 17:40:49 +0100 [thread overview]
Message-ID: <20210813164049.GA2310720@pc> (raw)
Remove useless else in order to make the code cleaner.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
drivers/usb/misc/chaoskey.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/misc/chaoskey.c b/drivers/usb/misc/chaoskey.c
index 87067c3d6109..9814ac2201d5 100644
--- a/drivers/usb/misc/chaoskey.c
+++ b/drivers/usb/misc/chaoskey.c
@@ -299,14 +299,11 @@ static int chaoskey_release(struct inode *inode, struct file *file)
--dev->open;
- if (!dev->present) {
- if (dev->open == 0) {
- mutex_unlock(&dev->lock);
+ mutex_unlock(&dev->lock);
+
+ if (!dev->present)
+ if (dev->open == 0)
chaoskey_free(dev);
- } else
- mutex_unlock(&dev->lock);
- } else
- mutex_unlock(&dev->lock);
usb_dbg(interface, "release success");
return 0;
--
2.25.1
next reply other threads:[~2021-08-13 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 16:40 Salah Triki [this message]
2021-08-13 17:38 ` [PATCH] usb: misc: chaoskey: remove useless else Keith Packard
2021-08-14 6:34 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813164049.GA2310720@pc \
--to=salah.triki@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).