From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F76C4320A for ; Wed, 18 Aug 2021 17:49:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D4F16104F for ; Wed, 18 Aug 2021 17:49:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232708AbhHRRtw (ORCPT ); Wed, 18 Aug 2021 13:49:52 -0400 Received: from netrider.rowland.org ([192.131.102.5]:36019 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S231311AbhHRRtu (ORCPT ); Wed, 18 Aug 2021 13:49:50 -0400 Received: (qmail 202749 invoked by uid 1000); 18 Aug 2021 13:49:13 -0400 Date: Wed, 18 Aug 2021 13:49:13 -0400 From: Alan Stern To: Kees Cook Cc: Greg Kroah-Hartman , Arnd Bergmann , Al Cooper , Andy Shevchenko , Florian Fainelli , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 0/2] USB: EHCI: Add register array bounds to HCS ports Message-ID: <20210818174913.GB197200@rowland.harvard.edu> References: <20210818173018.2259231-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818173018.2259231-1-keescook@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Aug 18, 2021 at 10:30:16AM -0700, Kees Cook wrote: > Hi, > > This is cleaning up some of the remaining things to be able to apply > -Warray-bounds and -Wzero-length-bounds globally. Only after doing my > own version of the port_status patch did I find Arnd's earlier > patches, including for the weird Broadcom stuff[1]. > > No binary differences. > > v2: > - use 0x80 as base for brcm registers (stern) > - switch HCS_N_PORTS_MAX to decimal (stern) > - update various comments (stern) > v1: https://lore.kernel.org/lkml/20210818043035.1308062-1-keescook@chromium.org > > Thanks! > > -Kees > > [1] https://lore.kernel.org/lkml/20200527134320.869042-1-arnd@arndb.de/#t > > Kees Cook (2): > USB: EHCI: Add register array bounds to HCS ports > USB: EHCI: Add alias for Broadcom INSNREG > > drivers/usb/host/ehci-brcm.c | 11 ++++------- > include/linux/usb/ehci_def.h | 33 +++++++++++++++++++++------------ > 2 files changed, 25 insertions(+), 19 deletions(-) For both patches: Acked-by: Alan Stern