From: Utkarsh Verma <email@example.com> To: Johan Hovold <firstname.lastname@example.org> Cc: Greg Kroah-Hartman <email@example.com>, firstname.lastname@example.org, email@example.com, Lukas Bulwahn <firstname.lastname@example.org> Subject: Re: [PATCH] USB: serial: iuu_phoenix: Replace symbolic permissions by octal permissions Date: Wed, 25 Aug 2021 00:45:37 +0530 [thread overview] Message-ID: <20210824191537.GA6181@uver-laptop> (raw) In-Reply-To: <YST6XZ/XJkTDm6rV@hovoldconsulting.com> On Tue, Aug 24, 2021 at 03:55:41PM +0200, Johan Hovold wrote: > On Sat, Aug 21, 2021 at 12:33:06AM +0530, Utkarsh Verma wrote: > > This fixed the below checkpatch issue: > > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > > Consider using octal permissions '0644'. > > Please do not run checkpatch.pl on code that's already in the tree. Use > it for your own patches before submitting them and always use your own > judgement when considering its suggestions. > Okay, I will not run checkpatch on the code that's already in the tree. > This code does not need to be changed. > But using the octal permission bits makes the code more readable. So I made the change. But if you don't want such changes, I will refrain from doing it in the future. Anyway thanks for the review. Regards, Utkarsh Verma
next prev parent reply other threads:[~2021-08-24 19:16 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-20 19:03 Utkarsh Verma 2021-08-24 13:55 ` Johan Hovold 2021-08-24 19:15 ` Utkarsh Verma [this message] 2021-08-25 9:24 ` Johan Hovold 2021-08-25 16:23 ` [PATCH v2] USB: serial: " Utkarsh Verma 2021-08-26 7:51 ` Johan Hovold
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210824191537.GA6181@uver-laptop \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] USB: serial: iuu_phoenix: Replace symbolic permissions by octal permissions' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).