linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Piyush Mehta <piyush.mehta@xilinx.com>
To: <gregkh@linuxfoundation.org>, <robh+dt@kernel.org>,
	<mka@chromium.org>, <ravisadineni@chromium.org>,
	<stern@rowland.harvard.edu>, <alcooperx@gmail.com>,
	<michal.simek@xilinx.com>
Cc: <piyush.mehta@xilinx.com>, <linux-usb@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<git@xilinx.com>, <sgoud@xilinx.com>
Subject: [PATCH V2 0/2] usb: misc: add support for microchip,usb2244 USB-SD controller
Date: Mon, 22 Nov 2021 11:58:32 +0530	[thread overview]
Message-ID: <20211122062834.1812005-1-piyush.mehta@xilinx.com> (raw)

Microchip's USB224x family of Hi-Speed USB 2.0 flash media card
controllers provide an ultra-fast interface between a USB host
controller and flash media cards.

This patch adds a GPIO based usb-sd reset for USB2244 USB2 ultra
fast SD controller. This usb2244 driver trigger sd reset signal
after soft reset or core Reset. The SD needs to be resetted after
completion of phy initialization. After the toggling of gpio,
controller gets out form reset.

As part of the reset, sets the direction of the pin to output before
toggling the pin. Delay of microseconds is added in between low and
high to meet the setup and hold time requirement of the reset.
---
Changes for V2:
- Update reset polarity, make reset ACTIVE LOW in the dt-binding document
  and usb2244 driver.
- Fix WARNING: msleep < 20ms can sleep for up to 20ms by changing msleep to
  usleep_range()
- Addressed Rob Herring review comments
  - Added usbsd node under the usb controller (usb0) node.
  - Remove Warning: decoded text below may be mangled, UTF-8 assumed.	

Review comments:
Link: https://lore.kernel.org/lkml/20211024180628.2992108-3-piyush.mehta@xilinx.com/t/#m2e146078276051984a144ba074c6cf4eee07b4d0
---
Piyush Mehta (2):
  dt-bindings: usb: misc: Add binding for Microchip usb2244 Controller
  usb: misc: usb244: add support for USB2 ultra fast sd controller

 .../devicetree/bindings/usb/microchip,usb2244.yaml | 47 +++++++++++++++
 drivers/usb/misc/Kconfig                           | 10 ++++
 drivers/usb/misc/Makefile                          |  1 +
 drivers/usb/misc/usb2244.c                         | 69 ++++++++++++++++++++++
 4 files changed, 127 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/microchip,usb2244.yaml
 create mode 100644 drivers/usb/misc/usb2244.c

-- 
2.7.4


             reply	other threads:[~2021-11-22  6:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22  6:28 Piyush Mehta [this message]
2021-11-22  6:28 ` [PATCH V2 1/2] dt-bindings: usb: misc: Add binding for Microchip usb2244 Controller Piyush Mehta
2021-11-30  2:11   ` Rob Herring
2021-11-30 10:23     ` Michal Simek
2021-11-22  6:28 ` [PATCH V2 2/2] usb: misc: usb244: add support for USB2 ultra fast sd controller Piyush Mehta
2021-11-22  7:02   ` Greg KH
2021-11-22 11:02     ` Michal Simek
2021-11-22 11:07       ` Greg KH
2021-11-30  2:14       ` Rob Herring
2021-11-30 10:42         ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211122062834.1812005-1-piyush.mehta@xilinx.com \
    --to=piyush.mehta@xilinx.com \
    --cc=alcooperx@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=git@xilinx.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=mka@chromium.org \
    --cc=ravisadineni@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=sgoud@xilinx.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).