From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6201EC433EF for ; Wed, 15 Dec 2021 13:03:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237360AbhLONDq (ORCPT ); Wed, 15 Dec 2021 08:03:46 -0500 Received: from mail-m17643.qiye.163.com ([59.111.176.43]:17444 "EHLO mail-m17643.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229643AbhLONDp (ORCPT ); Wed, 15 Dec 2021 08:03:45 -0500 DKIM-Signature: a=rsa-sha256; b=Ml06YF1ogto7VxqnsCz3mZ5pM2T5LXtlXByTAmrSeIwr2e5er4CQORQzckbApAeIiZkIjsl8+K6cp27bVNrFEATx+dYgCA6sMNdqoZdWNiIjxWCiDri2aoZvbYCOmp/DbpsdM9fC9k9pYturziCjFRhQvY5JpQ9Z5M2PUunkqJU=; s=default; c=relaxed/relaxed; d=vivo.com; v=1; bh=RWcY89ErvPEeUtYtul67R6QvSk7GdHCL3vo/k7DyrAY=; h=date:mime-version:subject:message-id:from; Received: from vivo-600-G6.vivo.xyz (unknown [58.251.74.232]) by mail-m17643.qiye.163.com (Hmail) with ESMTPA id E4A997E01F1; Wed, 15 Dec 2021 21:03:38 +0800 (CST) From: Yaqin Pan To: Greg Kroah-Hartman , Rob Herring , Felipe Balbi , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel@vivo.com, Yaqin Pan Subject: [PATCH 1/2] usb: dwc3: Add a quirk to set GUCTL.SPRSCTRLTRANSEN bit. Date: Wed, 15 Dec 2021 21:03:23 +0800 Message-Id: <20211215130325.19017-2-akingchen@vivo.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211215130325.19017-1-akingchen@vivo.com> References: <20211215130325.19017-1-akingchen@vivo.com> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWRlMHU1WTElOGh0aS0xJTE wZVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWVVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Okk6Ehw4Az5MMTI3SBI4HEk1 DwhPCiFVSlVKTUhCTkxIT0pCTk1JVTMWGhIXVRoQEhUcGBMeFTsNEg0UVRgUFkVZV1kSC1lBWU5D VUlOSlVMT1VJSElZV1kIAVlBT0pNSDcG X-HM-Tid: 0a7dbe30f500d999kuwse4a997e01f1 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This quirk is only for dwc3 host mode. the dwc3 controller can't emurate some devices successfully. For example, TF card reader (aaaa:8816): failed log usb 1-1: new high-speed USB device number 2 using xhci-hcd usb 1-1: device descriptor read/all, error -110 >From the usb analyzer, always return NAK in the data phase. if enable the GUCTL.SPRSCTRLTRANSEN bit. then the log is: usb 2-1: new high-speed USB device number 3 using xhci-hcd usb 2-1: New USB device found, idVendor=aaaa, idProduct=8816, bcdDevice=13.08 usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 2-1: Product: MXT USB Device usb 2-1: Manufacturer: MXTronics usb 2-1: SerialNumber: 150101v01 usb 2-1: New USB device found, VID=aaaa, PID=8816 Some devices are slow in responding to Control transfers. Scheduling mulitiple transactions in one microframe/frame can cause the devices to misbehave. if this qurik is enabled, the host controller schedules transations for a Control transfer in defferent microframes/frame. Signed-off-by: Yaqin Pan --- drivers/usb/dwc3/core.c | 4 ++++ drivers/usb/dwc3/core.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index ba74ad7f6995..93ac2c79a2c0 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1071,6 +1071,8 @@ static int dwc3_core_init(struct dwc3 *dwc) * packet with Retry=1 & Nump != 0) */ reg |= DWC3_GUCTL_HSTINAUTORETRY; + if (dwc->sprs_ctrl_trans_quirk) + reg |= DWC3_GUCTL_SPRSCTRLTRANSEN; dwc3_writel(dwc->regs, DWC3_GUCTL, reg); } @@ -1377,6 +1379,8 @@ static void dwc3_get_properties(struct dwc3 *dwc) dwc->dis_split_quirk = device_property_read_bool(dev, "snps,dis-split-quirk"); + dwc->sprs_ctrl_trans_quirk = device_property_read_bool(dev, + "snps,sprs-ctrl-trans-quirk"); dwc->lpm_nyet_threshold = lpm_nyet_threshold; dwc->tx_de_emphasis = tx_de_emphasis; diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 5991766239ba..6048087df1d1 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -254,6 +254,7 @@ /* Global User Control Register */ #define DWC3_GUCTL_HSTINAUTORETRY BIT(14) +#define DWC3_GUCTL_SPRSCTRLTRANSEN BIT(17) /* Global User Control 1 Register */ #define DWC3_GUCTL1_PARKMODE_DISABLE_SS BIT(17) @@ -1077,6 +1078,7 @@ struct dwc3_scratchpad_array { * 3 - Reserved * @dis_metastability_quirk: set to disable metastability quirk. * @dis_split_quirk: set to disable split boundary. + * @sprs_ctrl_trans_quirk: set to enable sparse control transaction quirk. * @imod_interval: set the interrupt moderation interval in 250ns * increments or 0 to disable. */ @@ -1279,6 +1281,7 @@ struct dwc3 { unsigned dis_metastability_quirk:1; unsigned dis_split_quirk:1; + unsigned sprs_ctrl_trans_quirk:1; unsigned async_callbacks:1; u16 imod_interval; -- 2.17.1