From: Jeff Vanhoof <jdv1029@gmail.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, John Youn <John.Youn@synopsys.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v3 2/2] usb: dwc3: gadget: Don't set IMI for no_interrupt
Date: Wed, 26 Oct 2022 03:23:16 -0500 [thread overview]
Message-ID: <20221026082314.GA25910@qjv001-XeonWs> (raw)
In-Reply-To: <ced336c84434571340c07994e3667a0ee284fefe.1666735451.git.Thinh.Nguyen@synopsys.com>
On Tue, Oct 25, 2022 at 03:10:20PM -0700, Thinh Nguyen wrote:
> The gadget driver may have a certain expectation of how the request
> completion flow should be from to its configuration. Make sure the
> controller driver respect that. That is, don't set IMI (Interrupt on
> Missed Isoc) when usb_request->no_interrupt is set. Also, the driver
> should only set IMI to the last TRB of a chain.
>
> Fixes: 72246da40f37 ("usb: Introduce DesignWare USB3 DRD Driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> ---
> Changes in v3:
> - Set IMI to only the last TRB of a chain
> Changes in v2:
> - None
>
> drivers/usb/dwc3/gadget.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 230b3c660054..5fe2d136dff5 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -1292,8 +1292,8 @@ static void dwc3_prepare_one_trb(struct dwc3_ep *dep,
> trb->ctrl = DWC3_TRBCTL_ISOCHRONOUS;
> }
>
> - /* always enable Interrupt on Missed ISOC */
> - trb->ctrl |= DWC3_TRB_CTRL_ISP_IMI;
> + if (!no_interrupt && !chain)
> + trb->ctrl |= DWC3_TRB_CTRL_ISP_IMI;
> break;
>
> case USB_ENDPOINT_XFER_BULK:
> --
> 2.28.0
>
No new issues seen with these changes. Changes look good to me.
Reviewed-by: Jeff Vanhoof <jdv1029@gmail.com>
Tested-by: Jeff Vanhoof <jdv1029@gmail.com>
Regards,
Jeff
prev parent reply other threads:[~2022-10-26 8:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 22:10 [PATCH v3 0/2] usb: dwc3: gadget: Fix isoc interrupt check Thinh Nguyen
2022-10-25 22:10 ` [PATCH v3 1/2] usb: dwc3: gadget: Stop processing more requests on IMI Thinh Nguyen
2022-10-26 8:24 ` Jeff Vanhoof
2022-10-25 22:10 ` [PATCH v3 2/2] usb: dwc3: gadget: Don't set IMI for no_interrupt Thinh Nguyen
2022-10-26 8:23 ` Jeff Vanhoof [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026082314.GA25910@qjv001-XeonWs \
--to=jdv1029@gmail.com \
--cc=John.Youn@synopsys.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).