From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, kernel@pengutronix.de
Subject: [PATCH 07/11] usb: phy: mv: Convert to platform remove callback returning void
Date: Sun, 19 Mar 2023 10:24:24 +0100 [thread overview]
Message-ID: <20230319092428.283054-8-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20230319092428.283054-1-u.kleine-koenig@pengutronix.de>
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/usb/phy/phy-mv-usb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/phy/phy-mv-usb.c b/drivers/usb/phy/phy-mv-usb.c
index 86503b7d695c..df7c27474a75 100644
--- a/drivers/usb/phy/phy-mv-usb.c
+++ b/drivers/usb/phy/phy-mv-usb.c
@@ -644,7 +644,7 @@ static const struct attribute_group *mv_otg_groups[] = {
NULL,
};
-static int mv_otg_remove(struct platform_device *pdev)
+static void mv_otg_remove(struct platform_device *pdev)
{
struct mv_otg *mvotg = platform_get_drvdata(pdev);
@@ -654,8 +654,6 @@ static int mv_otg_remove(struct platform_device *pdev)
mv_otg_disable(mvotg);
usb_remove_phy(&mvotg->phy);
-
- return 0;
}
static int mv_otg_probe(struct platform_device *pdev)
@@ -869,7 +867,7 @@ static int mv_otg_resume(struct platform_device *pdev)
static struct platform_driver mv_otg_driver = {
.probe = mv_otg_probe,
- .remove = mv_otg_remove,
+ .remove_new = mv_otg_remove,
.driver = {
.name = driver_name,
.dev_groups = mv_otg_groups,
--
2.39.2
next prev parent reply other threads:[~2023-03-19 9:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 9:24 [PATCH 00/11] usb: phy: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-19 9:24 ` [PATCH 01/11] usb: phy: ab8500: " Uwe Kleine-König
2023-03-19 9:24 ` [PATCH 02/11] usb: phy: am335x: " Uwe Kleine-König
2023-03-19 9:24 ` [PATCH 03/11] usb: phy: fsl: " Uwe Kleine-König
2023-03-19 9:24 ` [PATCH 04/11] usb: phy: generic: " Uwe Kleine-König
2023-03-19 9:24 ` [PATCH 05/11] usb: phy: gpio-vbus: " Uwe Kleine-König
2023-03-19 20:43 ` Linus Walleij
2023-03-19 9:24 ` [PATCH 06/11] usb: phy: keystone: " Uwe Kleine-König
2023-03-19 9:24 ` Uwe Kleine-König [this message]
2023-03-19 9:24 ` [PATCH 08/11] usb: phy: mxs: " Uwe Kleine-König
2023-03-20 14:54 ` [EXT] " Frank Li
2023-03-19 9:24 ` [PATCH 09/11] usb: phy: tahvo: " Uwe Kleine-König
2023-03-19 9:24 ` [PATCH 10/11] usb: phy: tegra: " Uwe Kleine-König
2023-03-19 9:24 ` [PATCH 11/11] usb: phy: twl6030: " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230319092428.283054-8-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).