Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Tejas Joglekar <Tejas.Joglekar@synopsys.com>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org
Cc: John Youn <John.Youn@synopsys.com>
Subject: Re: [PATCH v4 3/3] usb: dwc3: Pass quirk as platform data
Date: Wed, 14 Oct 2020 11:37:04 +0300
Message-ID: <29322e22-3b5b-037d-82ba-8e8ac28cd325@gmail.com> (raw)
In-Reply-To: <b3dbe5d9de39fb5105b8474e9c560917a78e2c63.1602592488.git.joglekar@synopsys.com>

Hello!

On 13.10.2020 15:44, Tejas Joglekar wrote:

> This commit adds the platform device data to setup
> the XHCI_SG_TRB_CACHE_SIZE_QUIRK quirk. DWC3 hosts
> which are PCI devices does not use OF to create platform device
> but create xhci-plat platform device runtime. So
                                       ^ at

> this patch allow parent device to supply the quirk

    Allows.

> through platform data.
> 
> Signed-off-by: Tejas Joglekar <joglekar@synopsys.com>
> ---
>   drivers/usb/dwc3/host.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index e195176580de..dd7c742333f7 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -11,6 +11,15 @@
>   #include <linux/platform_device.h>
>   
>   #include "core.h"
> +#include "../host/xhci-plat.h"
> +
> +static const struct xhci_plat_priv dwc3_pdata = {
> +	.plat_start = NULL,
> +	.init_quirk = NULL,
> +	.suspend_quirk = NULL,
> +	.resume_quirk = NULL,

    Why not rely on the compiler to fill these with zeros?

> +	.quirks = XHCI_SG_TRB_CACHE_SIZE_QUIRK,
> +};
>   
>   static int dwc3_host_get_irq(struct dwc3 *dwc)
>   {
[...]

MBR, Sergei

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13 12:43 [PATCH v4 0/3] Add logic to consolidate TRBs for Synopsys xHC Tejas Joglekar
2020-10-13 12:43 ` [PATCH v4 1/3] usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK Tejas Joglekar
2020-10-13 12:43 ` [PATCH v4 2/3] usb: xhci: Use temporary buffer to consolidate SG Tejas Joglekar
2020-10-13 14:57   ` kernel test robot
2020-10-13 12:44 ` [PATCH v4 3/3] usb: dwc3: Pass quirk as platform data Tejas Joglekar
2020-10-14  8:37   ` Sergei Shtylyov [this message]
2020-10-14 14:28     ` Tejas Joglekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29322e22-3b5b-037d-82ba-8e8ac28cd325@gmail.com \
    --to=sergei.shtylyov@gmail.com \
    --cc=John.Youn@synopsys.com \
    --cc=Tejas.Joglekar@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git