From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0EFCC2D0A3 for ; Thu, 29 Oct 2020 07:36:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD73F218AC for ; Thu, 29 Oct 2020 07:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729413AbgJ2Hgq (ORCPT ); Thu, 29 Oct 2020 03:36:46 -0400 Received: from aibo.runbox.com ([91.220.196.211]:36748 "EHLO aibo.runbox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729275AbgJ2Hfu (ORCPT ); Thu, 29 Oct 2020 03:35:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=JIqnWcDCMM2wCHeIge9wQlpKu0B7BGQ9QB0S6y9WG/I=; b=EDCb2IcCn21aQwUBPTQ4Q8rrOb RYF5GwXx3W65puiA1TPBC3Wng0kjpjAg66YZpmPbIGUWFCYd8z+FCftiYR67EEky4OHXV6Bf7L5X4 vHIb66GuRfh6nGwK+/QUcScF9nVt9U5/xbR3hVE4jgoqZEiXMBwlJNIP+PY5FoYAD/tkQvjo/qnmK lU7yV10ducDtL/tsC83ANXjs3RwUiIZZJofyMl14q7ExFSskaYoWMD0rjxoDq6nXo848JLDTCydi/ 1T3BVL+mKH12QR6kSFRMZcVKSNargWv3vyjGMKN1tHzVbM95k3c6kXXmLYFzw2GoXc3W6C5QPXmxV yXSh5jUg==; Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kXyh3-00042q-6d; Thu, 29 Oct 2020 04:33:41 +0100 Received: by submission02.runbox with esmtpsa [Authenticated alias (536975)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kXygy-0008JZ-0D; Thu, 29 Oct 2020 04:33:36 +0100 Subject: Re: [PATCH 1/2] usbcore: Check both id_table and match() when both available To: Pany , Bastien Nocera , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, Alan Stern References: <4cc0e162-c607-3fdf-30c9-1b3a77f6cf20@runbox.com> <20201022135521.375211-1-m.v.b@runbox.com> <20201022135521.375211-2-m.v.b@runbox.com> <4f367aba2f43b5e3807e0b01a5375e4a024ce765.camel@hadess.net> From: "M. Vefa Bicakci" Message-ID: <299d5037-f8d7-b71a-f7e7-3a52c06221d2@runbox.com> Date: Wed, 28 Oct 2020 23:33:32 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-CA Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 28/10/2020 00.00, Pany wrote: > On Tue, Oct 27, 2020 at 6:25 PM Bastien Nocera wrote: >> >> On Thu, 2020-10-22 at 09:55 -0400, M. Vefa Bicakci wrote: >>> From: Bastien Nocera >>> >>> From: Bastien Nocera >>> >>> When a USB device driver has both an id_table and a match() function, >>> make >>> sure to check both to find a match, first matching the id_table, then >>> checking the match() function. >>> >>> This makes it possible to have module autoloading done through the >>> id_table when devices are plugged in, before checking for further >>> device eligibility in the match() function. >>> >>> Signed-off-by: Bastien Nocera >>> Cc: # 5.8 >>> Cc: Greg Kroah-Hartman >>> Cc: Alan Stern >>> Co-developed-by: M. Vefa Bicakci >>> Signed-off-by: M. Vefa Bicakci >> >> You can also add my: >> Tested-by: Bastien Nocera >> > > This patch works well for me. > Tested-by: Pan (Pany) YUAN I realize that I am a bit late to do this, but I would like to thank Bastien and Pany for their efforts in testing (Bastien and Pany) and co-developing (Bastien) the patches. Thanks as well to Greg Kroah-Hartman for committing the patches to the usb-linus branch of the usb git tree and for fixing up the patch descriptions while doing so. Thanks everyone! Vefa