From: Oliver Neukum <oneukum@suse.com>
To: Rajat Jain <rajatja@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Andrew Lunn <andrew@lunn.ch>,
Chris Chiu <chris.chiu@canonical.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: levinale@google.com, bleung@google.com, rajatxjain@gmail.com,
jsbarnes@google.com, pmalani@google.com
Subject: Re: [PATCH 1/2] usb: hub: Mark root hubs on removable devices, as removable.
Date: Thu, 30 Sep 2021 10:02:00 +0200 [thread overview]
Message-ID: <2df726b3-e5c4-0fbb-991d-e31e74348d52@suse.com> (raw)
In-Reply-To: <20210929224823.556943-1-rajatja@google.com>
On 30.09.21 00:48, Rajat Jain wrote:
> Currently all usb root hubs are always marked as DEVICE_REMOVABLE_UNKNOWN
> unconditionally. Let us try to help the users to identify the removable
> root hubs, by checking the device on which the root hub sits. If the base
> (parent) device on which the root hub sits, is removable (e.g. on
> thunderbolt docks), then the roothub is also marked as removable.
>
> Signed-off-by: Rajat Jain <rajatja@google.com>
Hi,
frankly, why? You are needlessly throwing away information about where
in the tree
removal can happen. This looks like a worsening, not an improvement to me.
Regards
Oliver
next prev parent reply other threads:[~2021-09-30 8:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 22:48 [PATCH 1/2] usb: hub: Mark root hubs on removable devices, as removable Rajat Jain
2021-09-29 22:48 ` [PATCH 2/2] usb: hub: Mark devices downstream a removable hub, " Rajat Jain
2021-09-30 5:31 ` Greg Kroah-Hartman
2021-10-04 22:42 ` Rajat Jain
2021-10-05 14:56 ` Alan Stern
2021-10-05 16:51 ` Dmitry Torokhov
2021-10-05 19:59 ` Alan Stern
2021-10-05 23:43 ` Rajat Jain
2021-10-06 0:41 ` Andrew Lunn
2021-10-06 16:08 ` Alan Stern
2021-10-06 9:37 ` Oliver Neukum
2021-10-06 16:10 ` Alan Stern
2021-10-06 18:36 ` Oliver Neukum
2021-09-30 5:30 ` [PATCH 1/2] usb: hub: Mark root hubs on removable devices, " Greg Kroah-Hartman
2021-10-04 21:51 ` Rajat Jain
2021-09-30 8:02 ` Oliver Neukum [this message]
2021-10-04 21:56 ` Rajat Jain
2021-10-05 11:19 ` Greg Kroah-Hartman
2021-10-05 23:49 ` Rajat Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df726b3-e5c4-0fbb-991d-e31e74348d52@suse.com \
--to=oneukum@suse.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andrew@lunn.ch \
--cc=bleung@google.com \
--cc=chris.chiu@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=jsbarnes@google.com \
--cc=levinale@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=pmalani@google.com \
--cc=rajatja@google.com \
--cc=rajatxjain@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).