From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF738C4363A for ; Tue, 27 Oct 2020 21:54:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9349D20829 for ; Tue, 27 Oct 2020 21:54:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S374545AbgJ0Vy0 (ORCPT ); Tue, 27 Oct 2020 17:54:26 -0400 Received: from mailfilter05-out41.webhostingserver.nl ([141.138.168.206]:40756 "EHLO mailfilter05-out41.webhostingserver.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2506374AbgJ0VyZ (ORCPT ); Tue, 27 Oct 2020 17:54:25 -0400 X-Halon-ID: f8cdf5ff-189e-11eb-9ed4-001a4a4cb933 Received: from s198.webhostingserver.nl (s198.webhostingserver.nl [141.138.168.154]) by mailfilter05.webhostingserver.nl (Halon) with ESMTPSA id f8cdf5ff-189e-11eb-9ed4-001a4a4cb933; Tue, 27 Oct 2020 22:54:22 +0100 (CET) Received: from [2001:981:6fec:1:68dc:4ef6:3eb9:a9b9] by s198.webhostingserver.nl with esmtpa (Exim 4.92.3) (envelope-from ) id 1kXWv8-004NOn-6H; Tue, 27 Oct 2020 22:54:22 +0100 Subject: Re: BUG with linux 5.9.0 with dwc3 in gadget mode To: Andy Shevchenko Cc: "linux-usb@vger.kernel.org" , Thinh Nguyen , Felipe Balbi , Heikki Krogerus , Jack Pham References: <913dccca-500d-1938-b199-6eb67cfb60cc@gmail.com> <87a6wig461.fsf@kernel.org> <874kmpf583.fsf@kernel.org> <976cea12-e54e-fbca-6c53-e6ef5c554094@synopsys.com> <645b6ddc-d4f5-3f5b-b85f-b3d27fc365f5@synopsys.com> <2b6586e6-528c-86e8-9d92-0061bc44866d@gmail.com> <2cc783ac-6b71-190b-49fc-9e2bceeacd4b@gmail.com> <920590dc-5430-7f8b-b2e1-1a4c37f4dfbe@synopsys.com> <0089306e-e2ca-9a53-6ffb-202d028050ce@gmail.com> From: Ferry Toth Message-ID: <30ab00e4-53ae-fd9e-1689-c94078a31625@gmail.com> Date: Tue, 27 Oct 2020 22:54:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Antivirus-Scanner: Clean mail though you should still use an Antivirus Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, Op 27-10-2020 om 22:16 schreef Andy Shevchenko: > On Tue, Oct 27, 2020 at 10:13 PM Ferry Toth wrote: >> Op 22-10-2020 om 15:43 schreef Andy Shevchenko: >>> On Thu, Oct 22, 2020 at 4:21 PM Thinh Nguyen wrote: >>>> Ferry Toth wrote: > ... > >>>> There are some fixes to dwc3 in kernel mainline. Is it possible to test >>>> this against linux-next? >>> I think the best is to wait for v5.10-rc1 and retest. > Can you give a try of v5.10-rc1? Yes, I just tried: I booted in host mode, then flip the switch. Gadget come up, go down once, then come up again and stay up. I tested mass storage mounts, network works. Sound device is detected by the host, I didn't actually try to play a sound. So, big improvement, thanks! >> I looks like there have been at least 3 problems: >> >> 1) dwc3 was not working in host mode, but not causing an oops. This may >> have been caused by platform changes. Andy has provided a fix for this, >> dwc3 now working in host mode on 5.9 > Rafael took the above mentioned change(s) for v5.10-rcX. > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=99aed9227073fb34ce2880cbc7063e04185a65e1 > >> 2) dwc3 was causing the oops in gadget mode as referenced in this >> thread. The experimental patch from Jack Phan indeed fixes this. >> >> Code here: https://github.com/edison-fw/linux/commits/eds-acpi-5.9.0 >> >> 3) With the above 2 fixes gadgets work but seem to be powered down >> (after 15 sec. or so) and up (after 1 sec.) continuously. No oops, no >> errors in journal. The gadgets I enabled are a network, sound and mass >> storage. The latter stops working due to going up/down quickly. But my >> host shows network/sound appearing/disappearing. Journal of edison shows: >> >> systemd-networkd[525]: usb0: Gained carrier >> systemd-networkd[525]: usb0: Gained IPv6LL >> systemd-networkd[525]: usb0: Lost carrier >> systemd-networkd[525]: usb0: Gained carrier >> systemd-networkd[525]: usb0: Gained IPv6LL >> systemd-networkd[525]: usb0: Lost carrier >> >> Any ideas how to proceed are highly welcomed!