From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Steve Glendinning <steve.glendinning@shawell.net>,
UNGLinuxDriver@microchip.com,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Martyn Welch <martyn.welch@collabora.com>,
Markus Reichl <m.reichl@fivetechno.de>
Cc: Markus Reichl <m.reichl@fivetechno.de>,
Gabriel Hojda <ghojda@yo2urs.ro>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: usb: Correct reset handling of smsc95xx
Date: Fri, 14 Jan 2022 10:46:38 +0100 [thread overview]
Message-ID: <3127264.ElGaqSPkdT@steina-w> (raw)
In-Reply-To: <20220113200113.30702-1-m.reichl@fivetechno.de>
Hi Markus,
Am Donnerstag, 13. Januar 2022, 21:01:11 CET schrieb Markus Reichl:
> On boards with LAN9514 and no preconfigured MAC address we don't get an
> ip address from DHCP after commit a049a30fc27c ("net: usb: Correct PHY
> handling of smsc95xx") anymore. Adding an explicit reset before starting
> the phy fixes the issue.
>
> [1]
> https://lore.kernel.org/netdev/199eebbd6b97f52b9119c9fa4fd8504f8a34de18.came
> l@collabora.com/
>
> From: Gabriel Hojda <ghojda@yo2urs.ro>
> Fixes: a049a30fc27c ("net: usb: Correct PHY handling of smsc95xx")
> Signed-off-by: Gabriel Hojda <ghojda@yo2urs.ro>
> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> ---
> drivers/net/usb/smsc95xx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> index abe0149ed917..bc1e3dd67c04 100644
> --- a/drivers/net/usb/smsc95xx.c
> +++ b/drivers/net/usb/smsc95xx.c
> @@ -1962,7 +1962,8 @@ static const struct driver_info smsc95xx_info = {
> .bind = smsc95xx_bind,
> .unbind = smsc95xx_unbind,
> .link_reset = smsc95xx_link_reset,
> - .reset = smsc95xx_start_phy,
> + .reset = smsc95xx_reset,
> + .check_connect = smsc95xx_start_phy,
> .stop = smsc95xx_stop,
> .rx_fixup = smsc95xx_rx_fixup,
> .tx_fixup = smsc95xx_tx_fixup,
Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
This should go into stable-5.15!
Tested on a TQMa6x on MBa6 which uses a SMSC9500 as a second ethernet
interface.
For the record: I noticed the problem as ARP replies were sent from the wrong
interface. Thus my PC got the wrong MAC address which failed ping in the end.
Best regards,
Alexander
next prev parent reply other threads:[~2022-01-14 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 20:01 [PATCH] net: usb: Correct reset handling of smsc95xx Markus Reichl
2022-01-14 9:46 ` Alexander Stein [this message]
2022-01-14 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3127264.ElGaqSPkdT@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=ghojda@yo2urs.ro \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.reichl@fivetechno.de \
--cc=martyn.welch@collabora.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).