From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E92DCC433DF for ; Wed, 13 May 2020 16:31:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 333C62054F for ; Wed, 13 May 2020 16:31:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HwKVvG3+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389532AbgEMQbT (ORCPT ); Wed, 13 May 2020 12:31:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730731AbgEMQbT (ORCPT ); Wed, 13 May 2020 12:31:19 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1F50C061A0C; Wed, 13 May 2020 09:31:18 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id e26so27220011wmk.5; Wed, 13 May 2020 09:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+4cqElCbVxVOwsktnpwvTscv6syAeTYzIlwIp1I4PR8=; b=HwKVvG3+V3nsUoA+C514RXa2JsMkBVV+ttmcu6z/zmaS8k/hInNpN0MbECn+/Pq+2m 9GoTQpNxgyngx8xtHqS7OuI5K++LOxzs4Ieekl8mxzr39UvtzqYTmJevDshQkj+BS8m2 BXV/8MylquPzUtZmLiAK913crp4WNO7rQGXG0x3HeLTkEwMPvtTnMVNmaxkahxrT+79Y YY0EsE9Hnh++HrgjQavBBOLKHEOv080zBx8w3odf5SwJc0SvgnQgp7uT0ijo3BzwwDHP cl09rPOtZffqIRGduDV1TEzJnQ4NLM+XfoXY0zTjK5kayPiYYYYJqKONEmNyKc1VhhXr Ho9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=+4cqElCbVxVOwsktnpwvTscv6syAeTYzIlwIp1I4PR8=; b=uUlNtfsiUa22EBO2T6qP8f/yCOz2x0Bg0+fWTSXJtU7fAmyO0LSgvjlA0693n1k38a gHtHDGjgs9aXhv0QZw5Mvu9Ao4RuEmkCBjFj0MKeWXsp7CLr2vZCXUxDAIA66hg2jSdb 4KHmgsRreDXIobE/H2WpkCwlQkhwv8XdxfRFGHxm21r1++OM0NnR2JL8xeU8nq5cunSo 8n9gjl+vk1XwfG059xqmz0PaCpzIaIhJL5Cf1c5RKLbKLoQy16m+PGtOTEqhpXInCTZg v46Zc/Tm5SVQEVvvWwTvMggFbeQVlCw2ITWByDuGS5yRBlz8WXArWufWmIaek4dgYTcy 2S4g== X-Gm-Message-State: AGi0PuaeTsEeY+HnW0+J9efoQ9KXtralwaQpeeArW/fupkUpBTFBap/W ZnEqtEBOfIi3Vp5/uJjDAlY= X-Google-Smtp-Source: APiQypLhkUtP3/abzvwn3X1UsA7n1FZdHriqQn7pqyM4c+FU86i60PeM1G0eKzL7R6d+LsTInxKmUQ== X-Received: by 2002:a7b:c5c7:: with SMTP id n7mr33693122wmk.18.1589387477428; Wed, 13 May 2020 09:31:17 -0700 (PDT) Received: from [10.230.188.43] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 18sm23593119wmj.19.2020.05.13.09.31.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2020 09:31:16 -0700 (PDT) Subject: Re: [PATCH v10 1/5] usb: xhci: Change the XHCI link order in the Makefile To: Greg Kroah-Hartman Cc: Al Cooper , linux-kernel@vger.kernel.org, Alan Stern , Andy Shevchenko , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-usb@vger.kernel.org, Mathias Nyman , Rob Herring , Yoshihiro Shimoda , Andy Shevchenko References: <20200512150019.25903-1-alcooperx@gmail.com> <20200512150019.25903-2-alcooperx@gmail.com> <20200513122613.GA1023594@kroah.com> <7acc2a4c-caab-11e7-7b3f-4176f19c58cf@gmail.com> <20200513162723.GF1362525@kroah.com> From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= mQENBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAG0MEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPokB xAQQAQgArgUCXnQoOxcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFrZXktdXNh Z2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2RpbmdAcGdw LmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29tLmNvbQUb AwAAAAMWAgEFHgEAAAAEFQgJCgAKCRCBMbXEKbxmoHaNB/4p5GXw2Xlk4r2J0MsUAZE4Gnfc C4DtilufOGVR1K0/WhROYemyCAP+xuBj8bnQDBtZwB5ED37q4/p8DSmCnkEBjM5Cz12EZQzs utQgCV1UIgzryoiDZSF2XLslzF9LOSaOiNzpBvwEYNTZ+koEW+AOHEAgS6SbV2Hob8Zc32xF oQdKGwbSwcV8hS2YLL37VxKr2h8ZTtuTmhDNqxuKPzZuoAL61/4i8+BTyVZC4gUL/EUu7pG2 rbwhg/s8TyQWWeBz18Xiw5K148TXT0LeErmTsJSPQFMqZ6AR/nuJDQzhIUiLeq/hvBs1BIQf REqNMShEnnMJfHjd8RFnGpdPk+hKuQENBFPAG8EBCACsa+9aKnvtPjGAnO1mn1hHKUBxVML2 C3HQaDp5iT8Q8A0ab1OS4akj75P8iXYfZOMVA0Lt65taiFtiPT7pOZ/yc/5WbKhsPE9dwysr vHjHL2gP4q5vZV/RJduwzx8v9KrMZsVZlKbvcvUvgZmjG9gjPSLssTFhJfa7lhUtowFof0fA q3Zy+vsy5OtEe1xs5kiahdPb2DZSegXW7DFg15GFlj+VG9WSRjSUOKk+4PCDdKl8cy0LJs+r W4CzBB2ARsfNGwRfAJHU4Xeki4a3gje1ISEf+TVxqqLQGWqNsZQ6SS7jjELaB/VlTbrsUEGR 1XfIn/sqeskSeQwJiFLeQgj3ABEBAAGJAkEEGAECASsFAlPAG8IFGwwAAADAXSAEGQEIAAYF AlPAG8EACgkQk2AGqJgvD1UNFQgAlpN5/qGxQARKeUYOkL7KYvZFl3MAnH2VeNTiGFoVzKHO e7LIwmp3eZ6GYvGyoNG8cOKrIPvXDYGdzzfwxVnDSnAE92dv+H05yanSUv/2HBIZa/LhrPmV hXKgD27XhQjOHRg0a7qOvSKx38skBsderAnBZazfLw9OukSnrxXqW/5pe3mBHTeUkQC8hHUD Cngkn95nnLXaBAhKnRfzFqX1iGENYRH3Zgtis7ZvodzZLfWUC6nN8LDyWZmw/U9HPUaYX8qY MP0n039vwh6GFZCqsFCMyOfYrZeS83vkecAwcoVh8dlHdke0rnZk/VytXtMe1u2uc9dUOr68 7hA+Z0L5IQAKCRCBMbXEKbxmoLoHCACXeRGHuijOmOkbyOk7x6fkIG1OXcb46kokr2ptDLN0 Ky4nQrWp7XBk9ls/9j5W2apKCcTEHONK2312uMUEryWI9BlqWnawyVL1LtyxLLpwwsXVq5m5 sBkSqma2ldqBu2BHXZg6jntF5vzcXkqG3DCJZ2hOldFPH+czRwe2OOsiY42E/w7NUyaN6b8H rw1j77+q3QXldOw/bON361EusWHdbhcRwu3WWFiY2ZslH+Xr69VtYAoMC1xtDxIvZ96ps9ZX pUPJUqHJr8QSrTG1/zioQH7j/4iMJ07MMPeQNkmj4kGQOdTcsFfDhYLDdCE5dj5WeE6fYRxE Q3up0ArDSP1L Message-ID: <38ff034d-a84c-2309-a8d5-f344930d9a31@gmail.com> Date: Wed, 13 May 2020 09:31:11 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200513162723.GF1362525@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 5/13/2020 9:27 AM, Greg Kroah-Hartman wrote: > On Wed, May 13, 2020 at 08:08:07AM -0700, Florian Fainelli wrote: >> >> >> On 5/13/2020 5:26 AM, Greg Kroah-Hartman wrote: >>> On Tue, May 12, 2020 at 11:00:15AM -0400, Al Cooper wrote: >>>> Some BRCMSTB USB chips have an XHCI, EHCI and OHCI controller >>>> on the same port where XHCI handles 3.0 devices, EHCI handles 2.0 >>>> devices and OHCI handles <2.0 devices. Currently the Makefile >>>> has XHCI linking at the bottom which will result in the XHIC driver >>>> initalizing after the EHCI and OHCI drivers and any installed 3.0 >>>> device will be seen as a 2.0 device. Moving the XHCI linking >>>> above the EHCI and OHCI linking fixes the issue. >>> >>> What happens if all of these are modules and they are loaded in a >>> different order? This makefile change will not help with that, you need >>> to have logic in the code in order to properly coordinate this type of >>> mess, sorry. >> >> I believe we should be using module soft dependencies to instruct the >> module loaders to load the modules in the correct order, so something >> like this would do (not tested) for xhci-plat-hcd.c: >> >> MODULE_SOFTDEP("post: ehci-hcd ohci-hcd"); >> >> and I am not sure whether we need to add the opposite for ehci-hcd and >> ohci-hcd: >> >> MODULE_SOFTDEP("pre: xhci-plat-hcd"); > > That's a nice start, but what happens if that isn't honored? This > really needs to work properly for any order as you never can guarantee > module/driver loading order in a system of modules. I also suggested that device links may help, though I am not sure. What do you suggest to be done? -- Florian