Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Alexandre Torgue <alexandre.torgue@st.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Kishon Vijay Abraham I <kishon@ti.com>
Cc: youling 257 <youling257@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	USB <linux-usb@vger.kernel.org>, <saravanak@google.com>
Subject: Re: [PATCH] phy: core: Add consumer device link support
Date: Mon, 17 Feb 2020 09:35:45 +0100
Message-ID: <3afc9783-813c-ab61-b4f4-e925a32df947@st.com> (raw)
In-Reply-To: <CAHp75VcbPYNKfrnkuSfdN8t100kZFdq05hkbWxJKgRWJknRgxQ@mail.gmail.com>

Hi,

On 2/14/20 7:46 PM, Andy Shevchenko wrote:
> On Mon, Feb 10, 2020 at 1:32 PM Alexandre Torgue
> <alexandre.torgue@st.com> wrote:
>> On 2/10/20 9:08 AM, Kishon Vijay Abraham I wrote:
>>> On 07/02/20 12:27 PM, youling 257 wrote:
>>>> test this diff, dwc3 work for my device, thanks.
>>>>
>>>> 2020-02-07 13:16 GMT+08:00, Kishon Vijay Abraham I <kishon@ti.com>:
>>>>> On 06/02/20 7:09 PM, youling257 wrote:
>>>>>> This patch cause "dwc3 dwc3.3.auto: failed to create device link to
>>>>>> dwc3.3.auto.ulpi" problem.
>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=206435
> 
> +1 to the report.
> Please revert for v5.6 or provide a fix ASAP!
> 

Kishon, do you plan to do the fix? If not, I'll send it quickly.

Thanks
Alex

>>>>>
>>>>> I'm suspecting there is some sort of reverse dependency with dwc3 ULPI.
>>>>> Can you try the following diff?
>>>>>
>>>>> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
>>>>> index 2eb28cc2d2dc..397311dcb116 100644
>>>>> --- a/drivers/phy/phy-core.c
>>>>> +++ b/drivers/phy/phy-core.c
>>>>> @@ -687,7 +687,7 @@ struct phy *phy_get(struct device *dev, const char
>>>>> *string)
>>>>>
>>>>>           get_device(&phy->dev);
>>>>>
>>>>> -       link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
>>>>> +       link = device_link_add(dev, &phy->dev, DL_FLAG_SYNC_STATE_ONLY);
>>>>>           if (!link) {
>>>>>                   dev_err(dev, "failed to create device link to %s\n",
>>>>>                           dev_name(phy->dev.parent));
>>>>> @@ -802,7 +802,7 @@ struct phy *devm_of_phy_get(struct device *dev,
>>>>> struct device_node *np,
>>>>>                   return phy;
>>>>>           }
>>>>>
>>>>> -       link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
>>>>> +       link = device_link_add(dev, &phy->dev, DL_FLAG_SYNC_STATE_ONLY);
>>>>>           if (!link) {
>>>>>                   dev_err(dev, "failed to create device link to %s\n",
>>>>>                           dev_name(phy->dev.parent));
>>>>> @@ -851,7 +851,7 @@ struct phy *devm_of_phy_get_by_index(struct device
>>>>> *dev, struct device_node *np,
>>>>>           *ptr = phy;
>>>>>           devres_add(dev, ptr);
>>>>>
>>>>> -       link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
>>>>> +       link = device_link_add(dev, &phy->dev, DL_FLAG_SYNC_STATE_ONLY);
>>>>>           if (!link) {
>>>>>                   dev_err(dev, "failed to create device link to %s\n",
>>>>>                           dev_name(phy->dev.parent));Parent
>>>
>>> Can you check if this doesn't affect the suspend/resume ordering?
>>
>> With this fix, suspend/resume ordering is broken on my side. What do you
>> think to keep the STATELESS flag and to only display a warn if
>> "device_link_add" returns an error ? It's not "smart" but it could
>> solved our issue.
>>
>> As a lot of improvements have been recently done on device link topic by
>> Saravana, we could check with him what is the way to follow.
>>
>> Regards
>> Alex
>>
>>>
>>> Thanks
>>> Kishon
>>>
> 
> 
> 

  reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 14:37 Alexandre Torgue
2019-12-04 15:33 ` Alexandre Torgue
2019-12-04 17:19   ` Greg Kroah-Hartman
2020-01-07 11:51 ` Jon Hunter
2020-01-08  7:29   ` Kishon Vijay Abraham I
2020-01-08  8:37     ` Alexandre Torgue
2020-02-06 13:39 ` youling257
2020-02-07  5:16   ` Kishon Vijay Abraham I
2020-02-07  6:57     ` youling 257
2020-02-10  8:08       ` Kishon Vijay Abraham I
2020-02-10 11:30         ` Alexandre Torgue
2020-02-10 12:18           ` Kishon Vijay Abraham I
2020-02-11  6:17             ` Saravana Kannan
2020-02-14 18:46           ` Andy Shevchenko
2020-02-17  8:35             ` Alexandre Torgue [this message]
2020-02-17  8:40               ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3afc9783-813c-ab61-b4f4-e925a32df947@st.com \
    --to=alexandre.torgue@st.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=saravanak@google.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    --cc=youling257@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git