Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
@ 2020-10-12  8:00 Heiner Kallweit
  2020-10-12  8:01 ` [PATCH net-next v2 01/12] net: add " Heiner Kallweit
                   ` (12 more replies)
  0 siblings, 13 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:00 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

In several places the same code is used to populate rtnl_link_stats64
fields with data from pcpu_sw_netstats. Therefore factor out this code
to a new function dev_fetch_sw_netstats().

v2:
- constify argument netstats
- don't ignore netstats being NULL or an ERRPTR
- switch to EXPORT_SYMBOL_GPL

Heiner Kallweit (12):
  net: core: add function dev_fetch_sw_netstats for fetching
    pcpu_sw_netstats
  IB/hfi1: use new function dev_fetch_sw_netstats
  net: macsec: use new function dev_fetch_sw_netstats
  net: usb: qmi_wwan: use new function dev_fetch_sw_netstats
  net: usbnet: use new function dev_fetch_sw_netstats
  qtnfmac: use new function dev_fetch_sw_netstats
  net: bridge: use new function dev_fetch_sw_netstats
  net: dsa: use new function dev_fetch_sw_netstats
  iptunnel: use new function dev_fetch_sw_netstats
  mac80211: use new function dev_fetch_sw_netstats
  net: openvswitch: use new function dev_fetch_sw_netstats
  xfrm: use new function dev_fetch_sw_netstats

 drivers/infiniband/hw/hfi1/ipoib_main.c       | 34 +------------------
 drivers/net/macsec.c                          | 22 +-----------
 drivers/net/usb/qmi_wwan.c                    | 24 +------------
 drivers/net/usb/usbnet.c                      | 24 +------------
 drivers/net/wireless/quantenna/qtnfmac/core.c | 27 +--------------
 include/linux/netdevice.h                     |  2 ++
 net/bridge/br_device.c                        | 21 +-----------
 net/core/dev.c                                | 34 +++++++++++++++++++
 net/dsa/slave.c                               | 21 +-----------
 net/ipv4/ip_tunnel_core.c                     | 23 +------------
 net/mac80211/iface.c                          | 23 +------------
 net/openvswitch/vport-internal_dev.c          | 20 +----------
 net/xfrm/xfrm_interface.c                     | 22 +-----------
 13 files changed, 47 insertions(+), 250 deletions(-)

-- 
2.28.0




^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH net-next v2 01/12] net: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
@ 2020-10-12  8:01 ` Heiner Kallweit
  2020-10-12  8:03 ` [PATCH net-next v2 02/12] IB/hfi1: use new function dev_fetch_sw_netstats Heiner Kallweit
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:01 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

In several places the same code is used to populate rtnl_link_stats64
fields with data from pcpu_sw_netstats. Therefore factor out this code
to a new function dev_fetch_sw_netstats().

v2:
- constify argument netstats
- don't ignore netstats being NULL or an ERRPTR
- switch to EXPORT_SYMBOL_GPL

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 include/linux/netdevice.h |  2 ++
 net/core/dev.c            | 34 ++++++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index a0df43b13..fa1d8d624 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -4495,6 +4495,8 @@ struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
 					struct rtnl_link_stats64 *storage);
 void netdev_stats_to_stats64(struct rtnl_link_stats64 *stats64,
 			     const struct net_device_stats *netdev_stats);
+void dev_fetch_sw_netstats(struct rtnl_link_stats64 *s,
+			   const struct pcpu_sw_netstats __percpu *netstats);
 
 extern int		netdev_max_backlog;
 extern int		netdev_tstamp_prequeue;
diff --git a/net/core/dev.c b/net/core/dev.c
index a146bac84..26bc10dec 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -10319,6 +10319,40 @@ struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
 }
 EXPORT_SYMBOL(dev_get_stats);
 
+/**
+ *	dev_fetch_sw_netstats - get per-cpu network device statistics
+ *	@s: place to store stats
+ *	@netstats: per-cpu network stats to read from
+ *
+ *	Read per-cpu network statistics and populate the related fields in @s.
+ */
+void dev_fetch_sw_netstats(struct rtnl_link_stats64 *s,
+			   const struct pcpu_sw_netstats __percpu *netstats)
+{
+	int cpu;
+
+	for_each_possible_cpu(cpu) {
+		const struct pcpu_sw_netstats *stats;
+		struct pcpu_sw_netstats tmp;
+		unsigned int start;
+
+		stats = per_cpu_ptr(netstats, cpu);
+		do {
+			start = u64_stats_fetch_begin_irq(&stats->syncp);
+			tmp.rx_packets = stats->rx_packets;
+			tmp.rx_bytes   = stats->rx_bytes;
+			tmp.tx_packets = stats->tx_packets;
+			tmp.tx_bytes   = stats->tx_bytes;
+		} while (u64_stats_fetch_retry_irq(&stats->syncp, start));
+
+		s->rx_packets += tmp.rx_packets;
+		s->rx_bytes   += tmp.rx_bytes;
+		s->tx_packets += tmp.tx_packets;
+		s->tx_bytes   += tmp.tx_bytes;
+	}
+}
+EXPORT_SYMBOL_GPL(dev_fetch_sw_netstats);
+
 struct netdev_queue *dev_ingress_queue_create(struct net_device *dev)
 {
 	struct netdev_queue *queue = dev_ingress_queue(dev);
-- 
2.28.0



^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH net-next v2 02/12] IB/hfi1: use new function dev_fetch_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
  2020-10-12  8:01 ` [PATCH net-next v2 01/12] net: add " Heiner Kallweit
@ 2020-10-12  8:03 ` Heiner Kallweit
  2020-10-12  8:04 ` [PATCH net-next v2 03/12] net: macsec: " Heiner Kallweit
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:03 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

Simplify the code by using new function dev_fetch_sw_netstats().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/infiniband/hw/hfi1/ipoib_main.c | 34 +------------------------
 1 file changed, 1 insertion(+), 33 deletions(-)

diff --git a/drivers/infiniband/hw/hfi1/ipoib_main.c b/drivers/infiniband/hw/hfi1/ipoib_main.c
index 014351ebb..9f71b9d70 100644
--- a/drivers/infiniband/hw/hfi1/ipoib_main.c
+++ b/drivers/infiniband/hw/hfi1/ipoib_main.c
@@ -97,41 +97,9 @@ static void hfi1_ipoib_dev_get_stats64(struct net_device *dev,
 				       struct rtnl_link_stats64 *storage)
 {
 	struct hfi1_ipoib_dev_priv *priv = hfi1_ipoib_priv(dev);
-	u64 rx_packets = 0ull;
-	u64 rx_bytes = 0ull;
-	u64 tx_packets = 0ull;
-	u64 tx_bytes = 0ull;
-	int i;
 
 	netdev_stats_to_stats64(storage, &dev->stats);
-
-	for_each_possible_cpu(i) {
-		const struct pcpu_sw_netstats *stats;
-		unsigned int start;
-		u64 trx_packets;
-		u64 trx_bytes;
-		u64 ttx_packets;
-		u64 ttx_bytes;
-
-		stats = per_cpu_ptr(priv->netstats, i);
-		do {
-			start = u64_stats_fetch_begin_irq(&stats->syncp);
-			trx_packets = stats->rx_packets;
-			trx_bytes = stats->rx_bytes;
-			ttx_packets = stats->tx_packets;
-			ttx_bytes = stats->tx_bytes;
-		} while (u64_stats_fetch_retry_irq(&stats->syncp, start));
-
-		rx_packets += trx_packets;
-		rx_bytes += trx_bytes;
-		tx_packets += ttx_packets;
-		tx_bytes += ttx_bytes;
-	}
-
-	storage->rx_packets += rx_packets;
-	storage->rx_bytes += rx_bytes;
-	storage->tx_packets += tx_packets;
-	storage->tx_bytes += tx_bytes;
+	dev_fetch_sw_netstats(storage, priv->netstats);
 }
 
 static const struct net_device_ops hfi1_ipoib_netdev_ops = {
-- 
2.28.0



^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH net-next v2 03/12] net: macsec: use new function dev_fetch_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
  2020-10-12  8:01 ` [PATCH net-next v2 01/12] net: add " Heiner Kallweit
  2020-10-12  8:03 ` [PATCH net-next v2 02/12] IB/hfi1: use new function dev_fetch_sw_netstats Heiner Kallweit
@ 2020-10-12  8:04 ` Heiner Kallweit
  2020-10-12  8:06 ` [PATCH net-next v2 04/12] net: usb: qmi_wwan: " Heiner Kallweit
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:04 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

Simplify the code by using new function dev_fetch_sw_netstats().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/macsec.c | 22 +---------------------
 1 file changed, 1 insertion(+), 21 deletions(-)

diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
index 2b0c8f01d..11ca5fa90 100644
--- a/drivers/net/macsec.c
+++ b/drivers/net/macsec.c
@@ -3647,30 +3647,10 @@ static int macsec_change_mtu(struct net_device *dev, int new_mtu)
 static void macsec_get_stats64(struct net_device *dev,
 			       struct rtnl_link_stats64 *s)
 {
-	int cpu;
-
 	if (!dev->tstats)
 		return;
 
-	for_each_possible_cpu(cpu) {
-		struct pcpu_sw_netstats *stats;
-		struct pcpu_sw_netstats tmp;
-		int start;
-
-		stats = per_cpu_ptr(dev->tstats, cpu);
-		do {
-			start = u64_stats_fetch_begin_irq(&stats->syncp);
-			tmp.rx_packets = stats->rx_packets;
-			tmp.rx_bytes   = stats->rx_bytes;
-			tmp.tx_packets = stats->tx_packets;
-			tmp.tx_bytes   = stats->tx_bytes;
-		} while (u64_stats_fetch_retry_irq(&stats->syncp, start));
-
-		s->rx_packets += tmp.rx_packets;
-		s->rx_bytes   += tmp.rx_bytes;
-		s->tx_packets += tmp.tx_packets;
-		s->tx_bytes   += tmp.tx_bytes;
-	}
+	dev_fetch_sw_netstats(s, dev->tstats);
 
 	s->rx_dropped = dev->stats.rx_dropped;
 	s->tx_dropped = dev->stats.tx_dropped;
-- 
2.28.0



^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH net-next v2 04/12] net: usb: qmi_wwan: use new function dev_fetch_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
                   ` (2 preceding siblings ...)
  2020-10-12  8:04 ` [PATCH net-next v2 03/12] net: macsec: " Heiner Kallweit
@ 2020-10-12  8:06 ` Heiner Kallweit
  2020-10-12  8:07 ` [PATCH net-next v2 05/12] net: usbnet: " Heiner Kallweit
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:06 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

Simplify the code by using new function dev_fetch_sw_netstats().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Bjørn Mork <bjorn@mork.no>
---
 drivers/net/usb/qmi_wwan.c | 24 +-----------------------
 1 file changed, 1 insertion(+), 23 deletions(-)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 5ca1356b8..a322f5187 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -126,31 +126,9 @@ static void qmimux_get_stats64(struct net_device *net,
 			       struct rtnl_link_stats64 *stats)
 {
 	struct qmimux_priv *priv = netdev_priv(net);
-	unsigned int start;
-	int cpu;
 
 	netdev_stats_to_stats64(stats, &net->stats);
-
-	for_each_possible_cpu(cpu) {
-		struct pcpu_sw_netstats *stats64;
-		u64 rx_packets, rx_bytes;
-		u64 tx_packets, tx_bytes;
-
-		stats64 = per_cpu_ptr(priv->stats64, cpu);
-
-		do {
-			start = u64_stats_fetch_begin_irq(&stats64->syncp);
-			rx_packets = stats64->rx_packets;
-			rx_bytes = stats64->rx_bytes;
-			tx_packets = stats64->tx_packets;
-			tx_bytes = stats64->tx_bytes;
-		} while (u64_stats_fetch_retry_irq(&stats64->syncp, start));
-
-		stats->rx_packets += rx_packets;
-		stats->rx_bytes += rx_bytes;
-		stats->tx_packets += tx_packets;
-		stats->tx_bytes += tx_bytes;
-	}
+	dev_fetch_sw_netstats(stats, priv->stats64);
 }
 
 static const struct net_device_ops qmimux_netdev_ops = {
-- 
2.28.0



^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH net-next v2 05/12] net: usbnet: use new function dev_fetch_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
                   ` (3 preceding siblings ...)
  2020-10-12  8:06 ` [PATCH net-next v2 04/12] net: usb: qmi_wwan: " Heiner Kallweit
@ 2020-10-12  8:07 ` Heiner Kallweit
  2020-10-12  8:14 ` [PATCH net-next v2 06/12] qtnfmac: " Heiner Kallweit
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:07 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

Simplify the code by using new function dev_fetch_sw_netstats().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/usb/usbnet.c | 24 +-----------------------
 1 file changed, 1 insertion(+), 23 deletions(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 963d260d1..6062dc278 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -983,31 +983,9 @@ EXPORT_SYMBOL_GPL(usbnet_set_link_ksettings);
 void usbnet_get_stats64(struct net_device *net, struct rtnl_link_stats64 *stats)
 {
 	struct usbnet *dev = netdev_priv(net);
-	unsigned int start;
-	int cpu;
 
 	netdev_stats_to_stats64(stats, &net->stats);
-
-	for_each_possible_cpu(cpu) {
-		struct pcpu_sw_netstats *stats64;
-		u64 rx_packets, rx_bytes;
-		u64 tx_packets, tx_bytes;
-
-		stats64 = per_cpu_ptr(dev->stats64, cpu);
-
-		do {
-			start = u64_stats_fetch_begin_irq(&stats64->syncp);
-			rx_packets = stats64->rx_packets;
-			rx_bytes = stats64->rx_bytes;
-			tx_packets = stats64->tx_packets;
-			tx_bytes = stats64->tx_bytes;
-		} while (u64_stats_fetch_retry_irq(&stats64->syncp, start));
-
-		stats->rx_packets += rx_packets;
-		stats->rx_bytes += rx_bytes;
-		stats->tx_packets += tx_packets;
-		stats->tx_bytes += tx_bytes;
-	}
+	dev_fetch_sw_netstats(stats, dev->stats64);
 }
 EXPORT_SYMBOL_GPL(usbnet_get_stats64);
 
-- 
2.28.0



^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH net-next v2 06/12] qtnfmac: use new function dev_fetch_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
                   ` (4 preceding siblings ...)
  2020-10-12  8:07 ` [PATCH net-next v2 05/12] net: usbnet: " Heiner Kallweit
@ 2020-10-12  8:14 ` Heiner Kallweit
  2020-10-12  8:15 ` [PATCH net-next v2 07/12] net: bridge: " Heiner Kallweit
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:14 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

Simplify the code by using new function dev_fetch_sw_netstats().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Kalle Valo <kvalo@codeaurora.org>
---
 drivers/net/wireless/quantenna/qtnfmac/core.c | 23 +------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/drivers/net/wireless/quantenna/qtnfmac/core.c b/drivers/net/wireless/quantenna/qtnfmac/core.c
index 374074dc7..bf6dbeb61 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/core.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/core.c
@@ -139,34 +139,13 @@ static void qtnf_netdev_get_stats64(struct net_device *ndev,
 				    struct rtnl_link_stats64 *stats)
 {
 	struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev);
-	unsigned int start;
-	int cpu;
 
 	netdev_stats_to_stats64(stats, &ndev->stats);
 
 	if (!vif->stats64)
 		return;
 
-	for_each_possible_cpu(cpu) {
-		struct pcpu_sw_netstats *stats64;
-		u64 rx_packets, rx_bytes;
-		u64 tx_packets, tx_bytes;
-
-		stats64 = per_cpu_ptr(vif->stats64, cpu);
-
-		do {
-			start = u64_stats_fetch_begin_irq(&stats64->syncp);
-			rx_packets = stats64->rx_packets;
-			rx_bytes = stats64->rx_bytes;
-			tx_packets = stats64->tx_packets;
-			tx_bytes = stats64->tx_bytes;
-		} while (u64_stats_fetch_retry_irq(&stats64->syncp, start));
-
-		stats->rx_packets += rx_packets;
-		stats->rx_bytes += rx_bytes;
-		stats->tx_packets += tx_packets;
-		stats->tx_bytes += tx_bytes;
-	}
+	dev_fetch_sw_netstats(stats, vif->stats64);
 }
 
 /* Netdev handler for transmission timeout.
-- 
2.28.0



^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH net-next v2 07/12] net: bridge: use new function dev_fetch_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
                   ` (5 preceding siblings ...)
  2020-10-12  8:14 ` [PATCH net-next v2 06/12] qtnfmac: " Heiner Kallweit
@ 2020-10-12  8:15 ` Heiner Kallweit
  2020-10-12  8:16 ` [PATCH net-next v2 08/12] net: dsa: " Heiner Kallweit
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:15 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

Simplify the code by using new function dev_fetch_sw_netstats().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 net/bridge/br_device.c | 21 +--------------------
 1 file changed, 1 insertion(+), 20 deletions(-)

diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
index 9a2fb4aa1..6f742fee8 100644
--- a/net/bridge/br_device.c
+++ b/net/bridge/br_device.c
@@ -206,27 +206,8 @@ static void br_get_stats64(struct net_device *dev,
 			   struct rtnl_link_stats64 *stats)
 {
 	struct net_bridge *br = netdev_priv(dev);
-	struct pcpu_sw_netstats tmp, sum = { 0 };
-	unsigned int cpu;
-
-	for_each_possible_cpu(cpu) {
-		unsigned int start;
-		const struct pcpu_sw_netstats *bstats
-			= per_cpu_ptr(br->stats, cpu);
-		do {
-			start = u64_stats_fetch_begin_irq(&bstats->syncp);
-			memcpy(&tmp, bstats, sizeof(tmp));
-		} while (u64_stats_fetch_retry_irq(&bstats->syncp, start));
-		sum.tx_bytes   += tmp.tx_bytes;
-		sum.tx_packets += tmp.tx_packets;
-		sum.rx_bytes   += tmp.rx_bytes;
-		sum.rx_packets += tmp.rx_packets;
-	}
 
-	stats->tx_bytes   = sum.tx_bytes;
-	stats->tx_packets = sum.tx_packets;
-	stats->rx_bytes   = sum.rx_bytes;
-	stats->rx_packets = sum.rx_packets;
+	dev_fetch_sw_netstats(stats, br->stats);
 }
 
 static int br_change_mtu(struct net_device *dev, int new_mtu)
-- 
2.28.0



^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH net-next v2 08/12] net: dsa: use new function dev_fetch_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
                   ` (6 preceding siblings ...)
  2020-10-12  8:15 ` [PATCH net-next v2 07/12] net: bridge: " Heiner Kallweit
@ 2020-10-12  8:16 ` Heiner Kallweit
  2020-10-12  8:17 ` [PATCH net-next v2 09/12] iptunnel: " Heiner Kallweit
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:16 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

Simplify the code by using new function dev_fetch_sw_netstats().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Tested-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
 net/dsa/slave.c | 21 +--------------------
 1 file changed, 1 insertion(+), 20 deletions(-)

diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index e7c1d62fd..3bc5ca40c 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -1221,28 +1221,9 @@ static void dsa_slave_get_stats64(struct net_device *dev,
 				  struct rtnl_link_stats64 *stats)
 {
 	struct dsa_slave_priv *p = netdev_priv(dev);
-	struct pcpu_sw_netstats *s;
-	unsigned int start;
-	int i;
 
 	netdev_stats_to_stats64(stats, &dev->stats);
-	for_each_possible_cpu(i) {
-		u64 tx_packets, tx_bytes, rx_packets, rx_bytes;
-
-		s = per_cpu_ptr(p->stats64, i);
-		do {
-			start = u64_stats_fetch_begin_irq(&s->syncp);
-			tx_packets = s->tx_packets;
-			tx_bytes = s->tx_bytes;
-			rx_packets = s->rx_packets;
-			rx_bytes = s->rx_bytes;
-		} while (u64_stats_fetch_retry_irq(&s->syncp, start));
-
-		stats->tx_packets += tx_packets;
-		stats->tx_bytes += tx_bytes;
-		stats->rx_packets += rx_packets;
-		stats->rx_bytes += rx_bytes;
-	}
+	dev_fetch_sw_netstats(stats, p->stats64);
 }
 
 static int dsa_slave_get_rxnfc(struct net_device *dev,
-- 
2.28.0



^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH net-next v2 09/12] iptunnel: use new function dev_fetch_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
                   ` (7 preceding siblings ...)
  2020-10-12  8:16 ` [PATCH net-next v2 08/12] net: dsa: " Heiner Kallweit
@ 2020-10-12  8:17 ` Heiner Kallweit
  2020-10-12  8:18 ` [PATCH net-next v2 10/12] mac80211: " Heiner Kallweit
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:17 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

Simplify the code by using new function dev_fetch_sw_netstats().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 net/ipv4/ip_tunnel_core.c | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c
index b2ea1a8c5..25f1caf5a 100644
--- a/net/ipv4/ip_tunnel_core.c
+++ b/net/ipv4/ip_tunnel_core.c
@@ -433,29 +433,8 @@ EXPORT_SYMBOL(skb_tunnel_check_pmtu);
 void ip_tunnel_get_stats64(struct net_device *dev,
 			   struct rtnl_link_stats64 *tot)
 {
-	int i;
-
 	netdev_stats_to_stats64(tot, &dev->stats);
-
-	for_each_possible_cpu(i) {
-		const struct pcpu_sw_netstats *tstats =
-						   per_cpu_ptr(dev->tstats, i);
-		u64 rx_packets, rx_bytes, tx_packets, tx_bytes;
-		unsigned int start;
-
-		do {
-			start = u64_stats_fetch_begin_irq(&tstats->syncp);
-			rx_packets = tstats->rx_packets;
-			tx_packets = tstats->tx_packets;
-			rx_bytes = tstats->rx_bytes;
-			tx_bytes = tstats->tx_bytes;
-		} while (u64_stats_fetch_retry_irq(&tstats->syncp, start));
-
-		tot->rx_packets += rx_packets;
-		tot->tx_packets += tx_packets;
-		tot->rx_bytes   += rx_bytes;
-		tot->tx_bytes   += tx_bytes;
-	}
+	dev_fetch_sw_netstats(tot, dev->tstats);
 }
 EXPORT_SYMBOL_GPL(ip_tunnel_get_stats64);
 
-- 
2.28.0



^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH net-next v2 10/12] mac80211: use new function dev_fetch_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
                   ` (8 preceding siblings ...)
  2020-10-12  8:17 ` [PATCH net-next v2 09/12] iptunnel: " Heiner Kallweit
@ 2020-10-12  8:18 ` Heiner Kallweit
  2020-10-12  8:19 ` [PATCH net-next v2 11/12] net: openvswitch: " Heiner Kallweit
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:18 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

Simplify the code by using new function dev_fetch_sw_netstats().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 net/mac80211/iface.c | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 240862a74..1be775979 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -709,28 +709,7 @@ static u16 ieee80211_netdev_select_queue(struct net_device *dev,
 static void
 ieee80211_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
 {
-	int i;
-
-	for_each_possible_cpu(i) {
-		const struct pcpu_sw_netstats *tstats;
-		u64 rx_packets, rx_bytes, tx_packets, tx_bytes;
-		unsigned int start;
-
-		tstats = per_cpu_ptr(dev->tstats, i);
-
-		do {
-			start = u64_stats_fetch_begin_irq(&tstats->syncp);
-			rx_packets = tstats->rx_packets;
-			tx_packets = tstats->tx_packets;
-			rx_bytes = tstats->rx_bytes;
-			tx_bytes = tstats->tx_bytes;
-		} while (u64_stats_fetch_retry_irq(&tstats->syncp, start));
-
-		stats->rx_packets += rx_packets;
-		stats->tx_packets += tx_packets;
-		stats->rx_bytes   += rx_bytes;
-		stats->tx_bytes   += tx_bytes;
-	}
+	dev_fetch_sw_netstats(stats, dev->tstats);
 }
 
 static const struct net_device_ops ieee80211_dataif_ops = {
-- 
2.28.0



^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH net-next v2 11/12] net: openvswitch: use new function dev_fetch_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
                   ` (9 preceding siblings ...)
  2020-10-12  8:18 ` [PATCH net-next v2 10/12] mac80211: " Heiner Kallweit
@ 2020-10-12  8:19 ` Heiner Kallweit
  2020-10-12  8:19 ` [PATCH net-next v2 12/12] xfrm: " Heiner Kallweit
  2020-10-14  0:39 ` [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Jakub Kicinski
  12 siblings, 0 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:19 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

Simplify the code by using new function dev_fetch_sw_netstats().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 net/openvswitch/vport-internal_dev.c | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
index d8fe66eea..1e30d8df3 100644
--- a/net/openvswitch/vport-internal_dev.c
+++ b/net/openvswitch/vport-internal_dev.c
@@ -86,31 +86,13 @@ static void internal_dev_destructor(struct net_device *dev)
 static void
 internal_get_stats(struct net_device *dev, struct rtnl_link_stats64 *stats)
 {
-	int i;
-
 	memset(stats, 0, sizeof(*stats));
 	stats->rx_errors  = dev->stats.rx_errors;
 	stats->tx_errors  = dev->stats.tx_errors;
 	stats->tx_dropped = dev->stats.tx_dropped;
 	stats->rx_dropped = dev->stats.rx_dropped;
 
-	for_each_possible_cpu(i) {
-		const struct pcpu_sw_netstats *percpu_stats;
-		struct pcpu_sw_netstats local_stats;
-		unsigned int start;
-
-		percpu_stats = per_cpu_ptr(dev->tstats, i);
-
-		do {
-			start = u64_stats_fetch_begin_irq(&percpu_stats->syncp);
-			local_stats = *percpu_stats;
-		} while (u64_stats_fetch_retry_irq(&percpu_stats->syncp, start));
-
-		stats->rx_bytes         += local_stats.rx_bytes;
-		stats->rx_packets       += local_stats.rx_packets;
-		stats->tx_bytes         += local_stats.tx_bytes;
-		stats->tx_packets       += local_stats.tx_packets;
-	}
+	dev_fetch_sw_netstats(stats, dev->tstats);
 }
 
 static const struct net_device_ops internal_dev_netdev_ops = {
-- 
2.28.0



^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH net-next v2 12/12] xfrm: use new function dev_fetch_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
                   ` (10 preceding siblings ...)
  2020-10-12  8:19 ` [PATCH net-next v2 11/12] net: openvswitch: " Heiner Kallweit
@ 2020-10-12  8:19 ` Heiner Kallweit
  2020-10-14  0:39 ` [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Jakub Kicinski
  12 siblings, 0 replies; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-12  8:19 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu
  Cc: netdev, linux-rdma, Linux USB Mailing List, linux-wireless, bridge

Simplify the code by using new function dev_fetch_sw_netstats().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 net/xfrm/xfrm_interface.c | 22 +---------------------
 1 file changed, 1 insertion(+), 21 deletions(-)

diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
index 5b120936d..aa4cdcf69 100644
--- a/net/xfrm/xfrm_interface.c
+++ b/net/xfrm/xfrm_interface.c
@@ -541,27 +541,7 @@ static int xfrmi_update(struct xfrm_if *xi, struct xfrm_if_parms *p)
 static void xfrmi_get_stats64(struct net_device *dev,
 			       struct rtnl_link_stats64 *s)
 {
-	int cpu;
-
-	for_each_possible_cpu(cpu) {
-		struct pcpu_sw_netstats *stats;
-		struct pcpu_sw_netstats tmp;
-		int start;
-
-		stats = per_cpu_ptr(dev->tstats, cpu);
-		do {
-			start = u64_stats_fetch_begin_irq(&stats->syncp);
-			tmp.rx_packets = stats->rx_packets;
-			tmp.rx_bytes   = stats->rx_bytes;
-			tmp.tx_packets = stats->tx_packets;
-			tmp.tx_bytes   = stats->tx_bytes;
-		} while (u64_stats_fetch_retry_irq(&stats->syncp, start));
-
-		s->rx_packets += tmp.rx_packets;
-		s->rx_bytes   += tmp.rx_bytes;
-		s->tx_packets += tmp.tx_packets;
-		s->tx_bytes   += tmp.tx_bytes;
-	}
+	dev_fetch_sw_netstats(s, dev->tstats);
 
 	s->rx_dropped = dev->stats.rx_dropped;
 	s->tx_dropped = dev->stats.tx_dropped;
-- 
2.28.0



^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
  2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
                   ` (11 preceding siblings ...)
  2020-10-12  8:19 ` [PATCH net-next v2 12/12] xfrm: " Heiner Kallweit
@ 2020-10-14  0:39 ` Jakub Kicinski
  2020-10-14  5:42   ` Leon Romanovsky
  12 siblings, 1 reply; 20+ messages in thread
From: Jakub Kicinski @ 2020-10-14  0:39 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: David Miller, Bjørn Mork, Oliver Neukum, Igor Mitsyanko,
	Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu, netdev, linux-rdma,
	Linux USB Mailing List, linux-wireless, bridge

On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote:
> In several places the same code is used to populate rtnl_link_stats64
> fields with data from pcpu_sw_netstats. Therefore factor out this code
> to a new function dev_fetch_sw_netstats().
> 
> v2:
> - constify argument netstats
> - don't ignore netstats being NULL or an ERRPTR
> - switch to EXPORT_SYMBOL_GPL

Applied, thank you!

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
  2020-10-14  0:39 ` [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Jakub Kicinski
@ 2020-10-14  5:42   ` Leon Romanovsky
  2020-10-14  6:13     ` Heiner Kallweit
  0 siblings, 1 reply; 20+ messages in thread
From: Leon Romanovsky @ 2020-10-14  5:42 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: Heiner Kallweit, David Miller, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu, netdev, linux-rdma,
	Linux USB Mailing List, linux-wireless, bridge

On Tue, Oct 13, 2020 at 05:39:51PM -0700, Jakub Kicinski wrote:
> On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote:
> > In several places the same code is used to populate rtnl_link_stats64
> > fields with data from pcpu_sw_netstats. Therefore factor out this code
> > to a new function dev_fetch_sw_netstats().
> >
> > v2:
> > - constify argument netstats
> > - don't ignore netstats being NULL or an ERRPTR
> > - switch to EXPORT_SYMBOL_GPL
>
> Applied, thank you!

Jakub,

Is it possible to make sure that changelogs are not part of the commit
messages? We don't store previous revisions in the git repo, so it doesn't
give too much to anyone who is looking on git log later. The lore link
to the patch is more than enough.

44fa32f008ab ("net: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats")

Thanks

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
  2020-10-14  5:42   ` Leon Romanovsky
@ 2020-10-14  6:13     ` Heiner Kallweit
  2020-10-14  7:53       ` Leon Romanovsky
  0 siblings, 1 reply; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-14  6:13 UTC (permalink / raw)
  To: Leon Romanovsky, Jakub Kicinski, David Miller
  Cc: Bjørn Mork, Oliver Neukum, Igor Mitsyanko,
	Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu, netdev, linux-rdma,
	Linux USB Mailing List, linux-wireless, bridge

On 14.10.2020 07:42, Leon Romanovsky wrote:
> On Tue, Oct 13, 2020 at 05:39:51PM -0700, Jakub Kicinski wrote:
>> On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote:
>>> In several places the same code is used to populate rtnl_link_stats64
>>> fields with data from pcpu_sw_netstats. Therefore factor out this code
>>> to a new function dev_fetch_sw_netstats().
>>>
>>> v2:
>>> - constify argument netstats
>>> - don't ignore netstats being NULL or an ERRPTR
>>> - switch to EXPORT_SYMBOL_GPL
>>
>> Applied, thank you!
> 
> Jakub,
> 
> Is it possible to make sure that changelogs are not part of the commit
> messages? We don't store previous revisions in the git repo, so it doesn't
> give too much to anyone who is looking on git log later. The lore link
> to the patch is more than enough.
> 
I remember that once I did it the usual way (changelog below the ---) David
requested the changelog to be part of the commit message. So obviously he
sees some benefit in doing so. 

> 44fa32f008ab ("net: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats")
> 
> Thanks
> 


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
  2020-10-14  6:13     ` Heiner Kallweit
@ 2020-10-14  7:53       ` Leon Romanovsky
  2020-10-14  7:59         ` Heiner Kallweit
  0 siblings, 1 reply; 20+ messages in thread
From: Leon Romanovsky @ 2020-10-14  7:53 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: Jakub Kicinski, David Miller, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu, netdev, linux-rdma,
	Linux USB Mailing List, linux-wireless, bridge

On Wed, Oct 14, 2020 at 08:13:47AM +0200, Heiner Kallweit wrote:
> On 14.10.2020 07:42, Leon Romanovsky wrote:
> > On Tue, Oct 13, 2020 at 05:39:51PM -0700, Jakub Kicinski wrote:
> >> On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote:
> >>> In several places the same code is used to populate rtnl_link_stats64
> >>> fields with data from pcpu_sw_netstats. Therefore factor out this code
> >>> to a new function dev_fetch_sw_netstats().
> >>>
> >>> v2:
> >>> - constify argument netstats
> >>> - don't ignore netstats being NULL or an ERRPTR
> >>> - switch to EXPORT_SYMBOL_GPL
> >>
> >> Applied, thank you!
> >
> > Jakub,
> >
> > Is it possible to make sure that changelogs are not part of the commit
> > messages? We don't store previous revisions in the git repo, so it doesn't
> > give too much to anyone who is looking on git log later. The lore link
> > to the patch is more than enough.
> >
> I remember that once I did it the usual way (changelog below the ---) David
> requested the changelog to be part of the commit message. So obviously he
> sees some benefit in doing so.

Do you have a link? What is the benefit and how can we use it?

Usually such request comes to ensure that commit message is updated with
extra information (explanation) existed in changelog which is missing in
the patch.

Thanks

>
> > 44fa32f008ab ("net: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats")
> >
> > Thanks
> >
>

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
  2020-10-14  7:53       ` Leon Romanovsky
@ 2020-10-14  7:59         ` Heiner Kallweit
  2020-10-14  8:01           ` Johannes Berg
  0 siblings, 1 reply; 20+ messages in thread
From: Heiner Kallweit @ 2020-10-14  7:59 UTC (permalink / raw)
  To: Leon Romanovsky
  Cc: Jakub Kicinski, David Miller, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Johannes Berg, Pravin B Shelar,
	Steffen Klassert, Herbert Xu, netdev, linux-rdma,
	Linux USB Mailing List, linux-wireless, bridge

On 14.10.2020 09:53, Leon Romanovsky wrote:
> On Wed, Oct 14, 2020 at 08:13:47AM +0200, Heiner Kallweit wrote:
>> On 14.10.2020 07:42, Leon Romanovsky wrote:
>>> On Tue, Oct 13, 2020 at 05:39:51PM -0700, Jakub Kicinski wrote:
>>>> On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote:
>>>>> In several places the same code is used to populate rtnl_link_stats64
>>>>> fields with data from pcpu_sw_netstats. Therefore factor out this code
>>>>> to a new function dev_fetch_sw_netstats().
>>>>>
>>>>> v2:
>>>>> - constify argument netstats
>>>>> - don't ignore netstats being NULL or an ERRPTR
>>>>> - switch to EXPORT_SYMBOL_GPL
>>>>
>>>> Applied, thank you!
>>>
>>> Jakub,
>>>
>>> Is it possible to make sure that changelogs are not part of the commit
>>> messages? We don't store previous revisions in the git repo, so it doesn't
>>> give too much to anyone who is looking on git log later. The lore link
>>> to the patch is more than enough.
>>>
>> I remember that once I did it the usual way (changelog below the ---) David
>> requested the changelog to be part of the commit message. So obviously he
>> sees some benefit in doing so.
> 
> Do you have a link? What is the benefit and how can we use it?
> 
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1873080.html

> Usually such request comes to ensure that commit message is updated with
> extra information (explanation) existed in changelog which is missing in
> the patch.
> 
> Thanks
> 
>>
>>> 44fa32f008ab ("net: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats")
>>>
>>> Thanks
>>>
>>


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
  2020-10-14  7:59         ` Heiner Kallweit
@ 2020-10-14  8:01           ` Johannes Berg
  2020-10-14  8:33             ` Leon Romanovsky
  0 siblings, 1 reply; 20+ messages in thread
From: Johannes Berg @ 2020-10-14  8:01 UTC (permalink / raw)
  To: Heiner Kallweit, Leon Romanovsky
  Cc: Jakub Kicinski, David Miller, Bjørn Mork, Oliver Neukum,
	Igor Mitsyanko, Sergey Matyukevich, Kalle Valo, Roopa Prabhu,
	Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Pravin B Shelar, Steffen Klassert, Herbert Xu,
	netdev, linux-rdma, Linux USB Mailing List, linux-wireless,
	bridge

On Wed, 2020-10-14 at 09:59 +0200, Heiner Kallweit wrote:
> 
> > Do you have a link? What is the benefit and how can we use it?
> > 
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1873080.html

There was also a long discussion a year or so back, starting at

http://lore.kernel.org/r/7b73e1b7-cc34-982d-2a9c-acf62b88da16@linuxfoundation.org

johannes


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
  2020-10-14  8:01           ` Johannes Berg
@ 2020-10-14  8:33             ` Leon Romanovsky
  0 siblings, 0 replies; 20+ messages in thread
From: Leon Romanovsky @ 2020-10-14  8:33 UTC (permalink / raw)
  To: Johannes Berg
  Cc: Heiner Kallweit, Jakub Kicinski, David Miller, Bjørn Mork,
	Oliver Neukum, Igor Mitsyanko, Sergey Matyukevich, Kalle Valo,
	Roopa Prabhu, Nikolay Aleksandrov, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, Alexey Kuznetsov,
	Hideaki YOSHIFUJI, Pravin B Shelar, Steffen Klassert, Herbert Xu,
	netdev, linux-rdma, Linux USB Mailing List, linux-wireless,
	bridge

On Wed, Oct 14, 2020 at 10:01:20AM +0200, Johannes Berg wrote:
> On Wed, 2020-10-14 at 09:59 +0200, Heiner Kallweit wrote:
> >
> > > Do you have a link? What is the benefit and how can we use it?
> > >
> > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1873080.html

So why is it usable?
The combination of Link, b4 and git range-diff gives everything in much
more reliable way.

>
> There was also a long discussion a year or so back, starting at
>
> http://lore.kernel.org/r/7b73e1b7-cc34-982d-2a9c-acf62b88da16@linuxfoundation.org

I participated in that discussion too :)

Thanks

>
> johannes
>

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, back to index

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12  8:00 [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Heiner Kallweit
2020-10-12  8:01 ` [PATCH net-next v2 01/12] net: add " Heiner Kallweit
2020-10-12  8:03 ` [PATCH net-next v2 02/12] IB/hfi1: use new function dev_fetch_sw_netstats Heiner Kallweit
2020-10-12  8:04 ` [PATCH net-next v2 03/12] net: macsec: " Heiner Kallweit
2020-10-12  8:06 ` [PATCH net-next v2 04/12] net: usb: qmi_wwan: " Heiner Kallweit
2020-10-12  8:07 ` [PATCH net-next v2 05/12] net: usbnet: " Heiner Kallweit
2020-10-12  8:14 ` [PATCH net-next v2 06/12] qtnfmac: " Heiner Kallweit
2020-10-12  8:15 ` [PATCH net-next v2 07/12] net: bridge: " Heiner Kallweit
2020-10-12  8:16 ` [PATCH net-next v2 08/12] net: dsa: " Heiner Kallweit
2020-10-12  8:17 ` [PATCH net-next v2 09/12] iptunnel: " Heiner Kallweit
2020-10-12  8:18 ` [PATCH net-next v2 10/12] mac80211: " Heiner Kallweit
2020-10-12  8:19 ` [PATCH net-next v2 11/12] net: openvswitch: " Heiner Kallweit
2020-10-12  8:19 ` [PATCH net-next v2 12/12] xfrm: " Heiner Kallweit
2020-10-14  0:39 ` [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Jakub Kicinski
2020-10-14  5:42   ` Leon Romanovsky
2020-10-14  6:13     ` Heiner Kallweit
2020-10-14  7:53       ` Leon Romanovsky
2020-10-14  7:59         ` Heiner Kallweit
2020-10-14  8:01           ` Johannes Berg
2020-10-14  8:33             ` Leon Romanovsky

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git