Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] add Cellient MPL200 card
@ 2020-10-03  9:39 Wilken Gottwalt
  2020-10-03  9:39 ` [PATCH 1/2] usb: serial: qmi_wwan: " Wilken Gottwalt
  2020-10-03  9:40 ` [PATCH 2/2] usb: serial: option: " Wilken Gottwalt
  0 siblings, 2 replies; 17+ messages in thread
From: Wilken Gottwalt @ 2020-10-03  9:39 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjørn Mork, David S. Miller, Jakub Kicinski, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

Add the Cellient MPL200 card to usb/qmi_wwan and serial/option.

Wilken Gottwalt (2):
  usb: serial: qmi_wwan: add Cellient MPL200 card
  usb: serial: option: add Cellient MPL200 card

 drivers/net/usb/qmi_wwan.c  | 1 +
 drivers/usb/serial/option.c | 3 +++
 2 files changed, 4 insertions(+)

-- 
2.28.0


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card
  2020-10-03  9:39 [PATCH 0/2] add Cellient MPL200 card Wilken Gottwalt
@ 2020-10-03  9:39 ` Wilken Gottwalt
  2020-10-04 15:29   ` Bjørn Mork
  2020-10-03  9:40 ` [PATCH 2/2] usb: serial: option: " Wilken Gottwalt
  1 sibling, 1 reply; 17+ messages in thread
From: Wilken Gottwalt @ 2020-10-03  9:39 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjørn Mork, David S. Miller, Jakub Kicinski, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

Add usb ids of the Cellient MPL200 card.

Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 07c42c0719f5..0bf2b19d5d54 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1432,6 +1432,7 @@ static const struct usb_device_id products[] = {
 	{QMI_GOBI_DEVICE(0x1199, 0x901b)},	/* Sierra Wireless MC7770 */
 	{QMI_GOBI_DEVICE(0x12d1, 0x14f1)},	/* Sony Gobi 3000 Composite */
 	{QMI_GOBI_DEVICE(0x1410, 0xa021)},	/* Foxconn Gobi 3000 Modem device (Novatel E396) */
+	{QMI_FIXED_INTF(0x2692, 0x9025, 4)},	/* Cellient MPL200 (rebranded Qualcomm 0x05c6) */
 
 	{ }					/* END */
 };
-- 
2.28.0


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
  2020-10-03  9:39 [PATCH 0/2] add Cellient MPL200 card Wilken Gottwalt
  2020-10-03  9:39 ` [PATCH 1/2] usb: serial: qmi_wwan: " Wilken Gottwalt
@ 2020-10-03  9:40 ` Wilken Gottwalt
  2020-10-05  8:20   ` Johan Hovold
  1 sibling, 1 reply; 17+ messages in thread
From: Wilken Gottwalt @ 2020-10-03  9:40 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjørn Mork, David S. Miller, Jakub Kicinski, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

Add usb ids of the Cellient MPL200 card.

Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
---
 drivers/usb/serial/option.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 0c6f160a214a..a65e620b2277 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -528,6 +528,7 @@ static void option_instat_callback(struct urb *urb);
 /* Cellient products */
 #define CELLIENT_VENDOR_ID			0x2692
 #define CELLIENT_PRODUCT_MEN200			0x9005
+#define CELLIENT_PRODUCT_MPL200			0x9025
 
 /* Hyundai Petatel Inc. products */
 #define PETATEL_VENDOR_ID			0x1ff4
@@ -1982,6 +1983,8 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x02, 0x01) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x00, 0x00) },
 	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) },
+	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200),
+	  .driver_info = RSVD(1) | RSVD(4) },
 	{ USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600A) },
 	{ USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600E) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(TPLINK_VENDOR_ID, TPLINK_PRODUCT_LTE, 0xff, 0x00, 0x00) },	/* TP-Link LTE Module */
-- 
2.28.0


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card
  2020-10-03  9:39 ` [PATCH 1/2] usb: serial: qmi_wwan: " Wilken Gottwalt
@ 2020-10-04 15:29   ` Bjørn Mork
  2020-10-04 18:30     ` Wilken Gottwalt
  0 siblings, 1 reply; 17+ messages in thread
From: Bjørn Mork @ 2020-10-04 15:29 UTC (permalink / raw)
  To: Wilken Gottwalt
  Cc: linux-kernel, David S. Miller, Jakub Kicinski, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes:

> Add usb ids of the Cellient MPL200 card.
>
> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> ---
>  drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 07c42c0719f5..0bf2b19d5d54 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c

This is not a 'usb: serial' driver. Please resend with a less confusing
subject prefix.

> @@ -1432,6 +1432,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_GOBI_DEVICE(0x1199, 0x901b)},	/* Sierra Wireless MC7770 */
>  	{QMI_GOBI_DEVICE(0x12d1, 0x14f1)},	/* Sony Gobi 3000 Composite */
>  	{QMI_GOBI_DEVICE(0x1410, 0xa021)},	/* Foxconn Gobi 3000 Modem device (Novatel E396) */
> +	{QMI_FIXED_INTF(0x2692, 0x9025, 4)},	/* Cellient MPL200 (rebranded Qualcomm 0x05c6) */
>  
>  	{ }					/* END */
>  };


This table is supposed to be organized by device type.  The last section
is for Gobi2k and Gobi3k devices.  Please try to put new devices into
the correct section.

Thanks



Bjørn

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card
  2020-10-04 15:29   ` Bjørn Mork
@ 2020-10-04 18:30     ` Wilken Gottwalt
  2020-10-05  8:06       ` Johan Hovold
  2020-10-05 10:07       ` Bjørn Mork
  0 siblings, 2 replies; 17+ messages in thread
From: Wilken Gottwalt @ 2020-10-04 18:30 UTC (permalink / raw)
  To: Bjørn Mork
  Cc: linux-kernel, David S. Miller, Jakub Kicinski, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

On Sun, 04 Oct 2020 17:29:38 +0200
Bjørn Mork <bjorn@mork.no> wrote:

> Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes:
> 
> > Add usb ids of the Cellient MPL200 card.
> >
> > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> > ---
> >  drivers/net/usb/qmi_wwan.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> > index 07c42c0719f5..0bf2b19d5d54 100644
> > --- a/drivers/net/usb/qmi_wwan.c
> > +++ b/drivers/net/usb/qmi_wwan.c
> 
> This is not a 'usb: serial' driver. Please resend with a less confusing
> subject prefix.
> 
> > @@ -1432,6 +1432,7 @@ static const struct usb_device_id products[] = {
> >  	{QMI_GOBI_DEVICE(0x1199, 0x901b)},	/* Sierra Wireless MC7770 */
> >  	{QMI_GOBI_DEVICE(0x12d1, 0x14f1)},	/* Sony Gobi 3000 Composite */
> >  	{QMI_GOBI_DEVICE(0x1410, 0xa021)},	/* Foxconn Gobi 3000 Modem device (Novatel
> > E396) */
> > +	{QMI_FIXED_INTF(0x2692, 0x9025, 4)},	/* Cellient MPL200 (rebranded Qualcomm
> > 0x05c6) */ 
> >  	{ }					/* END */
> >  };
> 
> 
> This table is supposed to be organized by device type.  The last section
> is for Gobi2k and Gobi3k devices.  Please try to put new devices into
> the correct section.

Oh sorry, looks like I got it mixed up a bit. It was my first attempt to submit
a patch set. Which is the best way to resubmit an update if the other part of
the patch set gets accepted? The documentation about re-/submitting patch sets
is a bit thin.

Will

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card
  2020-10-04 18:30     ` Wilken Gottwalt
@ 2020-10-05  8:06       ` Johan Hovold
  2020-10-05  8:19         ` Johan Hovold
  2020-10-05 10:07       ` Bjørn Mork
  1 sibling, 1 reply; 17+ messages in thread
From: Johan Hovold @ 2020-10-05  8:06 UTC (permalink / raw)
  To: Wilken Gottwalt
  Cc: Bjørn Mork, linux-kernel, David S. Miller, Jakub Kicinski,
	Johan Hovold, Greg Kroah-Hartman, netdev, linux-usb

On Sun, Oct 04, 2020 at 08:30:42PM +0200, Wilken Gottwalt wrote:
> On Sun, 04 Oct 2020 17:29:38 +0200
> Bjørn Mork <bjorn@mork.no> wrote:
> 
> > Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes:
> > 
> > > Add usb ids of the Cellient MPL200 card.
> > >
> > > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> > > ---
> > >  drivers/net/usb/qmi_wwan.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> > > index 07c42c0719f5..0bf2b19d5d54 100644
> > > --- a/drivers/net/usb/qmi_wwan.c
> > > +++ b/drivers/net/usb/qmi_wwan.c
> > 
> > This is not a 'usb: serial' driver. Please resend with a less confusing
> > subject prefix.
> > 
> > > @@ -1432,6 +1432,7 @@ static const struct usb_device_id products[] = {
> > >  	{QMI_GOBI_DEVICE(0x1199, 0x901b)},	/* Sierra Wireless MC7770 */
> > >  	{QMI_GOBI_DEVICE(0x12d1, 0x14f1)},	/* Sony Gobi 3000 Composite */
> > >  	{QMI_GOBI_DEVICE(0x1410, 0xa021)},	/* Foxconn Gobi 3000 Modem device (Novatel
> > > E396) */
> > > +	{QMI_FIXED_INTF(0x2692, 0x9025, 4)},	/* Cellient MPL200 (rebranded Qualcomm
> > > 0x05c6) */ 
> > >  	{ }					/* END */
> > >  };
> > 
> > 
> > This table is supposed to be organized by device type.  The last section
> > is for Gobi2k and Gobi3k devices.  Please try to put new devices into
> > the correct section.
> 
> Oh sorry, looks like I got it mixed up a bit. It was my first attempt to submit
> a patch set. Which is the best way to resubmit an update if the other part of
> the patch set gets accepted? The documentation about re-/submitting patch sets
> is a bit thin.

Just send these as individual patches (not a series) as they are
independent and go through separate trees.

Also, I never received the USB serial patch, only this one, so you need
to resend both anyway.

Johan

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card
  2020-10-05  8:06       ` Johan Hovold
@ 2020-10-05  8:19         ` Johan Hovold
  0 siblings, 0 replies; 17+ messages in thread
From: Johan Hovold @ 2020-10-05  8:19 UTC (permalink / raw)
  To: Wilken Gottwalt
  Cc: Bjørn Mork, linux-kernel, David S. Miller, Jakub Kicinski,
	Johan Hovold, Greg Kroah-Hartman, netdev, linux-usb

On Mon, Oct 05, 2020 at 10:06:12AM +0200, Johan Hovold wrote:
> On Sun, Oct 04, 2020 at 08:30:42PM +0200, Wilken Gottwalt wrote:

> > Oh sorry, looks like I got it mixed up a bit. It was my first attempt to submit
> > a patch set. Which is the best way to resubmit an update if the other part of
> > the patch set gets accepted? The documentation about re-/submitting patch sets
> > is a bit thin.
> 
> Just send these as individual patches (not a series) as they are
> independent and go through separate trees.
> 
> Also, I never received the USB serial patch, only this one, so you need
> to resend both anyway.

Found it flagged spam, so no need to resend that one.

Just resend the networking one with a v2 prefix. In general, you could
mention in a changelog in the cover letter that you've removed patches
that have already been applied.

Johan

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
  2020-10-03  9:40 ` [PATCH 2/2] usb: serial: option: " Wilken Gottwalt
@ 2020-10-05  8:20   ` Johan Hovold
  2020-10-05 11:01     ` Wilken Gottwalt
  0 siblings, 1 reply; 17+ messages in thread
From: Johan Hovold @ 2020-10-05  8:20 UTC (permalink / raw)
  To: Wilken Gottwalt
  Cc: linux-kernel, Bjørn Mork, David S. Miller, Jakub Kicinski,
	Johan Hovold, Greg Kroah-Hartman, netdev, linux-usb

On Sat, Oct 03, 2020 at 11:40:29AM +0200, Wilken Gottwalt wrote:
> Add usb ids of the Cellient MPL200 card.
> 
> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> ---
>  drivers/usb/serial/option.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 0c6f160a214a..a65e620b2277 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -528,6 +528,7 @@ static void option_instat_callback(struct urb *urb);
>  /* Cellient products */
>  #define CELLIENT_VENDOR_ID			0x2692
>  #define CELLIENT_PRODUCT_MEN200			0x9005
> +#define CELLIENT_PRODUCT_MPL200			0x9025
>  
>  /* Hyundai Petatel Inc. products */
>  #define PETATEL_VENDOR_ID			0x1ff4
> @@ -1982,6 +1983,8 @@ static const struct usb_device_id option_ids[] = {
>  	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x02, 0x01) },
>  	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x00, 0x00) },
>  	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) },
> +	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200),
> +	  .driver_info = RSVD(1) | RSVD(4) },

Would you mind posting the output of "lsusb -v" for this device?

>  	{ USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600A) },
>  	{ USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600E) },
>  	{ USB_DEVICE_AND_INTERFACE_INFO(TPLINK_VENDOR_ID, TPLINK_PRODUCT_LTE, 0xff, 0x00, 0x00) },	/* TP-Link LTE Module */

Johan

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card
  2020-10-04 18:30     ` Wilken Gottwalt
  2020-10-05  8:06       ` Johan Hovold
@ 2020-10-05 10:07       ` Bjørn Mork
  1 sibling, 0 replies; 17+ messages in thread
From: Bjørn Mork @ 2020-10-05 10:07 UTC (permalink / raw)
  To: Wilken Gottwalt
  Cc: linux-kernel, David S. Miller, Jakub Kicinski, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes:

> Oh sorry, looks like I got it mixed up a bit. It was my first attempt to submit
> a patch set. Which is the best way to resubmit an update if the other part of
> the patch set gets accepted? The documentation about re-/submitting patch sets
> is a bit thin.

I see that Johan already has answered this.  Just wanted to add that you
don't need to worry about doing anything wrong.  It was not my intention
to scare you :-) Fixing up and resending patches is a natural part of
the patch submission process.  Don't be afraid to resubmit.  The worst
that can happen is that you'll be asked to fix up something else.
That's not a problem.

The most important part is to make it clear that a resubmission replaces
an earlier version of the same patch.  This should be visible in the
subject.  E.g by using a revision number inside the brackes, like

  [PATCH v2] net: qmi_wwan: add Cellient MPL200 card

This tells us that the patch is a revised "v2" of an earlier patch, and
that it replaces "v1".  Patches without an explicit revision will then
be assumed to be "v1".

If you are sending a series, then the whole series should usually be
resubmitted with the new revsion number.  Even patches without any
changes. The cover letter should then also summarize the changes for
each revisions.  But as Johan said: The USB serial and net patches go
through different trees and are therefore best handled as standalone
patches, even if they deal with the same USB composite device. 


Bjørn

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
  2020-10-05  8:20   ` Johan Hovold
@ 2020-10-05 11:01     ` Wilken Gottwalt
  2020-10-05 11:06       ` Johan Hovold
  0 siblings, 1 reply; 17+ messages in thread
From: Wilken Gottwalt @ 2020-10-05 11:01 UTC (permalink / raw)
  To: Johan Hovold
  Cc: linux-kernel, Bjørn Mork, David S. Miller, Jakub Kicinski,
	Greg Kroah-Hartman, netdev, linux-usb

On Mon, 5 Oct 2020 10:20:45 +0200
Johan Hovold <johan@kernel.org> wrote:

> On Sat, Oct 03, 2020 at 11:40:29AM +0200, Wilken Gottwalt wrote:
> > Add usb ids of the Cellient MPL200 card.
> > 
> > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> > ---
> >  drivers/usb/serial/option.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index 0c6f160a214a..a65e620b2277 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -528,6 +528,7 @@ static void option_instat_callback(struct urb *urb);
> >  /* Cellient products */
> >  #define CELLIENT_VENDOR_ID			0x2692
> >  #define CELLIENT_PRODUCT_MEN200			0x9005
> > +#define CELLIENT_PRODUCT_MPL200			0x9025
> >  
> >  /* Hyundai Petatel Inc. products */
> >  #define PETATEL_VENDOR_ID			0x1ff4
> > @@ -1982,6 +1983,8 @@ static const struct usb_device_id option_ids[] = {
> >  	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff,
> > 0x02, 0x01) }, { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2,
> > 0xff, 0x00, 0x00) }, { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) },
> > +	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200),
> > +	  .driver_info = RSVD(1) | RSVD(4) },
> 
> Would you mind posting the output of "lsusb -v" for this device?

I would like to, but unfortunately I lost access to this really rare hardware
about a month ago. It is a Qualcomm device (0x05c6:0x9025) with a slightly
modified firmware to rebrand it as a Cellient product with a different vendor
id. How to proceed here, if I have no access to it anymore? Drop it?

> >  	{ USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600A) },
> >  	{ USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600E) },
> >  	{ USB_DEVICE_AND_INTERFACE_INFO(TPLINK_VENDOR_ID, TPLINK_PRODUCT_LTE, 0xff, 0x00,
> > 0x00) },	/* TP-Link LTE Module */
> 
> Johan

greetings,
Will

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
  2020-10-05 11:01     ` Wilken Gottwalt
@ 2020-10-05 11:06       ` Johan Hovold
  2020-10-05 11:36         ` Lars Melin
  2020-10-05 12:02         ` Wilken Gottwalt
  0 siblings, 2 replies; 17+ messages in thread
From: Johan Hovold @ 2020-10-05 11:06 UTC (permalink / raw)
  To: Wilken Gottwalt
  Cc: Johan Hovold, linux-kernel, Bjørn Mork, David S. Miller,
	Jakub Kicinski, Greg Kroah-Hartman, netdev, linux-usb

On Mon, Oct 05, 2020 at 01:01:34PM +0200, Wilken Gottwalt wrote:
> On Mon, 5 Oct 2020 10:20:45 +0200
> Johan Hovold <johan@kernel.org> wrote:
> 
> > On Sat, Oct 03, 2020 at 11:40:29AM +0200, Wilken Gottwalt wrote:
> > > Add usb ids of the Cellient MPL200 card.
> > > 
> > > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> > > ---

> > > @@ -1982,6 +1983,8 @@ static const struct usb_device_id option_ids[] = {
> > >  	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff,
> > > 0x02, 0x01) }, { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2,
> > > 0xff, 0x00, 0x00) }, { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) },
> > > +	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200),
> > > +	  .driver_info = RSVD(1) | RSVD(4) },
> > 
> > Would you mind posting the output of "lsusb -v" for this device?
> 
> I would like to, but unfortunately I lost access to this really rare hardware
> about a month ago. It is a Qualcomm device (0x05c6:0x9025) with a slightly
> modified firmware to rebrand it as a Cellient product with a different vendor
> id. How to proceed here, if I have no access to it anymore? Drop it?

No, that's ok, I've applied the patch now. It's just that in case we
ever need to revisit the handling of quirky devices, it has proven
useful to have a record the descriptors.

Do you remember the interface layout and why you blacklisted interface
1?

Johan

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
  2020-10-05 11:06       ` Johan Hovold
@ 2020-10-05 11:36         ` Lars Melin
  2020-10-05 12:07           ` Wilken Gottwalt
  2020-10-05 12:02         ` Wilken Gottwalt
  1 sibling, 1 reply; 17+ messages in thread
From: Lars Melin @ 2020-10-05 11:36 UTC (permalink / raw)
  To: Johan Hovold, Wilken Gottwalt
  Cc: linux-kernel, Bjørn Mork, David S. Miller, Jakub Kicinski,
	Greg Kroah-Hartman, netdev, linux-usb

On 10/5/2020 18:06, Johan Hovold wrote:
> On Mon, Oct 05, 2020 at 01:01:34PM +0200, Wilken Gottwalt wrote:
>> On Mon, 5 Oct 2020 10:20:45 +0200
>> Johan Hovold <johan@kernel.org> wrote:
>>
>>> On Sat, Oct 03, 2020 at 11:40:29AM +0200, Wilken Gottwalt wrote:
>>>> Add usb ids of the Cellient MPL200 card.
>>>>
>>>> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
>>>> ---
> 
>>>> @@ -1982,6 +1983,8 @@ static const struct usb_device_id option_ids[] = {
>>>>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff,
>>>> 0x02, 0x01) }, { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2,
>>>> 0xff, 0x00, 0x00) }, { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) },
>>>> +	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200),
>>>> +	  .driver_info = RSVD(1) | RSVD(4) },
>>>
>>> Would you mind posting the output of "lsusb -v" for this device?
>>
>> I would like to, but unfortunately I lost access to this really rare hardware
>> about a month ago. It is a Qualcomm device (0x05c6:0x9025) with a slightly
>> modified firmware to rebrand it as a Cellient product with a different vendor
>> id. How to proceed here, if I have no access to it anymore? Drop it?
> 
> No, that's ok, I've applied the patch now. It's just that in case we
> ever need to revisit the handling of quirky devices, it has proven
> useful to have a record the descriptors.
> 
> Do you remember the interface layout and why you blacklisted interface
> 1?
> 
> Johan
> 

It is very likely that Cellient has replaced the VID with their own and 
kept the PID, it is something other mfgrs has done when buying modules 
from Qualcomm's series of devices with predefined composition.

The MS Windows driver for 05c6:9025 describes the interfaces as:

MI_00 Qualcomm HS-USB Diagnostics 9025
MI_01 Android Composite ADB Interface
MI_02 Qualcomm HS-USB Android Modem 9025
MI_03 Qualcomm HS-USB NMEA 9025
MI_04 Qualcomm Wireless HS-USB Ethernet Adapter 9025
MI_05 USB Mass Storage Device

where the net interface is for QMI/RMNET.
It fully matches the blacklisting Wilken has done for 2692:9025

br
Lars






^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
  2020-10-05 11:06       ` Johan Hovold
  2020-10-05 11:36         ` Lars Melin
@ 2020-10-05 12:02         ` Wilken Gottwalt
  1 sibling, 0 replies; 17+ messages in thread
From: Wilken Gottwalt @ 2020-10-05 12:02 UTC (permalink / raw)
  To: Johan Hovold
  Cc: linux-kernel, Bjørn Mork, David S. Miller, Jakub Kicinski,
	Greg Kroah-Hartman, netdev, linux-usb

On Mon, 5 Oct 2020 13:06:38 +0200
Johan Hovold <johan@kernel.org> wrote:

> On Mon, Oct 05, 2020 at 01:01:34PM +0200, Wilken Gottwalt wrote:
> > On Mon, 5 Oct 2020 10:20:45 +0200
> > Johan Hovold <johan@kernel.org> wrote:
> > 
> > > On Sat, Oct 03, 2020 at 11:40:29AM +0200, Wilken Gottwalt wrote:
> > > > Add usb ids of the Cellient MPL200 card.
> > > > 
> > > > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> > > > ---
> 
> > > > @@ -1982,6 +1983,8 @@ static const struct usb_device_id option_ids[] = {
> > > >  	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2,
> > > > 0xff, 0x02, 0x01) }, { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> > > > MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x00, 0x00) }, { USB_DEVICE(CELLIENT_VENDOR_ID,
> > > > CELLIENT_PRODUCT_MEN200) },
> > > > +	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200),
> > > > +	  .driver_info = RSVD(1) | RSVD(4) },
> > > 
> > > Would you mind posting the output of "lsusb -v" for this device?
> > 
> > I would like to, but unfortunately I lost access to this really rare hardware
> > about a month ago. It is a Qualcomm device (0x05c6:0x9025) with a slightly
> > modified firmware to rebrand it as a Cellient product with a different vendor
> > id. How to proceed here, if I have no access to it anymore? Drop it?
> 
> No, that's ok, I've applied the patch now. It's just that in case we
> ever need to revisit the handling of quirky devices, it has proven
> useful to have a record the descriptors.
> 
> Do you remember the interface layout and why you blacklisted interface
> 1?

If I remember correctly this interface belongs to the GPS data, but the
card itself has no connector for a GPS antenna. The NMEA protocol data
there were bogus values. I'm not sure if there is a hardware revision
which has the connector, but the firmware seems to support it. Interface
4 is the qmi endpoint for sure. The other endpoints are Hayes protocol
and diag.

greetings,
Will

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
  2020-10-05 11:36         ` Lars Melin
@ 2020-10-05 12:07           ` Wilken Gottwalt
  2020-10-06  7:02             ` Johan Hovold
  0 siblings, 1 reply; 17+ messages in thread
From: Wilken Gottwalt @ 2020-10-05 12:07 UTC (permalink / raw)
  To: Lars Melin
  Cc: Johan Hovold, linux-kernel, Bjørn Mork, David S. Miller,
	Jakub Kicinski, Greg Kroah-Hartman, netdev, linux-usb

On Mon, 5 Oct 2020 18:36:36 +0700
Lars Melin <larsm17@gmail.com> wrote:

> On 10/5/2020 18:06, Johan Hovold wrote:
> > On Mon, Oct 05, 2020 at 01:01:34PM +0200, Wilken Gottwalt wrote:
> >> On Mon, 5 Oct 2020 10:20:45 +0200
> >> Johan Hovold <johan@kernel.org> wrote:
> >>
> >>> On Sat, Oct 03, 2020 at 11:40:29AM +0200, Wilken Gottwalt wrote:
> >>>> Add usb ids of the Cellient MPL200 card.
> >>>>
> >>>> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> >>>> ---
> > 
> >>>> @@ -1982,6 +1983,8 @@ static const struct usb_device_id option_ids[] = {
> >>>>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2,
> >>>> 0xff, 0x02, 0x01) }, { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> >>>> MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x00, 0x00) }, { USB_DEVICE(CELLIENT_VENDOR_ID,
> >>>> CELLIENT_PRODUCT_MEN200) },
> >>>> +	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200),
> >>>> +	  .driver_info = RSVD(1) | RSVD(4) },
> >>>
> >>> Would you mind posting the output of "lsusb -v" for this device?
> >>
> >> I would like to, but unfortunately I lost access to this really rare hardware
> >> about a month ago. It is a Qualcomm device (0x05c6:0x9025) with a slightly
> >> modified firmware to rebrand it as a Cellient product with a different vendor
> >> id. How to proceed here, if I have no access to it anymore? Drop it?
> > 
> > No, that's ok, I've applied the patch now. It's just that in case we
> > ever need to revisit the handling of quirky devices, it has proven
> > useful to have a record the descriptors.
> > 
> > Do you remember the interface layout and why you blacklisted interface
> > 1?
> > 
> > Johan
> > 
> 
> It is very likely that Cellient has replaced the VID with their own and 
> kept the PID, it is something other mfgrs has done when buying modules 
> from Qualcomm's series of devices with predefined composition.
> 
> The MS Windows driver for 05c6:9025 describes the interfaces as:
> 
> MI_00 Qualcomm HS-USB Diagnostics 9025
> MI_01 Android Composite ADB Interface
> MI_02 Qualcomm HS-USB Android Modem 9025
> MI_03 Qualcomm HS-USB NMEA 9025
> MI_04 Qualcomm Wireless HS-USB Ethernet Adapter 9025
> MI_05 USB Mass Storage Device
> 
> where the net interface is for QMI/RMNET.
> It fully matches the blacklisting Wilken has done for 2692:9025

Does your device have a GPS connector? Mine had not and I'm not sure
if the description of MI_01 is actually correct. I remember looking at
this port and seeing bogus NMEA data.

greetings,
Will

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
  2020-10-05 12:07           ` Wilken Gottwalt
@ 2020-10-06  7:02             ` Johan Hovold
  2020-10-08  6:47               ` Wilken Gottwalt
  0 siblings, 1 reply; 17+ messages in thread
From: Johan Hovold @ 2020-10-06  7:02 UTC (permalink / raw)
  To: Wilken Gottwalt
  Cc: Lars Melin, Johan Hovold, linux-kernel, Bjørn Mork,
	David S. Miller, Jakub Kicinski, Greg Kroah-Hartman, netdev,
	linux-usb

On Mon, Oct 05, 2020 at 02:07:23PM +0200, Wilken Gottwalt wrote:
> On Mon, 5 Oct 2020 18:36:36 +0700 Lars Melin <larsm17@gmail.com> wrote:
> > On 10/5/2020 18:06, Johan Hovold wrote:

> > > Do you remember the interface layout and why you blacklisted interface
> > > 1?

> > It is very likely that Cellient has replaced the VID with their own and 
> > kept the PID, it is something other mfgrs has done when buying modules 
> > from Qualcomm's series of devices with predefined composition.
> > 
> > The MS Windows driver for 05c6:9025 describes the interfaces as:
> > 
> > MI_00 Qualcomm HS-USB Diagnostics 9025
> > MI_01 Android Composite ADB Interface
> > MI_02 Qualcomm HS-USB Android Modem 9025
> > MI_03 Qualcomm HS-USB NMEA 9025
> > MI_04 Qualcomm Wireless HS-USB Ethernet Adapter 9025
> > MI_05 USB Mass Storage Device
> > 
> > where the net interface is for QMI/RMNET.
> > It fully matches the blacklisting Wilken has done for 2692:9025
> 
> Does your device have a GPS connector? Mine had not and I'm not sure
> if the description of MI_01 is actually correct. I remember looking at
> this port and seeing bogus NMEA data.

Well if it's NMEA then the interface shouldn't be blacklisted (even if
the values are bogus on your device), but if it's ADB it should be as
that is handled by userspace.

Here's some lsusb output from a Cellient MPL200 that still uses the
Qualcomm VID:

	https://www.mail-archive.com/modemmanager-devel@lists.freedesktop.org/msg04523.html

which gives some support to Lars's hypothesis. I guess we'll just keep
the first interface reserved.

Johan

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
  2020-10-06  7:02             ` Johan Hovold
@ 2020-10-08  6:47               ` Wilken Gottwalt
  2020-10-08  7:16                 ` Johan Hovold
  0 siblings, 1 reply; 17+ messages in thread
From: Wilken Gottwalt @ 2020-10-08  6:47 UTC (permalink / raw)
  To: Johan Hovold
  Cc: Lars Melin, linux-kernel, Bjørn Mork, David S. Miller,
	Jakub Kicinski, Greg Kroah-Hartman, netdev, linux-usb

On Tue, 6 Oct 2020 09:02:01 +0200
Johan Hovold <johan@kernel.org> wrote:

> On Mon, Oct 05, 2020 at 02:07:23PM +0200, Wilken Gottwalt wrote:
> > On Mon, 5 Oct 2020 18:36:36 +0700 Lars Melin <larsm17@gmail.com> wrote:
> > > On 10/5/2020 18:06, Johan Hovold wrote:
> 
> > > > Do you remember the interface layout and why you blacklisted interface
> > > > 1?
> 
> > > It is very likely that Cellient has replaced the VID with their own and 
> > > kept the PID, it is something other mfgrs has done when buying modules 
> > > from Qualcomm's series of devices with predefined composition.
> > > 
> > > The MS Windows driver for 05c6:9025 describes the interfaces as:
> > > 
> > > MI_00 Qualcomm HS-USB Diagnostics 9025
> > > MI_01 Android Composite ADB Interface
> > > MI_02 Qualcomm HS-USB Android Modem 9025
> > > MI_03 Qualcomm HS-USB NMEA 9025
> > > MI_04 Qualcomm Wireless HS-USB Ethernet Adapter 9025
> > > MI_05 USB Mass Storage Device
> > > 
> > > where the net interface is for QMI/RMNET.
> > > It fully matches the blacklisting Wilken has done for 2692:9025
> > 
> > Does your device have a GPS connector? Mine had not and I'm not sure
> > if the description of MI_01 is actually correct. I remember looking at
> > this port and seeing bogus NMEA data.
> 
> Well if it's NMEA then the interface shouldn't be blacklisted (even if
> the values are bogus on your device), but if it's ADB it should be as
> that is handled by userspace.
> 
> Here's some lsusb output from a Cellient MPL200 that still uses the
> Qualcomm VID:
> 
> 	https://www.mail-archive.com/modemmanager-devel@lists.freedesktop.org/msg04523.html
> 
> which gives some support to Lars's hypothesis. I guess we'll just keep
> the first interface reserved.

Lars and Johan are right here. I found an older external Gobi driver
where I actually added comments saying interface 1 is ADB and interface 3
is NMEA delivering only zeroed values because of the missing antenna
connector, at least for the models I had access to.

Will

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
  2020-10-08  6:47               ` Wilken Gottwalt
@ 2020-10-08  7:16                 ` Johan Hovold
  0 siblings, 0 replies; 17+ messages in thread
From: Johan Hovold @ 2020-10-08  7:16 UTC (permalink / raw)
  To: Wilken Gottwalt
  Cc: Johan Hovold, Lars Melin, linux-kernel, Bjørn Mork,
	David S. Miller, Jakub Kicinski, Greg Kroah-Hartman, netdev,
	linux-usb

On Thu, Oct 08, 2020 at 08:47:33AM +0200, Wilken Gottwalt wrote:
> On Tue, 6 Oct 2020 09:02:01 +0200
> Johan Hovold <johan@kernel.org> wrote:
> 
> > On Mon, Oct 05, 2020 at 02:07:23PM +0200, Wilken Gottwalt wrote:
> > > On Mon, 5 Oct 2020 18:36:36 +0700 Lars Melin <larsm17@gmail.com> wrote:

> > > > It is very likely that Cellient has replaced the VID with their own and 
> > > > kept the PID, it is something other mfgrs has done when buying modules 
> > > > from Qualcomm's series of devices with predefined composition.
> > > > 
> > > > The MS Windows driver for 05c6:9025 describes the interfaces as:
> > > > 
> > > > MI_00 Qualcomm HS-USB Diagnostics 9025
> > > > MI_01 Android Composite ADB Interface
> > > > MI_02 Qualcomm HS-USB Android Modem 9025
> > > > MI_03 Qualcomm HS-USB NMEA 9025
> > > > MI_04 Qualcomm Wireless HS-USB Ethernet Adapter 9025
> > > > MI_05 USB Mass Storage Device
> > > > 
> > > > where the net interface is for QMI/RMNET.
> > > > It fully matches the blacklisting Wilken has done for 2692:9025
> > > 
> > > Does your device have a GPS connector? Mine had not and I'm not sure
> > > if the description of MI_01 is actually correct. I remember looking at
> > > this port and seeing bogus NMEA data.
> > 
> > Well if it's NMEA then the interface shouldn't be blacklisted (even if
> > the values are bogus on your device), but if it's ADB it should be as
> > that is handled by userspace.
> > 
> > Here's some lsusb output from a Cellient MPL200 that still uses the
> > Qualcomm VID:
> > 
> > 	https://www.mail-archive.com/modemmanager-devel@lists.freedesktop.org/msg04523.html
> > 
> > which gives some support to Lars's hypothesis. I guess we'll just keep
> > the first interface reserved.
> 
> Lars and Johan are right here. I found an older external Gobi driver
> where I actually added comments saying interface 1 is ADB and interface 3
> is NMEA delivering only zeroed values because of the missing antenna
> connector, at least for the models I had access to.

Great, thanks for confirming.

Johan

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, back to index

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-03  9:39 [PATCH 0/2] add Cellient MPL200 card Wilken Gottwalt
2020-10-03  9:39 ` [PATCH 1/2] usb: serial: qmi_wwan: " Wilken Gottwalt
2020-10-04 15:29   ` Bjørn Mork
2020-10-04 18:30     ` Wilken Gottwalt
2020-10-05  8:06       ` Johan Hovold
2020-10-05  8:19         ` Johan Hovold
2020-10-05 10:07       ` Bjørn Mork
2020-10-03  9:40 ` [PATCH 2/2] usb: serial: option: " Wilken Gottwalt
2020-10-05  8:20   ` Johan Hovold
2020-10-05 11:01     ` Wilken Gottwalt
2020-10-05 11:06       ` Johan Hovold
2020-10-05 11:36         ` Lars Melin
2020-10-05 12:07           ` Wilken Gottwalt
2020-10-06  7:02             ` Johan Hovold
2020-10-08  6:47               ` Wilken Gottwalt
2020-10-08  7:16                 ` Johan Hovold
2020-10-05 12:02         ` Wilken Gottwalt

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git