From: Guenter Roeck <linux@roeck-us.net>
To: zhong jiang <zhongjiang@huawei.com>,
heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: typec: fusb302: Fix an undefined reference to 'extcon_get_state'
Date: Fri, 13 Dec 2019 05:57:29 -0800 [thread overview]
Message-ID: <3dbe90ae-d1df-0714-f797-c6c279bf620c@roeck-us.net> (raw)
In-Reply-To: <1576239378-50795-1-git-send-email-zhongjiang@huawei.com>
On 12/13/19 4:16 AM, zhong jiang wrote:
> Fixes the following compile error:
>
> drivers/usb/typec/tcpm/fusb302.o: In function `tcpm_get_current_limit':
> fusb302.c:(.text+0x3ee): undefined reference to `extcon_get_state'
> fusb302.c:(.text+0x422): undefined reference to `extcon_get_state'
> fusb302.c:(.text+0x450): undefined reference to `extcon_get_state'
> fusb302.c:(.text+0x48c): undefined reference to `extcon_get_state'
> drivers/usb/typec/tcpm/fusb302.o: In function `fusb302_probe':
> fusb302.c:(.text+0x980): undefined reference to `extcon_get_extcon_dev'
> make: *** [vmlinux] Error 1
>
> It is because EXTCON is build as a module, but FUSB302 is not.
>
> Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/tcpm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig
> index 72481bb..5b986d6 100644
> --- a/drivers/usb/typec/tcpm/Kconfig
> +++ b/drivers/usb/typec/tcpm/Kconfig
> @@ -32,6 +32,7 @@ endif # TYPEC_TCPCI
> config TYPEC_FUSB302
> tristate "Fairchild FUSB302 Type-C chip driver"
> depends on I2C
> + depends on EXTCON || !EXTCON
> help
> The Fairchild FUSB302 Type-C chip driver that works with
> Type-C Port Controller Manager to provide USB PD and USB
>
prev parent reply other threads:[~2019-12-13 20:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 7:34 [PATCH] usb: typec: fusb302: Fix an undefined reference to 'extcon_get_state' zhong jiang
2019-12-12 9:01 ` Heikki Krogerus
2019-12-12 9:15 ` zhong jiang
2019-12-12 9:28 ` Greg KH
2019-12-12 9:35 ` zhong jiang
2019-12-12 9:40 ` zhong jiang
2019-12-12 11:18 ` Heikki Krogerus
2019-12-12 12:20 ` Greg KH
2019-12-12 12:49 ` Heikki Krogerus
2019-12-12 14:20 ` zhong jiang
2019-12-12 14:57 ` Guenter Roeck
2019-12-13 12:16 ` [PATCH v2] " zhong jiang
2019-12-13 12:31 ` Heikki Krogerus
2019-12-13 13:57 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dbe90ae-d1df-0714-f797-c6c279bf620c@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).