From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D2ECC04AA7 for ; Mon, 13 May 2019 11:33:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 709792070D for ; Mon, 13 May 2019 11:33:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=zaltys-org.20150623.gappssmtp.com header.i=@zaltys-org.20150623.gappssmtp.com header.b="Tot6V3up" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729453AbfEMLd2 (ORCPT ); Mon, 13 May 2019 07:33:28 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:40582 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729381AbfEMLdR (ORCPT ); Mon, 13 May 2019 07:33:17 -0400 Received: by mail-pl1-f195.google.com with SMTP id b3so6349935plr.7 for ; Mon, 13 May 2019 04:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaltys-org.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=vIAiIlRHFlvzv9k+xH8nEYUaTAu5zyVCWpRcJP2mCII=; b=Tot6V3up2+HWtknpsoM4dHvQa7QQqbVninOPpnopo2wzgPQUAtmIPR0dsqOARVECTG K97IFaLXAZx/3L6Rw9Vk12yDr0VM9rR/4+eI6mUIKZssBdcQ1E5+evvEn9o3vdaGN7uO ut5FnC0LFECAz1oyoCOghV1Q27MHaHqouNqZH9wX54oQHFME8GnUcXKqiMoCgscnaivW aN7g33w4UYFpW2BrrNaepLE2akGZYkmaboYLaXH/+YR6Q+HyIAPH6s9srT0DzeLghCg5 zU0D/Nk8pmjUlcsXkdQe3Y+FP++WAkzz9cp0//FzG3p3GWmpUwA28cFyZoGoyvk07rVO BCQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=vIAiIlRHFlvzv9k+xH8nEYUaTAu5zyVCWpRcJP2mCII=; b=J5BgqJJESL0CJh8/+kggQZd76iCh5t2I0G9qpGl4qgPt6kAy3ybMpp3f+0/wIirpik wrkK/SW0qid1CnxEQw6PUujcwZIdGC4cgZvsm0QoQSjLcy6cVPKJ7/+l5kBnXNep7Lvx asi4euYYdbixZEvodeO1J9NgR1NflIi9i90vCH/dLYF4gjjhNfN7K7tEr8dpbNv168IM c2f1WJCKHmmdjfGQVYPLAlKz+AdGYkvSPCrcCNjrdUdAyn+BnOvFhXzZgC44hLh6acJA W6V7aswCVxMlcqHmeHv386Ce5jJZjARrN0pwauTguYe/Jlcv2mZBQ4Ojw+RLspcjUEPv K/uA== X-Gm-Message-State: APjAAAWtplQ7BYvYYKM0CkKKQMSf5TPvxw0Cv7nAT0kILncRMbdpqfrD 8GvBk3flJnGoS47advjDJjlmCw== X-Google-Smtp-Source: APXvYqwAEFg6Wul3VsCH7RrW8iX3qzuipuHAYVcRiGC6fovckro06GFeujxxW1Fd612upFEtypRy0Q== X-Received: by 2002:a17:902:ba8e:: with SMTP id k14mr30192640pls.80.1557747197055; Mon, 13 May 2019 04:33:17 -0700 (PDT) Received: from [172.28.0.10] (122-59-127-127-fibre.sparkbb.co.nz. [122.59.127.127]) by smtp.googlemail.com with ESMTPSA id r124sm12699914pgr.91.2019.05.13.04.33.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2019 04:33:16 -0700 (PDT) From: James Grant Subject: Re: [PATCH] usb: gadget: udc: lpc32xx: allocate descriptor with GFP_ATOMIC To: Alexandre Belloni , Felipe Balbi , Vladimir Zapolskiy , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, James Grant , Sylvain Lemieux , linux-arm-kernel@lists.infradead.org References: <20190510124248.2430-1-alexandre.belloni@bootlin.com> Message-ID: <417966d0-e656-b4e6-c1ea-b53bf687a870@zaltys.org> Date: Mon, 13 May 2019 23:33:11 +1200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190510124248.2430-1-alexandre.belloni@bootlin.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-AU Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Tested with a board containing LPC3250 SOC and STOTG04 PHY by using serial gadget. Needed patch series starting with "[PATCH 0/5] usb: gadget: udc: lpc32xx: add stotg04 phy support" also. Tested-by: James Grant Regards, James Grant. On 11/05/2019 00:42, Alexandre Belloni wrote: > Gadget drivers may queue request in interrupt context. This would lead to > a descriptor allocation in that context. In that case we would hit > BUG_ON(in_interrupt()) in __get_vm_area_node. > > Signed-off-by: Alexandre Belloni > --- > drivers/usb/gadget/udc/lpc32xx_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c > index d8f1c60793ed..b706d9c85a35 100644 > --- a/drivers/usb/gadget/udc/lpc32xx_udc.c > +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c > @@ -938,7 +938,7 @@ static struct lpc32xx_usbd_dd_gad *udc_dd_alloc(struct lpc32xx_udc *udc) > struct lpc32xx_usbd_dd_gad *dd; > > dd = (struct lpc32xx_usbd_dd_gad *) dma_pool_alloc( > - udc->dd_cache, (GFP_KERNEL | GFP_DMA), &dma); > + udc->dd_cache, (GFP_ATOMIC | GFP_DMA), &dma); > if (dd) > dd->this_dma = dma; >