linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Thomas Hebb <tommyhebb@gmail.com>, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 1/2] usb: typec: wcove: fix "op-sink-microwatt" default that was in mW
Date: Mon, 20 Jan 2020 06:25:00 -0800	[thread overview]
Message-ID: <432ff907-044d-3e7c-75fc-0a172d1ed6c1@roeck-us.net> (raw)
In-Reply-To: <d8be32512efd31995ad7d65b27df9d443131b07c.1579529334.git.tommyhebb@gmail.com>

On 1/20/20 6:09 AM, Thomas Hebb wrote:
> commit 4c912bff46cc ("usb: typec: wcove: Provide fwnode for the port")
> didn't convert this value from mW to uW when migrating to a new
> specification format like it should have.
> 
> Fixes: 4c912bff46cc ("usb: typec: wcove: Provide fwnode for the port")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> 
> ---
> 
> Changes in v3:
> - Use the right stable email address
> 
> Changes in v2:
> - Split fix into two patches
> - Added stable cc
> 
>   drivers/usb/typec/tcpm/wcove.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/wcove.c b/drivers/usb/typec/tcpm/wcove.c
> index edc271da14f4..9b745f432c91 100644
> --- a/drivers/usb/typec/tcpm/wcove.c
> +++ b/drivers/usb/typec/tcpm/wcove.c
> @@ -597,7 +597,7 @@ static const struct property_entry wcove_props[] = {
>   	PROPERTY_ENTRY_STRING("try-power-role", "sink"),
>   	PROPERTY_ENTRY_U32_ARRAY("source-pdos", src_pdo),
>   	PROPERTY_ENTRY_U32_ARRAY("sink-pdos", snk_pdo),
> -	PROPERTY_ENTRY_U32("op-sink-microwatt", 15000),
> +	PROPERTY_ENTRY_U32("op-sink-microwatt", 15000000),
>   	{ }
>   };
>   
> 


  parent reply	other threads:[~2020-01-20 14:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 14:09 [PATCH v3 1/2] usb: typec: wcove: fix "op-sink-microwatt" default that was in mW Thomas Hebb
2020-01-20 14:09 ` [PATCH v3 2/2] usb: typec: fusb302: " Thomas Hebb
2020-01-20 14:25   ` Guenter Roeck
2020-01-20 15:05   ` Heikki Krogerus
2020-01-22  9:12   ` Greg Kroah-Hartman
2020-01-20 14:25 ` Guenter Roeck [this message]
2020-01-20 15:05 ` [PATCH v3 1/2] usb: typec: wcove: " Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=432ff907-044d-3e7c-75fc-0a172d1ed6c1@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tommyhebb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).