From: Jon Hunter <jonathanh@nvidia.com>
To: JC Kuo <jckuo@nvidia.com>, <gregkh@linuxfoundation.org>,
<thierry.reding@gmail.com>, <pdeschrijver@nvidia.com>,
<afrid@nvidia.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<devicetree@vger.kernel.org>, <nkristam@nvidia.com>,
<skomatineni@nvidia.com>
Subject: Re: [PATCH 4/8] phy: tegra: xusb: add sleepwalk and suspend/resume
Date: Thu, 4 Jul 2019 14:40:47 +0100 [thread overview]
Message-ID: <446b74c1-3d54-62ab-0491-b183389e6efd@nvidia.com> (raw)
In-Reply-To: <20190614074652.21960-5-jckuo@nvidia.com>
On 14/06/2019 08:46, JC Kuo wrote:
> This commit adds sleepwalk/wake and suspend/resume interfaces
> to Tegra XUSB PHY driver.
If you adding new custom global APIs, you really need to explain why
these are needed and how they are used. If we can avoid adding such
global APIs, it is preferred.
Cheers
Jon
--
nvpublic
prev parent reply other threads:[~2019-07-04 13:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 7:46 [PATCH 0/8] Tegra XHCI controller ELPG support JC Kuo
2019-06-14 7:46 ` [PATCH 1/8] clk: tegra: Add PLLE HW power sequencer control JC Kuo
2019-07-04 12:16 ` Jon Hunter
2019-09-05 6:26 ` JC Kuo
2019-06-14 7:46 ` [PATCH 2/8] clk: tegra: don't enable PLLE HW sequencer at init JC Kuo
2019-07-04 12:22 ` Jon Hunter
2019-07-05 3:45 ` JC Kuo
2019-06-14 7:46 ` [PATCH 3/8] phy: tegra: xusb: t210: rearrange UPHY init JC Kuo
2019-07-04 13:32 ` Jon Hunter
2019-07-05 6:48 ` JC Kuo
2019-07-08 7:55 ` Peter De Schrijver
2019-06-14 7:46 ` [PATCH 4/8] phy: tegra: xusb: add sleepwalk and suspend/resume JC Kuo
2019-07-04 13:40 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446b74c1-3d54-62ab-0491-b183389e6efd@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=afrid@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jckuo@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nkristam@nvidia.com \
--cc=pdeschrijver@nvidia.com \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).