From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 365CEC433E7 for ; Tue, 13 Oct 2020 08:29:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9BBB20797 for ; Tue, 13 Oct 2020 08:29:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390626AbgJMI34 (ORCPT ); Tue, 13 Oct 2020 04:29:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390540AbgJMI3z (ORCPT ); Tue, 13 Oct 2020 04:29:55 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0D97C0613D0 for ; Tue, 13 Oct 2020 01:29:55 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: andrzej.p) with ESMTPSA id 12A711F44F2B Subject: Re: xhci problem -> general protection fault To: Mathias Nyman , zwisler@google.com Cc: "linux-usb@vger.kernel.org" , "kernel@collabora.com" References: <65ac3a73-ca57-c3e8-561b-9ba5c15b3c65@collabora.com> <8230c2a2-719c-ef81-e85d-5921bf8e98e6@collabora.com> <133c123e-e857-7f83-d146-f39c00afe39f@linux.intel.com> <20200925210517.GA4487@google.com> <7e38c533-6ea1-63a6-fc92-2ecef7ee1f84@linux.intel.com> <20201001164352.GA13249@google.com> <69f8cbc3-0ae7-cfb2-2fdd-556ada77381f@linux.intel.com> <20201012215348.GA3324220@google.com> From: Andrzej Pietrasiewicz Message-ID: <48f2e022-1937-6ecc-ad8e-ef293fd2bfe1@collabora.com> Date: Tue, 13 Oct 2020 10:29:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, W dniu 13.10.2020 o 09:49, Mathias Nyman pisze: > On 13.10.2020 0.53, zwisler@google.com wrote: >> On Mon, Oct 12, 2020 at 10:20:31PM +0300, Mathias Nyman wrote: >>> On 1.10.2020 19.43, zwisler@google.com wrote: >>>> On Tue, Sep 29, 2020 at 01:35:31AM +0300, Mathias Nyman wrote: >> >>> I'm rewriting how xhci driver handles halted and canceled transfers. >>> While looking into it I found an older case where hardware gives bad data >>> in the output context. This was 10 years ago and on some specic hardware, >>> see commit: >>> >>> ac9d8fe7c6a8 USB: xhci: Add quirk for Fresco Logic xHCI hardware. >>> >>>> >>>> I'm happy to gather logs with more debug or run other experiments, if that >>>> would be helpful. As it is I don't really know how to debug the internal >>>> state of the HC further, but hopefully the knowledge that the patch below >>>> makes a difference will help us move forward. >>> >>> Great thanks, it will take some time before rewrite is ready. >> >> Should we/I invest time in trying to create a quirk similar to >> >>> ac9d8fe7c6a8 USB: xhci: Add quirk for Fresco Logic xHCI hardware. >> >> in the mean time, or should we just wait for your rewrite? >> > > I've been focusing on this part so rewrite shouldn't take long. Thank you for doing that! Should you be sending your patches not as a reply in this thread kindly Cc me andrzej.p@collabora.com. Regards, Andrzej