From: Bastien Nocera <email@example.com> To: Greg Kroah-Hartman <firstname.lastname@example.org> Cc: email@example.com, Benjamin Tissoires <firstname.lastname@example.org> Subject: Re: [PATCH v3 0/6] Add Apple MFi fastcharge USB device driver Date: Thu, 13 Feb 2020 00:24:49 +0100 Message-ID: <email@example.com> (raw) In-Reply-To: <20200212231759.GA2491995@kroah.com> On Wed, 2020-02-12 at 15:17 -0800, Greg Kroah-Hartman wrote: > On Thu, Feb 13, 2020 at 12:05:13AM +0100, Bastien Nocera wrote: > > On Wed, 2020-02-12 at 11:06 -0800, Greg Kroah-Hartman wrote: > > > On Wed, Oct 16, 2019 at 11:39:27AM +0200, Bastien Nocera wrote: > > > > This is version 3 of the patch set. > > > > > > > > Changes in v3: > > > > - Add Alan's ack > > > > - don't export usb_device_match_id() > > > > > > > > Changes in v2: > > > > - checkpatch.pl is now quiet > > > > - fallback to the generic driver when driver ->probe() fails > > > > > > Sorry for the long response to this, my fault. > > > > > > At first, I really don't like the idea of using the usb device > > > driver > > > interface, but I don't think there's a better way. And, you did > > > the > > > work to make it so that it works cleanly, which is always > > > appreciated. > > > > I'm hoping that a few user-space drivers end up upstream in the > > kernel > > for hardware that needs it. > > And here I am wanting to move more USB drivers to userspace :) > > What ones do you see that are currently in userspace that should be > in > the kernel? The power control one here makes sense, are there others > like this? Well, I don't know yet. I would expect them to be of similar ilk, and fit in with the type of devices the kernel already handles but would use interfaces for on other devices. As I mentioned at the beginning of the discussion, I'm not trying to bring in user-space drivers that don't fit in an existing subsystem, but rather those that are badly designed ;) > > I plan on making some more changes to the USB subsystem in the > > (near) > > future, so it's to get my feet wet with this. > > That was a serious modification to "start" with, nice work. I think what I want to work on, revoke support for USB devices, might be more complicated/racy/full of security problems.
prev parent reply index Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-16 9:39 Bastien Nocera 2019-10-16 9:39 ` [PATCH v3 1/6] USB: Export generic USB device driver functions Bastien Nocera 2019-10-16 9:39 ` [PATCH v3 2/6] USB: Make it possible to "subclass" usb_device_driver Bastien Nocera 2019-10-16 9:39 ` [PATCH v3 3/6] USB: Implement usb_device_match_id() Bastien Nocera 2019-10-16 9:39 ` [PATCH v3 4/6] USB: Select better matching USB drivers when available Bastien Nocera 2019-10-16 9:39 ` [PATCH v3 5/6] USB: Fallback to generic driver when specific driver fails Bastien Nocera 2019-10-16 9:39 ` [PATCH v3 6/6] USB: Add driver to control USB fast charge for iOS devices Bastien Nocera 2019-11-21 15:20 ` [PATCH v3 0/6] Add Apple MFi fastcharge USB device driver Bastien Nocera 2020-01-07 8:46 ` Bastien Nocera 2020-01-07 9:35 ` Greg Kroah-Hartman 2020-01-07 9:48 ` Bastien Nocera 2020-02-11 0:21 ` Bastien Nocera 2020-02-12 17:52 ` Greg Kroah-Hartman 2020-02-12 19:06 ` Greg Kroah-Hartman 2020-02-12 23:05 ` Bastien Nocera 2020-02-12 23:17 ` Greg Kroah-Hartman 2020-02-12 23:24 ` Bastien Nocera [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-USB Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \ email@example.com public-inbox-index linux-usb Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb AGPL code for this site: git clone https://public-inbox.org/public-inbox.git