From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: USB list <linux-usb@vger.kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: f_mass_storage vs drivers/target
Date: Mon, 26 Aug 2019 12:19:53 +1000 [thread overview]
Message-ID: <507ef2a33079c35ad9cf3fa4f0acc585b401893e.camel@kernel.crashing.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1908231117260.1628-100000@iolanthe.rowland.org>
On Fri, 2019-08-23 at 11:21 -0400, Alan Stern wrote:
> > I wonder since f_tcm is also the only user, whether we could change
> > the
> > matching logic to either:
> >
> > - Don't try to match, return streams is available. This could be
> > problematic if the UDC supports streams on some EPs and not others
> > however.
> >
> > - Do two passes: one pass trying to match the streams, and one
> > patch
> > without matching them if the first one fails.
> >
> > Then f_tcm could check whether it got EPs with streams and enable
> > stream usage accordingly.
> >
> > Opinions ? Other option ?
>
> I like the two-pass option better. Maybe Felipe will weigh in when
> he's back from vacation.
Yup, I prefer it too. I'll cook up something in the meantime so I have
a patch to show.
Cheers,
Ben.
prev parent reply other threads:[~2019-08-26 2:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 3:38 f_mass_storage vs drivers/target Benjamin Herrenschmidt
2019-08-21 9:32 ` Greg KH
2019-08-21 14:25 ` Alan Stern
2019-08-22 0:10 ` Benjamin Herrenschmidt
2019-08-22 4:58 ` Benjamin Herrenschmidt
2019-08-22 5:14 ` Benjamin Herrenschmidt
2019-08-22 5:48 ` Benjamin Herrenschmidt
2019-08-22 17:30 ` Alan Stern
2019-08-23 0:40 ` Benjamin Herrenschmidt
2019-08-23 15:21 ` Alan Stern
2019-08-26 2:19 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507ef2a33079c35ad9cf3fa4f0acc585b401893e.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=bigeasy@linutronix.de \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).