From: Oliver Neukum <oneukum@suse.de>
To: "Noralf Trønnes" <noralf@tronnes.org>, dri-devel@lists.freedesktop.org
Cc: linux-usb@vger.kernel.org, sam@ravnborg.org, peter@stuge.se,
lkundrak@v3.sk, markus@raatikainen.cc, pontus.fuchs@gmail.com,
hudson@trmm.net, th020394@gmail.com,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v5 3/3] drm: Add Generic USB Display driver
Date: Tue, 16 Feb 2021 14:36:37 +0100 [thread overview]
Message-ID: <5164bb01b7f3cf71926109a37b9e3957cfb630ba.camel@suse.de> (raw)
In-Reply-To: <20210212174609.58977-4-noralf@tronnes.org>
Am Freitag, den 12.02.2021, 18:46 +0100 schrieb Noralf Trønnes:
> +static void gud_connector_early_unregister(struct drm_connector *connector)
> +{
> + struct gud_connector *gconn = to_gud_connector(connector);
> +
> + backlight_device_unregister(gconn->backlight);
> + cancel_work_sync(&gconn->backlight_work);
> +}
Hi,
this looks like you are creating a race condition where the queued work
may operate on an already unregistered backlight.
Regards
Oliver
next prev parent reply other threads:[~2021-02-16 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 17:46 [PATCH v5 0/3] GUD USB Display driver Noralf Trønnes
2021-02-12 17:46 ` [PATCH v5 1/3] drm/uapi: Add USB connector type Noralf Trønnes
2021-02-12 17:46 ` [PATCH v5 2/3] drm/probe-helper: Check epoch counter in output_poll_execute() Noralf Trønnes
2021-02-12 17:46 ` [PATCH v5 3/3] drm: Add Generic USB Display driver Noralf Trønnes
2021-02-15 11:58 ` Peter Stuge
2021-02-16 13:19 ` Noralf Trønnes
2021-02-16 13:36 ` Oliver Neukum [this message]
2021-02-16 16:40 ` Noralf Trønnes
2021-02-16 16:43 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5164bb01b7f3cf71926109a37b9e3957cfb630ba.camel@suse.de \
--to=oneukum@suse.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hudson@trmm.net \
--cc=linux-usb@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=markus@raatikainen.cc \
--cc=noralf@tronnes.org \
--cc=peter@stuge.se \
--cc=pontus.fuchs@gmail.com \
--cc=sam@ravnborg.org \
--cc=th020394@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).