archive mirror
 help / color / mirror / Atom feed
From: Shuah Khan <>
To: Michael <>
	Shuah Khan <>
Subject: Re: [PATCH v2] vhci_hcd: USB port can get stuck in the disabled state
Date: Mon, 2 Aug 2021 17:14:54 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 7/30/21 5:52 PM, Michael wrote:
> Yes i think just adding the VDEV_ST_USED check in addition to the
> VDEV_ST_NOT_ASSIGNED state is fine and would fix the issue.

Can you please confirm if this works?

> After many years of writing virtualhere (a similar system to usb/ip
> but cross-platform and different non-kernel way of doing it server
> side) I've seen many drivers that issue reset at any time. Loading
> firmware is usually the reason.  Also sometimes switching
> configurations requires a reset also, for example some gaming wheels
> do this. I don't think you should make this VDEV_ST_USED check
> specific to Wifi devices, as a lot of devices don't follow too closely
> to the USB protocol to begin with from my experience. They primarily
> base their USB interactions assuming the windows platform and its
> quirks.

When sending responses to Linux kernel mailing lists, please use bottom post.
This check will be used for all drivers. We don't add checks for specific cases
in the code.

-- Shuah

  reply	other threads:[~2021-08-02 23:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 23:55 [PATCH v2] vhci_hcd: USB port can get stuck in the disabled state Michael Broadfoot
2021-07-22  1:26 ` Shuah Khan
     [not found]   ` <>
2021-07-22  6:19     ` Michael
2021-07-23 16:29     ` Shuah Khan
2021-07-23 23:53       ` Michael
2021-07-23 23:58       ` Michael
2021-07-30 22:52         ` Shuah Khan
2021-07-30 23:52           ` Michael
2021-08-02 23:14             ` Shuah Khan [this message]
2021-08-03  1:00               ` Michael
2021-08-10 17:46                 ` Shuah Khan
2021-08-11  2:30                   ` Michael
2021-08-19 22:57                     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).