From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MIME_HEADER_CTYPE_ONLY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5B3C3A589 for ; Thu, 15 Aug 2019 12:19:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9217A206C1 for ; Thu, 15 Aug 2019 12:19:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730132AbfHOMT0 (ORCPT ); Thu, 15 Aug 2019 08:19:26 -0400 Received: from comms.puri.sm ([159.203.221.185]:36920 "EHLO comms.puri.sm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729649AbfHOMTZ (ORCPT ); Thu, 15 Aug 2019 08:19:25 -0400 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id E5C86DFD78; Thu, 15 Aug 2019 05:19:23 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tjr_SaRr22I2; Thu, 15 Aug 2019 05:19:23 -0700 (PDT) Subject: Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card To: Johan Hovold Cc: "Angus Ainslie (Purism)" , kernel@puri.sm, =?UTF-8?Q?Bj=c3=b8rn_Mork?= , "David S. Miller" , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190724145227.27169-1-angus@akkea.ca> <20190724145227.27169-2-angus@akkea.ca> <20190805114711.GF3574@localhost> <5fb96703-b174-eef1-5ad1-693e2bbce32f@puri.sm> <20190815114941.GE32300@localhost> From: Bob Ham Openpgp: preference=signencrypt Autocrypt: addr=bob.ham@puri.sm; prefer-encrypt=mutual; keydata= mQINBForn50BEADgQ+MHGdnCF0WPBBZ9FaybdqNInMDmOEdB1CszEGlVNQTp4OmADnfbskJ6 WYUzftX6dflDu9yDAzksl4Pox9IJUR9TCXKjdD4IZxlWSSa5jr4k80e36i/XWpIpheWPN2/U /W7HVQq35RrAJEgbQfDF0EEeeprYtv6zVcnHg3a6oZ/4oFDZECORdLApmFnoXEiR3KDrXnTh dtTJsOlM5eCMf90WuOl4znMS2QcXZakLiQ1TCl/Ti1ewzI1E5IDwN6xdPXDVmBWVTnBmT64h bkqcVmwfAlaDbQmt/LOfQ1aeS3uQBRovuZTqAwu3VzxUZy+B2efNPpEj7KebDOFD4eV60nVi 11T9uvZ2GAzuKj4oTLtulOeA+f3IQDPDu4WZNY6NsZAHsUtvlee//xrQYyP3RlHuoTFlIIJC H7ls5Z6yJC9ewBJGXLurBeIa1BHzv4ER9gEW2Msc7xnDgP4adSLy/t754mR2l4AIZw/gJ3AW LcwZSheWMhlqK0No6DaZ4/18ieX8P8PnZ+9HdlMG6d16DYDGYbPX3h0KbGgUbgNxu9sReBa2 8+Dhn1wmgnCiPBQ0IieWdRKBz8yrXBOYWQf9uQTf6NyXUEyXEDb0O1sx909EIJ9nsfh4LWV0 NWX0aRugWUX42iSa/HV6Ipt6WUEzgwQ2DxpPs1E8dkDa5NjmawARAQABtBlCb2IgSGFtIDxi b2IuaGFtQHB1cmkuc20+iQJOBBMBCAA4FiEE745irA8zXATsZwYpUxfwLpX1YkEFAlorn50C GwMFCwkIBwMFFQoJCAsFFgIDAQACHgECF4AACgkQUxfwLpX1YkHHnxAAizohDH14eC6j6iQ5 cJBlqab0lpLixNUHBmf/gOpY2fWJyjsRqSgyDcy45JNKXs4RQ5fNKchqeVTb7cC9eBxe8Fs9 AEeZCoVPcLPCEWzihxuV5NBcMRdetNBvtuIvNG2vOo4PW5WZklXanDKLwLhtk76gLFzKXfIE aXhRLuNBko6XHMmSUT/fIlOhiOOQaxI89TE8WO5aqg97EDQiAnjl6kkaOcNfPqSxjtS3U3+b HGBgkwyQ9sHG00kofl8incEijp425/yqQPB25NxcdO7ptuETnxF9bxfF7Vt6BIDKf8Y3GpBe /rz9NO2RfA2RXuTSu/Oqw6TQeHAxxua2yjRLUTsKI+pyD4gHc6Yp/LN/l5sOtNTcC39ucFKA +fNmMBmcpfE6BRBM/6op0AXCxhyPbRRRA/mR7iwOMJAjZCiLfgDDW2vftO5yex30m+tMUhiy uwLUkdT5ONxcedmE0tZ7KREa/5lxBC9cx8nF8yQJZXV0qEg9PZY1sz8CKxdJBwF0nZu51w71 luwVaW8azzKjD6ZZsSjfGGU8RMbpvzh0NB7DE+E5IKQA0dgrTYgq/Rr+wkgUeVMUW8lsDWaW CBWcG4aSs66jWiIyN7ISNTBEXXpas6VBlMv/FdET3nAX7QmRbPglmMAT0qszsT2lxxui7SPA TMo43M0cxj62EGvfiDO5Ag0EWiufnQEQAOzRERpoE0sd5voswIyyt2sTm2PHkyx8Opxg73hU yw6O5GZ3BbLn+hNzG4VPiBcfY4bMe8hDTD3vJcaL35b6Hqk4LGo33waQMBmravNKHttuVrcF RoK/pSHHcvQio/3K0y4JBu5qFTAp5L/geuXeuduQr6GNROTPZInK1Tv/Ga8BII3uTN7QYLjf GPOQz3AKN6ADi/2k3eYq70oqTyYhhj4VM8G7o3uAg0wGhQrMt/vuhHspi0M8ZKNJJPTUacSw AKxHx08Awsurq42O4uoKYrNTbxYNyTFIw0P2TkYEW5JIltrrl8oX+ul3TB5EABViyhxzPt88 ZqtnAXGi31klKAQo1Nt2p13gw6EM28KZM4T8N1YpSvjAnSGmpQ0zSXVxIY2eRL7FG4GhJLrA dFogzXHjcY0xsdcLAkK4PAeicwrTXf5s9DLRJVaeZJpQTR4FbmZdwAe8TNcADxutEeqDi7Kf l3t/NiQtE71Uq6OO81o6bTmmOev5qhXtuRcSbqKbEQGRWQP8t4vvfua1yJSLFjuVF9AARci3 I33QbESq0w/KU0xtCAemdR+6krQiU4f/gtdoTAjfRgBtK5OHmJjaE6FKo9akAmHq3I+BTx/5 inIX5PN80B+pWeOtqLN+CPOu56xaq11iIJEDcGoiaeN+R8aFG9OwWxVuuHwDdt9yG1rtABEB AAGJAjYEGAEIACAWIQTvjmKsDzNcBOxnBilTF/AulfViQQUCWiufnQIbDAAKCRBTF/AulfVi Qc81D/91mIjeDTnXY9GAXfxiTHrAw6XEo5aX2Z+CHL5ctOb0XRymK40X4Mfa+Plu1I8hFTHu wADmVEPo6z+DFNWgUBSiyo5b0RIiZe8rbz2kIAVed3On/uEYqo8vPCNVHobDAzsEYlT7a8Yd MuetKE6kyvrz91fpj10/9PeyrAGaYGuSBw/FWbdjlG9nqcUsucUJAFGPHRoMTV4Eu+HSGq2R zA+UaVV3KO12vYT5QJvD1BXQGM0OuNkE+s9xkZYds1pCWAYZQlLDjzsT7BiKPXO1Y/OscNXZ YXWSS9t+SSXeDkLkwLDXqyPQBeAWPhuGQmo2X3KJo/E6+hUwHHFVuFRj4UJBg5Y6FpnYX1ks d7HTxL152FewY6qT1DDGtridjllb66MuJbB+pdu1IHmILxibTO/cKFhh0ECEtD/fW7IqoVBZ loHuhj9KiqI6gLRmb2Po4Iw+3BU8Ycnvi2rnLIkkZQBa7zt7v6ClVriSwRVWpmPBXDLh0GEC eanZs7iu/I5rYf1otIEM4wOf9w9GaYfaS/AhivhgWQ/w1zptklRZB/mOTDZCp3f8R5dLobrk +zdgT35fGkZbgOsrecFDAQC/qAlNxrHm6M5PiUawDpA1QsnLnvPzDRl790khJnCCemidH50T 2xOzl1UFKEZNx2rO7m/HfVNC2kM3Dc5MyJvNSNK7cQ== Message-ID: <57190963-22e2-cb89-bfd0-502f135237c3@puri.sm> Date: Thu, 15 Aug 2019 13:19:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 In-Reply-To: <20190815114941.GE32300@localhost> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZNMKRsShnEEY9wDWprBhCeugmdfHlBIFO" Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ZNMKRsShnEEY9wDWprBhCeugmdfHlBIFO Content-Type: multipart/mixed; boundary="AcdudyfEnMMVAUzhK5E3VomylemxqhAdu"; protected-headers="v1" From: Bob Ham To: Johan Hovold Cc: "Angus Ainslie (Purism)" , kernel@puri.sm, =?UTF-8?Q?Bj=c3=b8rn_Mork?= , "David S. Miller" , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <57190963-22e2-cb89-bfd0-502f135237c3@puri.sm> Subject: Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card References: <20190724145227.27169-1-angus@akkea.ca> <20190724145227.27169-2-angus@akkea.ca> <20190805114711.GF3574@localhost> <5fb96703-b174-eef1-5ad1-693e2bbce32f@puri.sm> <20190815114941.GE32300@localhost> In-Reply-To: <20190815114941.GE32300@localhost> --AcdudyfEnMMVAUzhK5E3VomylemxqhAdu Content-Type: text/plain; charset=windows-1252 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable On 15/08/2019 12:49, Johan Hovold wrote: > On Mon, Aug 05, 2019 at 03:44:30PM +0100, Bob Ham wrote: >> On 05/08/2019 12:47, Johan Hovold wrote: >>> On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrot= e: >>>> From: Bob Ham >>>> >>>> Add a VID:PID for the BroadModi BM818 M.2 card >>> >>> Would you mind posting the output of usb-devices (or lsusb -v) for th= is >>> device? >> >> T: Bus=3D01 Lev=3D03 Prnt=3D40 Port=3D03 Cnt=3D01 Dev#=3D 44 Spd=3D48= 0 MxCh=3D 0 >> D: Ver=3D 2.00 Cls=3D00(>ifc ) Sub=3D00 Prot=3D00 MxPS=3D64 #Cfgs=3D = 1 >> P: Vendor=3D2020 ProdID=3D2060 Rev=3D00.00 >> S: Manufacturer=3DQualcomm, Incorporated >> S: Product=3DQualcomm CDMA Technologies MSM >> C: #Ifs=3D 5 Cfg#=3D 1 Atr=3De0 MxPwr=3D500mA >> I: If#=3D0x0 Alt=3D 0 #EPs=3D 2 Cls=3Dff(vend.) Sub=3Dff Prot=3Dff Dr= iver=3D(none) >> I: If#=3D0x1 Alt=3D 0 #EPs=3D 2 Cls=3Dff(vend.) Sub=3Dff Prot=3Dff Dr= iver=3D(none) >> I: If#=3D0x2 Alt=3D 0 #EPs=3D 3 Cls=3Dff(vend.) Sub=3Dff Prot=3Dff Dr= iver=3D(none) >> I: If#=3D0x3 Alt=3D 0 #EPs=3D 3 Cls=3Dff(vend.) Sub=3Dfe Prot=3Dff Dr= iver=3D(none) >> I: If#=3D0x4 Alt=3D 0 #EPs=3D 3 Cls=3Dff(vend.) Sub=3Dff Prot=3Dff Dr= iver=3D(none) >=20 > I amended the commit message with the above, switched to > USB_DEVICE_INTERFACE_CLASS(), fixed the comment and moved the entry > to the other 0x2020 entries before applying. Sorry I should probably have mentioned this before but Angus has been on vacation, hence the silence on the other matters. Regardless, thanks. Bob --AcdudyfEnMMVAUzhK5E3VomylemxqhAdu-- --ZNMKRsShnEEY9wDWprBhCeugmdfHlBIFO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE745irA8zXATsZwYpUxfwLpX1YkEFAl1VTccACgkQUxfwLpX1 YkGCtxAAxy4zuPH4eoYKdgIFScVOHZtRnclOrlCN1ZluUXU5czb0SCk6BDekoyrd ka0VwFB4Mn+bfQokROl+2tXHoJeEPviPq82u6iWDvRwOTt/IO8Sp07AdnZfnbTd9 jNhVnSIpQLeVNVsdwG3ZVXftih4KmKID5XAEuHiyZabNrqT0yRLNOOk3rbD5pErl nT+K+nGgwlWuawMPZNwWx6k2IfEd/Bu6+23Z1cEHluDsqIzxcIgLNlUQyLato2gV cRr52pQ+0Kc1Wzg3xMNSWI9OUO0LITR80y6wfcdeDD9y8QdldsjAOGz9wq9UK3hO wdPTK2JTn2CaW1a2me8sixlWgwxAAER/Lg798U2MPEXD7jFMSkyncXD8EBjxyOw8 VTY2oge/6RWkRNJc0dK1DeKVvNLjT98IiFZ06T9U5WvTbF9r74jKf3knENacVe1u uJ+LJ7LhyjsIh+PuFecku54Xcvr6L1W54XEkcyns6PTVqCYAND8a6G3CrEdbjzBw hz50yvXFEp2UQfEdNy3eSlCkWAHhcWOT4C56rRDJSbMQ5TDo+1TFOERgSSjQYf2m Owbur3RmzuUboLwt+H4L0FD4rM0VE6Vl+Q5PuE/qLAjTJquswzjvv6bMCu2dvPLv mQvWm2J+dONjYjajT1cntP6QDIOz43cyW6bxIB4CHkvPGIK6Pl8= =/sAy -----END PGP SIGNATURE----- --ZNMKRsShnEEY9wDWprBhCeugmdfHlBIFO--