From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4EDAC4332F for ; Sun, 13 Nov 2022 18:49:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235423AbiKMStP (ORCPT ); Sun, 13 Nov 2022 13:49:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235591AbiKMSs4 (ORCPT ); Sun, 13 Nov 2022 13:48:56 -0500 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB9AC13D02 for ; Sun, 13 Nov 2022 10:48:46 -0800 (PST) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id AE3A284FB3; Sun, 13 Nov 2022 19:48:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1668365324; bh=u6LjaDcZN7FiuqGgRMUt8yy4yxHrbqA4kHRpJaldoxM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=o2NlBs8DjFfYHgVQtjQwssKNVVIc+OjnhFsvu/mUxxby8OTnaqggFQeBhkrsOzIJ/ Uzf1uR+WLKlY63yllym4UW81XxSjRj4js55P54yGDpH6WbpISySQ1gy5zJ8WOMKiEG BpQ87HroneQVj9p03su2n+xdEWeDe3GskvQV7siHQdW7oKOPSXYFFKPCv0ejq0MIA3 1VQHHqAPpVJ1fiKazJdaGa2RFyws5Nlq2S+rDsoI1ZHlOV5lgNYH1fgi8K4SlQ9HXO kQW8ztG69dvg9ZDUZ2e5UOf642Pbb+TCZVh8BBecQb3+33SsCrJg6Ui0b6H8lLeff2 Kas6CctfXvltg== Message-ID: <576b2fe7-4753-73c3-f2f1-0387da175ad9@denx.de> Date: Sun, 13 Nov 2022 19:48:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/2] extcon: usbc-tusb320: Add USB TYPE-C support To: Peter Rosin , linux-usb@vger.kernel.org Cc: Chanwoo Choi , Greg Kroah-Hartman , Heikki Krogerus , Yassine Oudjana , =?UTF-8?Q?Alvin_=c5=a0ipraga?= , regressions@lists.linux.dev References: Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 11/13/22 17:59, Peter Rosin wrote: > On Sat, Jul 30, 2022 at 08:05:00PM +0200, Marek Vasut wrote: >> The TI TUSB320 seems like a better fit for USB TYPE-C subsystem, >> which can expose details collected by the TUSB320 in a far more >> precise way than extcon. Since there are existing users in the >> kernel and in DT which depend on the extcon interface, keep it >> for now. >> >> Add TYPE-C interface and expose the supported supply current, >> direction and connector polarity via the TYPE-C interface. >> >> Signed-off-by: Marek Vasut > > Hi! > > I'm very sad to report that this patch has caused a severe > regression for our devices. They can no longer be powered by simply > sticking a USB cable into their USB ports (they keep resetting > when the tusb320 driver probes), and they reset (and keep resetting) > if a USB cable is connected while the device is powered by other > means. > > We have no connector node nor any typec-power-opmode property > in the device tree, so the mere touching of the new registers > happening in this patch is enough to cause the resets. > > The devices were fine before this patch, and reverting on top > of a recent linus master (4bbf3422df78, from 11/11) makes the > problem go away. > > Any suggestions? Can you test: 341fd15e2e18c ("extcon: usbc-tusb320: Call the Type-C IRQ handler only if a port is registered") https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-linus&id=341fd15e2e18c24d5c738496cfc3d7a272241201 ?