From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"wahrenst@gmx.net" <wahrenst@gmx.net>,
"robh@kernel.org" <robh@kernel.org>,
"mathias.nyman@linux.intel.com" <mathias.nyman@linux.intel.com>,
Eric Anholt <eric@anholt.net>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
"linux-rpi-kernel@lists.infradead.org"
<linux-rpi-kernel@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tim.gover@raspberrypi.org" <tim.gover@raspberrypi.org>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH 5/9] usb: xhci-pci: Add support for reset controllers
Date: Tue, 09 Jun 2020 13:19:57 +0200 [thread overview]
Message-ID: <582f63b8140a01e75a79c96ec569c3a68f434c61.camel@suse.de> (raw)
In-Reply-To: <CAHp75VdWq96SSzB1S9pM=H8=3np8-1Cep_9BqGiTCUTtCUt-yw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2090 bytes --]
On Mon, 2020-06-08 at 22:44 +0300, Andy Shevchenko wrote:
>
>
> On Monday, June 8, 2020, Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> wrote:
> > Some atypical users of xhci-pci might need to manually reset their xHCI
> > controller before starting the HCD setup. Check if a reset controller
> > device is available to the PCI bus and trigger a reset.
> >
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > ---
> > drivers/usb/host/xhci-pci.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index ef513c2fb843..45f70facdfcd 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> > @@ -12,6 +12,7 @@
> > #include <linux/slab.h>
> > #include <linux/module.h>
> > #include <linux/acpi.h>
> > +#include <linux/reset.h>
> >
> > #include "xhci.h"
> > #include "xhci-trace.h"
> > @@ -339,6 +340,7 @@ static int xhci_pci_probe(struct pci_dev *dev, const
> > struct pci_device_id *id)
> > struct xhci_hcd *xhci;
> > struct usb_hcd *hcd;
> > struct xhci_driver_data *driver_data;
> > + struct reset_control *reset;
> >
> > driver_data = (struct xhci_driver_data *)id->driver_data;
> > if (driver_data && driver_data->quirks & XHCI_RENESAS_FW_QUIRK) {
> > @@ -347,6 +349,13 @@ static int xhci_pci_probe(struct pci_dev *dev, const
> > struct pci_device_id *id)
> > return retval;
> > }
> >
> > + reset = devm_reset_control_get(&dev->bus->dev, NULL);
>
>
> > + if (IS_ERR(reset)) {
> > + retval = PTR_ERR(reset);
> > + return retval;
> > + }
>
> These four can be two, we have too many LOCs in the kernel for no reason.
Noted
>
> > + reset_control_reset(reset);
> > +
> > /* Prevent runtime suspending between USB-2 and USB-3 initialization
> > */
> > pm_runtime_get_noresume(&dev->dev);
> >
> > --
> > 2.26.2
> >
> >
>
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-09 11:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 19:26 [PATCH 0/9] Raspberry Pi 4 USB firmware initialization rework Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 1/9] dt-bindings: reset: Add a binding for the RPi Firmware USB reset Nicolas Saenz Julienne
2020-06-08 19:58 ` Florian Fainelli
2020-06-09 11:14 ` Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 2/9] reset: Add Raspberry Pi 4 firmware USB reset controller Nicolas Saenz Julienne
2020-06-08 20:13 ` Florian Fainelli
2020-06-08 19:26 ` [PATCH 3/9] ARM: dts: bcm2711: Add firmware usb reset node Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 4/9] ARM: dts: bcm2711: Add reset controller to xHCI node Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 5/9] usb: xhci-pci: Add support for reset controllers Nicolas Saenz Julienne
2020-06-08 19:43 ` Florian Fainelli
2020-06-09 11:18 ` Nicolas Saenz Julienne
2020-06-09 11:59 ` Philipp Zabel
2020-06-09 13:08 ` Nicolas Saenz Julienne
[not found] ` <CAHp75VdWq96SSzB1S9pM=H8=3np8-1Cep_9BqGiTCUTtCUt-yw@mail.gmail.com>
2020-06-09 11:19 ` Nicolas Saenz Julienne [this message]
2020-06-08 19:26 ` [PATCH 6/9] Revert "USB: pci-quirks: Add Raspberry Pi 4 quirk" Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 7/9] usb: host: pci-quirks: Bypass xHCI quirks for Raspberry Pi 4 Nicolas Saenz Julienne
2020-06-08 19:50 ` Florian Fainelli
2020-06-08 19:27 ` [PATCH 8/9] Revert "firmware: raspberrypi: Introduce vl805 init routine" Nicolas Saenz Julienne
2020-06-08 19:27 ` [PATCH 9/9] Revert "PCI: brcmstb: Wait for Raspberry Pi's firmware when present" Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582f63b8140a01e75a79c96ec569c3a68f434c61.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=tim.gover@raspberrypi.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).