From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA14C4338F for ; Sun, 1 Aug 2021 07:47:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CA3461057 for ; Sun, 1 Aug 2021 07:47:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231290AbhHAHrw (ORCPT ); Sun, 1 Aug 2021 03:47:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230129AbhHAHrw (ORCPT ); Sun, 1 Aug 2021 03:47:52 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F34AC06175F for ; Sun, 1 Aug 2021 00:47:43 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id d8so17492571wrm.4 for ; Sun, 01 Aug 2021 00:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nYuEnC3Pf8FReOW2KAUy+LpNV12/ud56TBR6eiy5q5g=; b=Riqio8T/S/eenFMCO07s4Rak0y9VxwCVqQ1H3Vwg6NZLmWI5QWCCBD/6mcQNEJgxX8 QlzE3MnPsCmSGFensEEZxu99K4HEDUGoh4dx4RunmigY82nmGeoOsF2rdUOX3fWaNLZW kaEDHkv75ylJVDL8W0KRsCPYM4G5tEbxblb3r7oEwzOEUWjWxMK0kp9/qTy6sJiH7OSM SatxbznqUrPOFoLDdppatO7tND7biQhc7VWIyp/0f7GVapJIEu+/GwaR3NzyKPxXNSH/ nBlRAQv2O6+YLs6/qtMq7W9xLXBBSNmzvgTxT/tQpk+lxWHj9N8+BqORD41vUXL75bcv Kvtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nYuEnC3Pf8FReOW2KAUy+LpNV12/ud56TBR6eiy5q5g=; b=WGXYz2EimDLgE8V6GlYBx/ijwXNPxFv3qVdgCgA1TmOk3rWlb8wPl372+28H32S03e glKvCuuiKgRyJ9279sPQpCcWskp5h3B6V5MRysp2sdWD0X9yQ2KL7h8L5lUGq8nZ1iZ/ sQjlR6z1Cd7+L2mbva4jzSsefy21QGCBVY/taJD7v8bsOnJTQWMKFwSmnk/4x9I4DkjQ Hd0gBprucrUOIfZA/HfhcgDKuRAtNEGlRzRYye5ThSGpTHJyUN9jL98EtlrpVNBl5Of2 4N20RlgJnTt7rDlD5EzwfHVIcd2rmIWPnvpQYfgJ81EXO4GKNKa6dANr0LwC6qa9VYSO oENA== X-Gm-Message-State: AOAM532+toNt/DwG0v+3K2bwwxZRlfKx10PthaYFuM2RI3LFc+pQeTpF yDH0Y2AOvrHsl+6NAroZwL2Zhhh5RwaR2g== X-Google-Smtp-Source: ABdhPJzg1SJOa0X0Z71XA7gXvUqAHyki173jOLV/YfmzLfyEB4lvXk0h4HXUGc3JhjC7eDHyv1CmNQ== X-Received: by 2002:a5d:4fd0:: with SMTP id h16mr11860547wrw.268.1627804062076; Sun, 01 Aug 2021 00:47:42 -0700 (PDT) Received: from [192.168.1.11] (x4db4b254.dyn.telefonica.de. [77.180.178.84]) by smtp.gmail.com with ESMTPSA id s2sm6535158wmh.46.2021.08.01.00.47.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Aug 2021 00:47:41 -0700 (PDT) Subject: Re: Lacie Rugged USB3-FW does not work with UAS From: Julian Sikorski To: Hans de Goede Cc: Oliver Neukum , Nathan Stratton Treadway , USB list References: <0eaecb64-4c67-110d-8493-31dd7fd58759@gmail.com> <1566595393.8347.56.camel@suse.com> <5f8f8e05-a29b-d868-b354-75ac48d40133@gmail.com> <1567424535.2469.11.camel@suse.com> <2a06a5dd-3fc9-0aac-a7e2-67be35e2d6bb@gmail.com> <20190904155831.GE4337@nathanst.com> <1568033125.365.17.camel@suse.com> <4c2b1c8a-4126-ccfe-3431-323c4935566e@suse.com> <56cebf15-cf9d-475f-b388-b2be723697f6@gmail.com> <830f09f8-7e16-425e-d5dc-2c5102ee4c7a@redhat.com> Message-ID: <5b6ac50e-38d5-ad28-1e1c-08264d282353@gmail.com> Date: Sun, 1 Aug 2021 09:47:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Am 01.08.21 um 09:35 schrieb Julian Sikorski: > Am 29.07.21 um 11:08 schrieb Hans de Goede: >> Hi, >> >> On 7/28/21 7:29 PM, Julian Sikorski wrote: >>> Hi all, >>> >>> f quirk alone seems to be sufficient. >> >> Thank you for testing, but I'm not sure using only the NO_REPORT_OPCODES >> quirk is wise here, the other similar La Cie drive also started out with >> just that quirk, only to have the NO_SAME quirk added later. See: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8010622c86ca5bb44bc98492f5968726fc7c7a21 >> >> >> Actually triggering a WRITE_SAME SCSI command is likely tricky, so >> it likely requires a special workload to ensure that that flag is >> not necessary. >> >> As Oliver set with the quirk to disable UAS we at least have the >> drive working (albeit slower then it would work with UAS) so we >> can take our time to make sure that things work properly with >> the combination of the f+k flags (at least using both seems >> best to me) before re-enabling UAS. >> >> Regards, >> >> Hans >> > Hi, > > are there some tests which I could run in particular to test whether > WRITE_SAME is working as intended? I use this drive for backups which > means I don't connect it all that often. > > Best regards, > Julian Hi, one more question: is there a way to force-enable UAS for testing now that the quirk has been upstreamed, other than reverting the patch and rebuilding the kernel? Best regards, Julian > >>> >>> Best regards, >>> Julian >>> >>> Julian Sikorski > >>> schrieb am Mi., 28. Juli 2021, 01:14: >>> >>>      Hi Hans, >>> >>>      apologies for top-posting and HTML but I only can send emails >>> from my mobile currently. >>>      With fk quirk the drive indeed appears to be working with uas: I >>> can decrypt and mount a veracrypt volume from it. Thanks! >>>      The patch disabling uas has already made it to Linus' tree and >>> is about to be added to stable: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6abf2fe6b4bf6e5256b80c5817908151d2d33e9f >>> >>> >>>      As I have no working internet on any of my Linux machines and >>> won't for the foreseeable future (thank you construction workers), >>> would you mind taking care of amending the quirk accordingly? Thank >>> you in advance. >>> >>>      Best regards, >>>      Julian >>> >>> >>>      Hans de Goede > >>> schrieb am Di., 27. Juli 2021, 23:19: >>> >>>          Hi, >>> >>>          On 7/19/21 6:10 PM, Julian Sikorski wrote: >>>          > W dniu 19.07.2021 o 14:47, Oliver Neukum pisze: >>>          >> >>>          >>> Hi all, >>>          >>> >>>          >>> apologies for necro-ing this thread. I have just tried >>> this drive with >>>          >>> my new laptop (Asus ZenBook UM425IA) and the same quirk >>> was needed to >>>          >>> get the drive to work: >>>          >>> options usb-storage quirks=059f:1061:u >>>          >>> >>>          >>> Should we still try to get uas working with this drive >>> or should I >>>          >>> send a patch hardcoding a quirk? I am on >>> 5.13.2-300.fc34.x86_64 kernel >>>          >>> now. Thanks for the feedback in advance. >>>          >>> >>>          >> >>>          >> Hi, >>>          >> >>>          >> >>>          >> sometimes we must give up. This thing is too elusive. >>> Please send a >>>          >> patch with a quirk. >>>          >> >>>          >>      Regards >>>          >> >>>          >>          Oliver >>>          >> >>>          >> >>>          > >>>          > Hi, >>>          > >>>          > thanks for confirming. Patch is attached, it appears to be >>> working correctly when applied against 5.13.3. Please let me know if >>> changes are required. >>> >>>          I seem to have missed the earlier part of this thread somehow. >>> >>>          Looking at the USB-ids, your model seems mightily close to >>> this existing quirk: >>> >>>          UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999, >>>                          "LaCie", >>>                          "2Big Quadra USB3", >>>                          USB_SC_DEVICE, USB_PR_DEVICE, NULL, >>>                          US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME), >>> >>>          Before we go with the suggested patch, can you give the uas >>> driver one last >>>          try with: >>> >>>          options usb-storage quirks=059f:1061:fk >>> >>>          ? The fk translates like this: >>> >>>          f -> US_FL_NO_REPORT_OPCODES >>>          k -> US_FL_NO_SAME >>> >>>          Regards, >>> >>>          Hans >>> >>