From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B0ACC3A59B for ; Fri, 30 Aug 2019 16:02:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 714B02341B for ; Fri, 30 Aug 2019 16:02:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DVNT4sGr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728361AbfH3QCB (ORCPT ); Fri, 30 Aug 2019 12:02:01 -0400 Received: from mail-pl1-f175.google.com ([209.85.214.175]:36349 "EHLO mail-pl1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728236AbfH3QCB (ORCPT ); Fri, 30 Aug 2019 12:02:01 -0400 Received: by mail-pl1-f175.google.com with SMTP id f19so3572332plr.3 for ; Fri, 30 Aug 2019 09:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:cc:subject:to:from:user-agent:date; bh=Ll00P0HvLyh9ff4mGqhoY7oNmqZV/WIp9ZbBt7WSZuQ=; b=DVNT4sGrKS8uBzpUvPlrwNcWOB48ID/E33wWVXKNaf5Rn1vgh5+t2kQyuqrFOdqw8j 2YmAmtzGl93QBYkr5aUtVLO4FEmveVBcPhwSjMHjKvnQY3WFEPGdEkGAlL/QNiRxAde0 9vR6xABOTJ0qzHXur+j0+MpQAv4Et4E71ZHUg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:cc:subject:to:from :user-agent:date; bh=Ll00P0HvLyh9ff4mGqhoY7oNmqZV/WIp9ZbBt7WSZuQ=; b=B9CfwSVWIISLmohyJodsQ5BksuAQvXELIgfQiVasu+IQXuGrqzImfR7Av+Mca7oTRu LKxsqkfi+dfRVl4P61fhJ/gaJCHEmiSdZW+mbCZjg/29qzNaTVTPy8XVc+zGXem+qVob jri1dhIz9ndXQrAdnqKrx5Lqc4sYzXp+VGmdGN3bushQseiEqkbK0YQvTeRKS+mfwLNE pytTXcBx5NUstiS/sCm3lL1nAz4kcfrB07S5DuxBHmY2YGraLRf5JhGRyHvMjKhFKsiq yYzFezFvQ13QsgktmSbF4dedq/8E/bCwkkVTA4zG/XDsTrRXJvPCZD1memHFoIQwAD8m riVw== X-Gm-Message-State: APjAAAUq7UMOGJmYJn30EuOZ3ClmEIHf+IZ5I3RVvbP3mRDJs/ubRe57 oEe87bOSm4bHN/sGKunLTKuovg== X-Google-Smtp-Source: APXvYqxBQB8qqHi4xILIYQH7twNKrk/p0gZaksrJaQi2G+n2F2uAcIBYTnbtvlcNY1uzFyMjBAQ7Rg== X-Received: by 2002:a17:902:223:: with SMTP id 32mr16796973plc.220.1567180920622; Fri, 30 Aug 2019 09:02:00 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id t70sm5846917pjb.2.2019.08.30.09.01.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2019 09:02:00 -0700 (PDT) Message-ID: <5d694878.1c69fb81.5f13b.ec4f@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <6dc0957d-5806-7643-4454-966015865d38@linaro.org> References: <20190207111734.24171-1-jorge.ramirez-ortiz@linaro.org> <20190207111734.24171-4-jorge.ramirez-ortiz@linaro.org> <20190223165218.GB572@tuxbook-pro> <6dc0957d-5806-7643-4454-966015865d38@linaro.org> Cc: robh@kernel.org, andy.gross@linaro.org, shawn.guo@linaro.org, gregkh@linuxfoundation.org, mark.rutland@arm.com, kishon@ti.com, jackp@codeaurora.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, khasim.mohammed@linaro.org Subject: Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings To: Bjorn Andersson , Jorge Ramirez From: Stephen Boyd User-Agent: alot/0.8.1 Date: Fri, 30 Aug 2019 09:01:59 -0700 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Quoting Jorge Ramirez (2019-08-29 00:03:48) > On 2/23/19 17:52, Bjorn Andersson wrote: > > On Thu 07 Feb 03:17 PST 2019, Jorge Ramirez-Ortiz wrote: > >> + > >> +Required child nodes: > >> + > >> +- usb connector node as defined in bindings/connector/usb-connector.t= xt > >> + containing the property vbus-supply. > >> + > >> +Example: > >> + > >> +usb3_phy: usb3-phy@78000 { > >> + compatible =3D "qcom,snps-usb-ssphy"; > >> + reg =3D <0x78000 0x400>; > >> + #phy-cells =3D <0>; > >> + clocks =3D <&rpmcc RPM_SMD_LN_BB_CLK>, > >> + <&gcc GCC_USB_HS_PHY_CFG_AHB_CLK>, > >> + <&gcc GCC_USB3_PHY_PIPE_CLK>; > >> + clock-names =3D "ref", "phy", "pipe"; > >> + resets =3D <&gcc GCC_USB3_PHY_BCR>, > >> + <&gcc GCC_USB3PHY_PHY_BCR>; > >> + reset-names =3D "com", "phy"; > >> + vdd-supply =3D <&vreg_l3_1p05>; > >> + vdda1p8-supply =3D <&vreg_l5_1p8>; > >> + usb3_c_connector: usb3-c-connector { Node name should be 'connector', not usb3-c-connector. > >=20 > > The USB-C connector is attached both to the HS and SS PHYs, so I think > > you should represent this external to this node and use of_graph to > > query it. >=20 > but AFAICS we wont be able to retrieve the vbux-supply from an external > node (that interface does not exist). >=20 > rob, do you have a suggestion? Shouldn't the vbus supply be in the phy? Or is this a situation where the phy itself doesn't have the vbus supply going to it because the PMIC gets in the way and handles the vbus for the connector by having the SoC communicate with the PMIC about when to turn the vbus on and off, etc? >=20 > >=20 > > So the connector should look similar to example 2 in > > connector/usb-connector.txt. > >=20 > > Regards, > > Bjorn > >=20 > >> + compatible =3D "usb-c-connector"; > >> + label =3D "USB-C"; > >> + type =3D "micro"; > >> + vbus-supply =3D <&usb3_vbus_reg>; > >> + }; > >> +};