From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
cernekee@gmail.com, balbi@kernel.org
Cc: gregkh@linuxfoundation.org, f.fainelli@gmail.com,
bcm-kernel-feedback-list@broadcom.com, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: bcm63xx_udc:remove useless variable definition
Date: Tue, 24 Mar 2020 11:35:35 +0300 [thread overview]
Message-ID: <5f67315d-18c1-e444-03e7-a79a21d48b02@cogentembedded.com> (raw)
In-Reply-To: <20200324062932.8364-1-tangbin@cmss.chinamobile.com>
Hello!
On 24.03.2020 9:29, Tang Bin wrote:
> In this function, the variable 'rc' is assigned after this place,
> so the definition is invalid.
What definition? Did you mean assignment?
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/usb/gadget/udc/bcm63xx_udc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c b/drivers/usb/gadget/udc/bcm63xx_udc.c
> index 54501814d..a7afa8c35 100644
> --- a/drivers/usb/gadget/udc/bcm63xx_udc.c
> +++ b/drivers/usb/gadget/udc/bcm63xx_udc.c
> @@ -2321,8 +2321,6 @@ static int bcm63xx_udc_probe(struct platform_device *pdev)
> if (rc)
> return rc;
>
> - rc = -ENXIO;
> -
> /* IRQ resource #0: control interrupt (VBUS, speed, etc.) */
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
MBR, Sergei
next prev parent reply other threads:[~2020-03-24 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 6:29 [PATCH] usb: gadget: bcm63xx_udc:remove useless variable definition Tang Bin
2020-03-24 8:35 ` Sergei Shtylyov [this message]
[not found] ` <202003241719218101862@cmss.chinamobile.com>
2020-03-24 11:06 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f67315d-18c1-e444-03e7-a79a21d48b02@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cernekee@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).