From: yebin <yebin10@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <valentina.manea.m@gmail.com>, <shuah@kernel.org>,
<linux-usb@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<hulkci@huawei.com>
Subject: Re: [PATCH -next v2] usbip: vudc: fix missing unlock on error in usbip_sockfd_store()
Date: Mon, 12 Apr 2021 15:00:03 +0800 [thread overview]
Message-ID: <6073EFF3.90506@huawei.com> (raw)
In-Reply-To: <YHBe9m7wGqlZ2cp+@kroah.com>
Sorry. I build kernel image with follow config and commit base on
linux-next:
commit：e99d8a849517
config: make allmodconfig
I can build kernel image without errors. So, what build error did you
encounter?
On 2021/4/9 22:04, Greg KH wrote:
> On Thu, Apr 08, 2021 at 07:23:05PM +0800, Ye Bin wrote:
>> Add the missing unlock before return from function usbip_sockfd_store()
>> in the error handling case.
>>
>> Fixes: bd8b82042269 ("usbip: vudc synchronize sysfs code paths")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Ye Bin <yebin10@huawei.com>
>> ---
>> drivers/usb/usbip/vudc_sysfs.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c
>> index f7633ee655a1..d1cf6b51bf85 100644
>> --- a/drivers/usb/usbip/vudc_sysfs.c
>> +++ b/drivers/usb/usbip/vudc_sysfs.c
>> @@ -156,12 +156,14 @@ static ssize_t usbip_sockfd_store(struct device *dev,
>> tcp_rx = kthread_create(&v_rx_loop, &udc->ud, "vudc_rx");
>> if (IS_ERR(tcp_rx)) {
>> sockfd_put(socket);
>> + mutex_unlock(&udc->ud.sysfs_lock);
>> return -EINVAL;
>> }
>> tcp_tx = kthread_create(&v_tx_loop, &udc->ud, "vudc_tx");
>> if (IS_ERR(tcp_tx)) {
>> kthread_stop(tcp_rx);
>> sockfd_put(socket);
>> + mutex_unlock(&udc->ud.sysfs_lock);
>> return -EINVAL;
>> }
>>
>> --
>> 2.25.4
>>
> This breaks the build, are you sure you tested it???
>
> .
>
next prev parent reply other threads:[~2021-04-12 7:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 11:23 [PATCH -next v2] usbip: vudc: fix missing unlock on error in usbip_sockfd_store() Ye Bin
2021-04-08 15:14 ` Shuah Khan
2021-04-09 14:04 ` Greg KH
2021-04-12 7:00 ` yebin [this message]
2021-04-12 8:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6073EFF3.90506@huawei.com \
--to=yebin10@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).