Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

From: Roger Quadros <rogerq@ti.com>
To: Pawel Laszczak <pawell@cadence.com>, <felipe.balbi@linux.intel.com>
Cc: <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <jbergsagel@ti.com>,
	<nsekhar@ti.com>, <nm@ti.com>, <sureshp@cadence.com>,
	<peter.chen@nxp.com>, <kurahul@cadence.com>
Subject: Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.
Date: Mon, 7 Oct 2019 11:40:15 +0300	[thread overview]
Message-ID: <640b6cd2-5d10-2dbd-c74d-009747790633@ti.com> (raw)
In-Reply-To: <1570430355-26118-1-git-send-email-pawell@cadence.com>


On 07/10/2019 09:39, Pawel Laszczak wrote:
> Patch fixes issue with Halt Endnpoint Test observed during using g_zero
> driver as DUT. Bug occurred only on some testing board.
> 
> Endpoint can defer transition to Halted state if endpoint has pending
> requests.
> Patch add additional condition that allows to return correct endpoint
> status during Get Endpoint Status request even if the halting endpoint
> is in progress.
> 
> Reported-by: Rahul Kumar <kurahul@cadence.com>
> Signed-off-by: Rahul Kumar <kurahul@cadence.com>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")

Tested-by: Roger Quadros <rogerq@ti.com>


cheers,
-roger

> ---
>   drivers/usb/cdns3/ep0.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/ep0.c b/drivers/usb/cdns3/ep0.c
> index 44f652e8b5a2..10ae03430f34 100644
> --- a/drivers/usb/cdns3/ep0.c
> +++ b/drivers/usb/cdns3/ep0.c
> @@ -234,9 +234,11 @@ static int cdns3_req_ep0_set_address(struct cdns3_device *priv_dev,
>   static int cdns3_req_ep0_get_status(struct cdns3_device *priv_dev,
>   				    struct usb_ctrlrequest *ctrl)
>   {
> +	struct cdns3_endpoint *priv_ep;
>   	__le16 *response_pkt;
>   	u16 usb_status = 0;
>   	u32 recip;
> +	u8 index;
>   
>   	recip = ctrl->bRequestType & USB_RECIP_MASK;
>   
> @@ -262,9 +264,13 @@ static int cdns3_req_ep0_get_status(struct cdns3_device *priv_dev,
>   	case USB_RECIP_INTERFACE:
>   		return cdns3_ep0_delegate_req(priv_dev, ctrl);
>   	case USB_RECIP_ENDPOINT:
> -		/* check if endpoint is stalled */
> +		index = cdns3_ep_addr_to_index(ctrl->wIndex);
> +		priv_ep = priv_dev->eps[index];
> +
> +		/* check if endpoint is stalled or stall is pending */
>   		cdns3_select_ep(priv_dev, ctrl->wIndex);
> -		if (EP_STS_STALL(readl(&priv_dev->regs->ep_sts)))
> +		if (EP_STS_STALL(readl(&priv_dev->regs->ep_sts)) ||
> +		    (priv_ep->flags & EP_STALL_PENDING))
>   			usb_status =  BIT(USB_ENDPOINT_HALT);
>   		break;
>   	default:
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki