From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC1B9C433F5 for ; Tue, 11 Oct 2022 18:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229748AbiJKSjM (ORCPT ); Tue, 11 Oct 2022 14:39:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbiJKSjL (ORCPT ); Tue, 11 Oct 2022 14:39:11 -0400 X-Greylist: delayed 62 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 11 Oct 2022 11:39:10 PDT Received: from mailfilter02-out41.webhostingserver.nl (mailfilter02-out41.webhostingserver.nl [141.138.168.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75BF35A809 for ; Tue, 11 Oct 2022 11:39:10 -0700 (PDT) X-Halon-ID: d82bad68-4993-11ed-be53-001a4a4cb922 Received: from s198.webhostingserver.nl (s198.webhostingserver.nl [141.138.168.154]) by mailfilter02.webhostingserver.nl (Halon) with ESMTPSA id d82bad68-4993-11ed-be53-001a4a4cb922; Tue, 11 Oct 2022 20:38:05 +0200 (CEST) Received: from 2a02-a466-68ed-1-d9fe-da5d-3465-7be0.fixed6.kpn.net ([2a02:a466:68ed:1:d9fe:da5d:3465:7be0]) by s198.webhostingserver.nl with esmtpa (Exim 4.96) (envelope-from ) id 1oiK8j-004rfb-0w; Tue, 11 Oct 2022 20:38:05 +0200 Message-ID: <644adb7b-0438-e37c-222c-71bf261369b0@gmail.com> Date: Tue, 11 Oct 2022 20:38:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2 2/2] Revert "usb: dwc3: Don't switch OTG -> peripheral if extcon is present" Content-Language: en-US To: Andrey Smirnov Cc: Thinh Nguyen , Andy Shevchenko , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Felipe Balbi , "stable@vger.kernel.org" References: <20220927155332.10762-1-andriy.shevchenko@linux.intel.com> <20220927155332.10762-3-andriy.shevchenko@linux.intel.com> <20221003215734.7l3cnb2zy57nrxkk@synopsys.com> <20221005021212.qwnbmq6p7t26c3a4@synopsys.com> <2886b82d-a1f6-d288-e8d1-edae54046b4f@gmail.com> <20221006021204.hz7iteao65dgsev6@synopsys.com> <20221007021122.nnwmqc6sq43e5xbn@synopsys.com> <4e73bbb9-eae1-6a90-d716-c721a1eeced3@gmail.com> <7e9519c6-f65f-5f83-1d17-a3510103469f@gmail.com> From: Ferry Toth In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus-Scanner: Clean mail though you should still use an Antivirus Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, Op 10-10-2022 om 23:35 schreef Andrey Smirnov: > On Mon, Oct 10, 2022 at 1:52 PM Ferry Toth wrote: >> >> Hi >> >> Op 10-10-2022 om 13:04 schreef Ferry Toth: >>> Hi >>> >>> On 10-10-2022 07:02, Andrey Smirnov wrote: >>>> On Fri, Oct 7, 2022 at 6:07 AM Ferry Toth wrote: >>>>> >>>>> On 07-10-2022 04:11, Thinh Nguyen wrote: >>>>>> On Thu, Oct 06, 2022, Ferry Toth wrote: >>>>>>> Hi >>>>>>> >>>>>>> On 06-10-2022 04:12, Thinh Nguyen wrote: >>>>>>>> On Wed, Oct 05, 2022, Ferry Toth wrote: >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Thanks! >>>>>>>>> >>>>>>>>> Does the failure only happen the first time host is >>>>>>>>> initialized? Or can >>>>>>>>> it recover after switching to device then back to host mode? >>>>>>>>> >>>>>>>>> I can switch back and forth and device mode works each time, >>>>>>>>> host mode remains >>>>>>>>> dead. >>>>>>>> Ok. >>>>>>>> >>>>>>>>> Probably the failure happens if some step(s) in >>>>>>>>> dwc3_core_init() hasn't >>>>>>>>> completed. >>>>>>>>> >>>>>>>>> tusb1210 is a phy driver right? The issue is probably >>>>>>>>> because we didn't >>>>>>>>> initialize the phy yet. So, I suspect placing >>>>>>>>> dwc3_get_extcon() after >>>>>>>>> initializing the phy will probably solve the dependency >>>>>>>>> problem. >>>>>>>>> >>>>>>>>> You can try something for yourself or I can provide >>>>>>>>> something to test >>>>>>>>> later if you don't mind (maybe next week if it's ok). >>>>>>>>> >>>>>>>>> Yes, the code move I mentioned above "moves dwc3_get_extcon() >>>>>>>>> until after >>>>>>>>> dwc3_core_init() but just before dwc3_core_init_mode(). AFAIU >>>>>>>>> initially >>>>>>>>> dwc3_get_extcon() was called from within dwc3_core_init_mode() >>>>>>>>> but only for >>>>>>>>> case USB_DR_MODE_OTG. So with this change order of events is >>>>>>>>> more or less >>>>>>>>> unchanged" solves the issue. >>>>>>>>> >>>>>>>> I saw the experiment you did from the link you provided. We want >>>>>>>> to also >>>>>>>> confirm exactly which step in dwc3_core_init() was needed. >>>>>>> Ok. I first tried the code move suggested by Andrey (didn't work). >>>>>>> Then >>>>>>> after reading the actual code I moved a bit further. >>>>>>> >>>>>>> This move was on top of -rc6 without any reverts. I did not make >>>>>>> additional >>>>>>> changes to dwc3_core_init() >>>>>>> >>>>>>> So current v6.0 has: dwc3_get_extcon - dwc3_get_dr_mode - ... - >>>>>>> dwc3_core_init - .. - dwc3_core_init_mode (not working) >>>>>>> >>>>>>> I changed to: dwc3_get_dr_mode - dwc3_get_extcon - .. - >>>>>>> dwc3_core_init - .. >>>>>>> - dwc3_core_init_mode (no change) >>>>>>> >>>>>>> Then to: dwc3_get_dr_mode - .. - dwc3_core_init - .. - >>>>>>> dwc3_get_extcon - >>>>>>> dwc3_core_init_mode (works) >>>>>>> >>>>>>> .. are what I believe for this issue irrelevant calls to >>>>>>> dwc3_alloc_scratch_buffers, dwc3_check_params and dwc3_debugfs_init. >>>>>>> >>>>>> Right. Thanks for narrowing it down. There are still many steps in >>>>>> dwc3_core_init(). We have some suspicion, but we still haven't >>>>>> confirmed >>>>>> the exact cause of the failure. We can write a proper patch once we >>>>>> know >>>>>> the reason. >>>>> If you would like me to test your suspicion, just tell me what to do >>>>> :-) >>>> >>>> OK, Ferry, I think I'm going to need clarification on specifics on >>>> your test setup. Can you share your kernel config, maybe your >>>> "/proc/config.gz", somewhere? When you say you are running vanilla >>>> Linux, do you mean it or do you mean vanilla tree + some patch delta? >>> >>> For v6.0 I can get the exacts tonight. But earlier I had this for v5.17: >>> >>> https://github.com/htot/meta-intel-edison/blob/master/meta-intel-edison-bsp/recipes-kernel/linux/linux-yocto_5.17.bb >>> >>> >>> There are 2 patches referred in #67 and #68. One is related to the >>> infinite loop. The other is I believe also needed to get dwc3 to work. >>> >>> All the kernel config are applied as .cfg. >>> >>> Patches and cfs's here: >>> >>> https://github.com/htot/meta-intel-edison/tree/master/meta-intel-edison-bsp/recipes-kernel/linux/files >>> >> >> Updated Yocto recipe for v6.0 here: >> >> https://github.com/htot/meta-intel-edison/blob/honister/meta-intel-edison-bsp/recipes-kernel/linux/linux-yocto_6.0.bb >> >> #75-#77 are the 2 reverts from Andy, + one SOF revert (not related to >> this thread). > > Please drop all of this > https://github.com/htot/meta-intel-edison/blob/honister/meta-intel-edison-bsp/recipes-kernel/linux/linux-yocto_6.0.bb#L69-L77 > and re do the testing. Assuming things are still broken, that's how > you want to do the bisecting. I removed 4 patches: 0043b-TODO-driver-core-Break-infinite-loop-when-deferred-p.patch 0044-REVERTME-usb-dwc3-gadget-skip-endpoints-ep-18-in-out.patch 0001-Revert-USB-fixup-for-merge-issue-with-usb-dwc3-Don-t.patch 0001-Revert-usb-dwc3-Don-t-switch-OTG-peripheral-if-extco.patch and indeed as you expect kernel boots (no infinite loop). However dwc3 host mode is not working as in your case, device mode works fine (Yocto configures a set of gadgets for me). Just to be sure if I could have bisected without 0043a I added back the 2 0001-Revert* and indeed I run into the infinite loop with the console spitting out continuous: debugfs: Directory 'dwc3.0.auto' with parent 'ulpi' already present! tusb1210 dwc3.0.auto.ulpi: error -110 writing val 0x41 to reg 0x80 so yes it seems either 0043b or your patch "usb: dwc3: Don't switch OTG -> peripheral if extcon is present" is needed to boot (break the infinite loop). But your patch is in my case not sufficient to make host mode work. As I understand it depends a bit on the timing, I might have a different initrd (built by Yocto vs. Buildroot). F.i. I see I have extcon-intel-mrfld in initrd and dwc3 / phy-tusb1210 built-in.