From: Roger Quadros <rogerq@kernel.org>
To: Thinh.Nguyen@synopsys.com
Cc: gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
vigneshr@ti.com, srk@ti.com, r-gunasekaran@ti.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] usb: dwc3-am62: Fix up wake-up configuration and spurious wake up
Date: Mon, 20 Mar 2023 10:24:17 +0200 [thread overview]
Message-ID: <64adaa25-9179-3805-8d71-38418dc1bd54@kernel.org> (raw)
In-Reply-To: <20230316131226.89540-4-rogerq@kernel.org>
Hi,
On 16/03/2023 15:12, Roger Quadros wrote:
> Explicitly set and clear wakeup config so we don't leave anything
> to chance.
>
> Clear wakeup status on suspend so we know what caused wake up.
>
> The LINESTATE wake up should not be enabled in device mode
> if we are not connected to a USB host else it will cause spurious
> wake up.
>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
> drivers/usb/dwc3/dwc3-am62.c | 32 ++++++++++++++++++++++----------
> 1 file changed, 22 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-am62.c
> index 859b48279658..af0524e2f1e1 100644
> --- a/drivers/usb/dwc3/dwc3-am62.c
> +++ b/drivers/usb/dwc3/dwc3-am62.c
> @@ -60,6 +60,13 @@
> #define USBSS_WAKEUP_CFG_SESSVALID_EN BIT(1)
> #define USBSS_WAKEUP_CFG_VBUSVALID_EN BIT(0)
>
> +#define USBSS_WAKEUP_CFG_ALL (USBSS_WAKEUP_CFG_VBUSVALID_EN | \
> + USBSS_WAKEUP_CFG_SESSVALID_EN | \
> + USBSS_WAKEUP_CFG_LINESTATE_EN | \
> + USBSS_WAKEUP_CFG_OVERCURRENT_EN)
> +
> +#define USBSS_WAKEUP_CFG_NONE 0
> +
> /* WAKEUP STAT register bits */
> #define USBSS_WAKEUP_STAT_OVERCURRENT BIT(4)
> #define USBSS_WAKEUP_STAT_LINESTATE BIT(3)
> @@ -103,6 +110,7 @@ struct dwc3_data {
> struct regmap *syscon;
> unsigned int offset;
> unsigned int vbus_divider;
> + u32 wakeup_stat;
> };
>
> static const int dwc3_ti_rate_table[] = { /* in KHZ */
> @@ -294,6 +302,7 @@ static int dwc3_ti_suspend_common(struct device *dev)
> {
> struct dwc3_data *data = dev_get_drvdata(dev);
> u32 reg, current_prtcap_dir;
> + u32 vbus_stat;
>
> if (device_may_wakeup(dev)) {
> reg = dwc3_ti_readl(data, USBSS_CORE_STAT);
> @@ -302,12 +311,20 @@ static int dwc3_ti_suspend_common(struct device *dev)
> /* Set wakeup config enable bits */
> reg = dwc3_ti_readl(data, USBSS_WAKEUP_CONFIG);
> if (current_prtcap_dir == DWC3_GCTL_PRTCAP_HOST) {
> - reg |= USBSS_WAKEUP_CFG_LINESTATE_EN | USBSS_WAKEUP_CFG_OVERCURRENT_EN;
> + reg = USBSS_WAKEUP_CFG_LINESTATE_EN | USBSS_WAKEUP_CFG_OVERCURRENT_EN;
> } else {
> - reg |= USBSS_WAKEUP_CFG_OVERCURRENT_EN | USBSS_WAKEUP_CFG_LINESTATE_EN |
> - USBSS_WAKEUP_CFG_VBUSVALID_EN;
> + reg = USBSS_WAKEUP_CFG_VBUSVALID_EN | USBSS_WAKEUP_CFG_SESSVALID_EN;
> + /*
> + * Enable LINESTATE wake up only if connected to bus else
> + * it causes spurious wake-up.
> + */
> + vbus_stat = dwc3_ti_readl(data, USBSS_VBUS_STAT);
> + if (vbus_stat & (USBSS_VBUS_STAT_SESSVALID | USBSS_VBUS_STAT_VBUSVALID))
> + reg |= USBSS_WAKEUP_CFG_LINESTATE_EN;
There is one corner case where a spurious wake-up still happens.
i.e. If we are not in USB_SUSPEND state while entering SoC sleep.
So looks like we need to check if we are in USB SUSPEND before enabling
LINESTATE wakeup enable.
> }
> dwc3_ti_writel(data, USBSS_WAKEUP_CONFIG, reg);
> + /* clear wakeup status so we know what caused the wake up */
> + dwc3_ti_writel(data, USBSS_WAKEUP_STAT, USBSS_WAKEUP_STAT_CLR);
> }
>
> clk_disable_unprepare(data->usb2_refclk);
> @@ -324,16 +341,11 @@ static int dwc3_ti_resume_common(struct device *dev)
>
> if (device_may_wakeup(dev)) {
> /* Clear wakeup config enable bits */
> - reg = dwc3_ti_readl(data, USBSS_WAKEUP_CONFIG);
> - reg &= ~(USBSS_WAKEUP_CFG_OVERCURRENT_EN | USBSS_WAKEUP_CFG_LINESTATE_EN |
> - USBSS_WAKEUP_CFG_VBUSVALID_EN);
> - dwc3_ti_writel(data, USBSS_WAKEUP_CONFIG, reg);
> + dwc3_ti_writel(data, USBSS_WAKEUP_CONFIG, USBSS_WAKEUP_CFG_NONE);
> }
>
> reg = dwc3_ti_readl(data, USBSS_WAKEUP_STAT);
> - /* Clear the wakeup status with wakeup clear bit */
> - reg |= USBSS_WAKEUP_STAT_CLR;
> - dwc3_ti_writel(data, USBSS_WAKEUP_STAT, reg);
> + data->wakeup_stat = reg;
>
> return 0;
> }
cheers,
-roger
next prev parent reply other threads:[~2023-03-20 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 13:12 [PATCH 0/3] usb: dwc3-am62: Add system wake-up support Roger Quadros
2023-03-16 13:12 ` [PATCH 1/3] usb: dwc3-am62: Add support for system wakeup based on USB events Roger Quadros
2023-03-16 13:12 ` [PATCH 2/3] usb: dwc3-am62: Enable as a wakeup source by default Roger Quadros
2023-03-16 13:12 ` [PATCH 3/3] usb: dwc3-am62: Fix up wake-up configuration and spurious wake up Roger Quadros
2023-03-20 8:24 ` Roger Quadros [this message]
2023-03-23 18:18 ` Greg KH
2023-03-23 19:41 ` Roger Quadros
2023-03-24 11:44 ` [PATCH v2] " Roger Quadros
2023-03-24 18:36 ` Thinh Nguyen
2023-03-17 21:03 ` [PATCH 0/3] usb: dwc3-am62: Add system wake-up support Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64adaa25-9179-3805-8d71-38418dc1bd54@kernel.org \
--to=rogerq@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=r-gunasekaran@ti.com \
--cc=srk@ti.com \
--cc=stern@rowland.harvard.edu \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).