Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To: Otavio Salvador <otavio.salvador@ossystems.com.br>,
	Otavio Salvador <otavio@ossystems.com.br>
Cc: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Felipe Balbi <balbi@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
	"linux-rockchip@lists.infradead.org" 
	<linux-rockchip@lists.infradead.org>,
	Johan Hovold <johan@kernel.org>
Subject: Re: USB DWC2 stops responding when insert/remove cable multiple times
Date: Fri, 28 Feb 2020 09:01:25 +0000
Message-ID: <665fe49e-ebfa-bcb0-fcd1-ea1e9252b306@synopsys.com> (raw)
In-Reply-To: <CAP9ODKoRuB-nyjr1ksGU61PVMjFTMMWKwgpHQ=e7bChAu5Okhg@mail.gmail.com>

Hi Otavio,

On 2/21/2020 6:07 PM, Otavio Salvador wrote:
> On Fri, Feb 21, 2020 at 11:06 AM Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> On Fri, Feb 21, 2020 at 3:52 AM Minas Harutyunyan
>> <Minas.Harutyunyan@synopsys.com> wrote:
>>> On 2/20/2020 5:16 PM, Otavio Salvador wrote:
>>>> Hello Minas,
>>>>
>>>> Thanks for all your help on this, ...
>>>>
>>>> On Thu, Feb 20, 2020 at 3:59 AM Minas Harutyunyan
>>>> <Minas.Harutyunyan@synopsys.com> wrote:
>>>>>
>>>>> On 2/19/2020 7:10 PM, Otavio Salvador wrote:
>>>> ...
>>>>>> What sequence do you want us to do?
>>>>>
>>> Please provide dwc2 debug log when stop working with g_serial exception
>>> dump inside.
>>> Also provide dwc2 log when it's work without issue.
>>
>> Attached.
> 
Reviewed all logs. Not found any dwc2 related issue. Not able to 
reproduce on my setup. My log on rmmod g_serial:

[68784.817773] g_serial gadget: reset config
[68784.817775] g_serial gadget: acm ttyGS0 deactivated
[68784.817779] dwc2 dwc2.1.auto: dwc2_hsotg_ep_disable(ep 000000005e9ae420)
[68784.817784] dwc2 dwc2.1.auto: dwc2_hsotg_ep_disable: DxEPCTL=0x08080200
[68784.817791] dwc2 dwc2.1.auto: dwc2_hsotg_ep_disable(ep 00000000e6730f2b)
[68784.817796] dwc2 dwc2.1.auto: dwc2_hsotg_ep_disable: DxEPCTL=0x08880200
[68784.817805] dwc2 dwc2.1.auto: dwc2_hsotg_ep_disable(ep 00000000cef05e9b)
[68784.817809] dwc2 dwc2.1.auto: dwc2_hsotg_ep_disable: DxEPCTL=0x084c000a
[68784.817820] g_serial gadget: acm ttyGS0 deactivated
[68784.817894] usb 5-4: USB disconnect, device number 6
[68784.817975] dwc2 dwc2.1.auto: dwc2_hsotg_ep_disable(ep 00000000e6730f2b)
[68784.817980] dwc2 dwc2.1.auto: dwc2_hsotg_ep_disable: DxEPCTL=0x088a0200

Pay attention g_serial twice performing ttySG0 deactivation.
In my setup second deactivation passed Ok, but in your case exception 
back trace print out with NULL pointer de-reference on spin_lock_irq. 
Could you please add debug print before spin_lock_irq() in function 
gs_close() in file u_serial.c to check tty, tty->driver_data. Are these 
vars NULL or no.
Just rmmod g_serial case fully enough.

Thanks,
Minas

> Forgot to attach the files.
> 

  parent reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 13:40 Otavio Salvador
2020-02-17  8:58 ` Minas Harutyunyan
2020-02-17 12:30   ` Otavio Salvador
2020-02-17 13:26     ` Minas Harutyunyan
2020-02-17 19:53       ` Otavio Salvador
2020-02-19 12:26         ` Minas Harutyunyan
2020-02-19 15:10           ` Otavio Salvador
2020-02-20  6:59             ` Minas Harutyunyan
2020-02-20 13:16               ` Otavio Salvador
2020-02-21  6:52                 ` Minas Harutyunyan
2020-02-21 14:06                   ` Otavio Salvador
     [not found]                     ` <CAP9ODKoRuB-nyjr1ksGU61PVMjFTMMWKwgpHQ=e7bChAu5Okhg@mail.gmail.com>
2020-02-28  9:01                       ` Minas Harutyunyan [this message]
2020-02-28 17:35                         ` Otavio Salvador
2020-03-05  6:45                           ` Minas Harutyunyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=665fe49e-ebfa-bcb0-fcd1-ea1e9252b306@synopsys.com \
    --to=minas.harutyunyan@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=johan@kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=otavio.salvador@ossystems.com.br \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git