Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Ajay Gupta <ajayg@nvidia.com>, linux-usb@vger.kernel.org
Subject: Re: [PATCH v4 17/18] usb: typec: ucsi: New error codes
Date: Mon, 4 Nov 2019 06:41:38 -0800
Message-ID: <6f7d180f-dcdd-1014-65e0-2c757042eec9@roeck-us.net> (raw)
In-Reply-To: <20191104142435.29960-18-heikki.krogerus@linux.intel.com>

On 11/4/19 6:24 AM, Heikki Krogerus wrote:
> Adding new error codes to the driver that were introduced in
> UCSI specification v1.1.
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Tested-by: Ajay Gupta <ajayg@nvidia.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/usb/typec/ucsi/ucsi.c | 25 ++++++++++++++++++++-----
>   drivers/usb/typec/ucsi/ucsi.h |  6 ++++++
>   2 files changed, 26 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 6c6def96a55b..772f55c92ba3 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -86,18 +86,33 @@ static int ucsi_read_error(struct ucsi *ucsi)
>   	case UCSI_ERROR_DEAD_BATTERY:
>   		dev_warn(ucsi->dev, "Dead battery condition!\n");
>   		return -EPERM;
> -	/* The following mean a bug in this driver */
>   	case UCSI_ERROR_INVALID_CON_NUM:
>   	case UCSI_ERROR_UNREGONIZED_CMD:
>   	case UCSI_ERROR_INVALID_CMD_ARGUMENT:
> -		dev_err(ucsi->dev, "possible UCSI driver bug (0x%x)\n", error);
> +		dev_err(ucsi->dev, "possible UCSI driver bug %u\n", error);
>   		return -EINVAL;
> +	case UCSI_ERROR_OVERCURRENT:
> +		dev_warn(ucsi->dev, "Overcurrent condition\n");
> +		break;
> +	case UCSI_ERROR_PARTNER_REJECTED_SWAP:
> +		dev_warn(ucsi->dev, "Partner rejected swap\n");
> +		break;
> +	case UCSI_ERROR_HARD_RESET:
> +		dev_warn(ucsi->dev, "Hard reset occurred\n");
> +		break;
> +	case UCSI_ERROR_PPM_POLICY_CONFLICT:
> +		dev_warn(ucsi->dev, "PPM Policy conflict\n");
> +		break;
> +	case UCSI_ERROR_SWAP_REJECTED:
> +		dev_warn(ucsi->dev, "Swap rejected\n");
> +		break;
> +	case UCSI_ERROR_UNDEFINED:
>   	default:
> -		dev_err(ucsi->dev, "%s: error without status\n", __func__);
> -		return -EIO;
> +		dev_err(ucsi->dev, "unknown error %u\n", error);
> +		break;
>   	}
>   
> -	return 0;
> +	return -EIO;
>   }
>   
>   static int ucsi_exec_command(struct ucsi *ucsi, u64 cmd)
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index bc2254e7a3a3..8569bbd3762f 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -133,6 +133,12 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num);
>   #define UCSI_ERROR_CC_COMMUNICATION_ERR		BIT(4)
>   #define UCSI_ERROR_DEAD_BATTERY			BIT(5)
>   #define UCSI_ERROR_CONTRACT_NEGOTIATION_FAIL	BIT(6)
> +#define UCSI_ERROR_OVERCURRENT			BIT(7)
> +#define UCSI_ERROR_UNDEFINED			BIT(8)
> +#define UCSI_ERROR_PARTNER_REJECTED_SWAP	BIT(9)
> +#define UCSI_ERROR_HARD_RESET			BIT(10)
> +#define UCSI_ERROR_PPM_POLICY_CONFLICT		BIT(11)
> +#define UCSI_ERROR_SWAP_REJECTED		BIT(12)
>   
>   /* Data structure filled by PPM in response to GET_CAPABILITY command. */
>   struct ucsi_capability {
> 


  reply index

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 14:24 [PATCH v4 00/18] usb: typec: API improvements Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 01/18] usb: typec: Copy everything from struct typec_capability during registration Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 02/18] usb: typec: Introduce typec_get_drvdata() Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 03/18] usb: typec: Separate the operations vector Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 04/18] usb: typec: tcpm: Start using struct typec_operations Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 05/18] usb: typec: tps6598x: " Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 06/18] usb: typec: ucsi: " Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 07/18] usb: typec: hd3ss3220: " Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 08/18] usb: typec: Remove the callback members from struct typec_capability Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 09/18] usb: typec: Remove unused " Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 10/18] usb: typec: hd3ss3220: Give the connector fwnode to the port device Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 11/18] usb: typec: ucsi: Simplified registration and I/O API Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 12/18] usb: typec: ucsi: acpi: Move to the new API Heikki Krogerus
2019-11-04 14:35   ` Guenter Roeck
2019-11-04 18:54   ` Guenter Roeck
2019-11-05  8:46     ` Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 13/18] usb: typec: ucsi: ccg: " Heikki Krogerus
2019-11-04 14:36   ` Guenter Roeck
2019-11-04 14:24 ` [PATCH v4 14/18] usb: typec: ucsi: Remove the old API Heikki Krogerus
2019-11-04 14:38   ` Guenter Roeck
2019-11-04 14:24 ` [PATCH v4 15/18] usb: typec: ucsi: Remove struct ucsi_control Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 16/18] usb: typec: ucsi: Remove all bit-fields Heikki Krogerus
2019-11-04 14:24 ` [PATCH v4 17/18] usb: typec: ucsi: New error codes Heikki Krogerus
2019-11-04 14:41   ` Guenter Roeck [this message]
2019-11-04 14:24 ` [PATCH v4 18/18] usb: typec: ucsi: Optimise ucsi_unregister() Heikki Krogerus
2019-11-04 14:42   ` Guenter Roeck
2019-11-04 15:05 ` [PATCH v4 00/18] usb: typec: API improvements Greg Kroah-Hartman
2019-11-04 18:53   ` Guenter Roeck
2019-11-04 20:53     ` Greg Kroah-Hartman
2019-11-04 20:54   ` Greg Kroah-Hartman

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f7d180f-dcdd-1014-65e0-2c757042eec9@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=ajayg@nvidia.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git