From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 383B2C433F5 for ; Wed, 23 Mar 2022 06:17:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241187AbiCWGSm (ORCPT ); Wed, 23 Mar 2022 02:18:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232627AbiCWGSl (ORCPT ); Wed, 23 Mar 2022 02:18:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 904AB5A17B; Tue, 22 Mar 2022 23:17:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4EEC3B81DEC; Wed, 23 Mar 2022 06:17:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 847AEC340E8; Wed, 23 Mar 2022 06:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648016228; bh=6qYRKx7Fm1RA0k8Bo9Mk1TZGG2liE+qqs6IEExcenC8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=foPEoL0OltkjH2Y+UusQFnM990XTyl+FfWKHNgYO0CcxIWen+tca4GwNeVt/jKUiv ByryQ7fj9u1g2lPrKMM//3ibxsBJF4840PP5KWpYX42WzqxZ4oyll4qfC9mj+Tjdyi sytQASqyicy2hFoc8u011wQT4BDkj8/bPYgu6Pv5hPl71M4wj7O4kqW7MptZOH/aCb BQsbHqwUrSGW8UYa4RUxmMWbPi5/txY83+Lwleo2Oodk7oMeLxd7AWEyZvYSbJULWQ gOn0lnKgcFwAvXiQdPW6vUFCCGFlAAX5U0xzTx9O1KE3a0wilmUSlMj4RwyVRh6ukn VmrWtKBMI0YVw== Message-ID: <7005ad7a-1e5e-8823-239e-18dc0fed472a@kernel.org> Date: Wed, 23 Mar 2022 08:17:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/2] dt-bindings: usb: Add documentation for AM62 USB Wrapper module Content-Language: en-US To: Aswath Govindraju Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Felipe Balbi , Krzysztof Kozlowski , Rob Herring , Greg Kroah-Hartman , Vignesh Raghavendra , Kishon Vijay Abraham I References: <20220323053524.7009-1-a-govindraju@ti.com> <20220323053524.7009-2-a-govindraju@ti.com> From: Roger Quadros In-Reply-To: <20220323053524.7009-2-a-govindraju@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Aswath, On 23/03/2022 07:35, Aswath Govindraju wrote: > Add bindings for the TI's AM62 wrapper module for the Synopsys USBSS-DRD > controller. > > Signed-off-by: Aswath Govindraju > --- > .../devicetree/bindings/usb/ti,am62-usb.yaml | 98 +++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ti,am62-usb.yaml > > diff --git a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml > new file mode 100644 > index 000000000000..4bb139d1926d > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml We already have ti,j721e-usb.yaml which is covering am64-usb. We could just add am62 compatible there. Any am62 specific properties could be handled with conditional 'required' statements. cheers, -roger > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/ti,am62-usb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bindings for the TI's AM62 wrapper module for the Synopsys USBSS-DRD controller > + > +maintainers: > + - Aswath Govindraju > + > +properties: > + compatible: > + const: ti,am62-usb > + > + reg: > + maxItems: 1 > + > + ranges: true > + > + power-domains: > + description: > + PM domain provider node and an args specifier containing > + the USB ISO device id value. See, > + Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml > + maxItems: 1 > + > + clocks: > + description: Clock phandles to usb2_refclk > + maxItems: 1 > + > + clock-names: > + items: > + - const: ref > + > + id-gpio: > + description: > + GPIO to be used as ID pin > + maxItems: 1 > + > + interrupts: > + description: > + interrupt line to be used for detecting changes in VBUS > + > + ti,vbus-divider: > + description: > + Should be present if USB VBUS line is connected to the > + VBUS pin of the SoC via a 1/3 voltage divider. > + type: boolean > + > + ti,syscon-phy-pll-refclk: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - items: > + - description: Phandle to the SYSCON entry > + - description: USB phy control register offset within SYSCON > + description: Specifier for configuring frequency of ref clock input. > + > + '#address-cells': > + const: 2 > + > + '#size-cells': > + const: 2 > + > +required: > + - compatible > + - reg > + - power-domains > + - clocks > + - clock-names > + - interrupts > + - ti,syscon-phy-pll-refclk > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + > + dwc3-usb@f910000 { > + compatible = "ti,am62-usb"; > + reg = <0x00 0x0f910000 0x00 0x800>; > + interrupts = ; /* MISC IRQ */ > + clocks = <&k3_clks 162 3>; > + clock-names = "ref"; > + ti,syscon-phy-pll-refclk = <&wkup_conf 0x4018>; > + power-domains = <&k3_pds 179 TI_SCI_PD_EXCLUSIVE>; > + id-gpio = <&main_gpio1 51 GPIO_ACTIVE_LOW>; > + #address-cells = <2>; > + #size-cells = <2>; > + }; > + };