From: Lars Melin <larsm17@gmail.com>
To: Tony Lindgren <tony@atomide.com>, Johan Hovold <johan@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, "Bjørn Mork" <bjorn@mork.no>,
"Dan Williams" <dan.j.williams@intel.com>,
"Marcel Partap" <mpartap@gmx.net>,
"Merlijn Wajer" <merlijn@wizzup.org>,
"Michael Scott" <hashcode0f@gmail.com>,
NeKit <nekit1000@gmail.com>, "Pavel Machek" <pavel@ucw.cz>,
"Sebastian Reichel" <sre@kernel.org>
Subject: Re: [PATCH] USB: serial: option: Add Motorola modem UARTs
Date: Wed, 24 Jul 2019 09:34:09 +0700 [thread overview]
Message-ID: <75e9bccc-d76d-2bc6-f9f3-a0efc25e8238@gmail.com> (raw)
In-Reply-To: <20190723144956.55753-1-tony@atomide.com>
On 7/23/2019 21:49, Tony Lindgren wrote:
> +#define MOTOROLA_VENDOR_ID 0x22b8
> +#define MOTOROLA_PRODUCT_MDM6600 0x2a70
> +#define MOTOROLA_PRODUCT_MDM9600 0x2e0a
> +#define MOTOROLA_PRODUCT_MDM_RAM_DL 0x4281
> +#define MOTOROLA_PRODUCT_MDM_QC_DL 0x900e
> +
Johan, when he is back from vacation, will tell you to drop those
defines and instead use the values directly in the list with a comment
behind reflecting the device model.
Just telling you so you can save time by sending out your v2 early..
best rgds
/Lars
prev parent reply other threads:[~2019-07-24 2:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 14:49 [PATCH] USB: serial: option: Add Motorola modem UARTs Tony Lindgren
2019-07-24 2:34 ` Lars Melin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75e9bccc-d76d-2bc6-f9f3-a0efc25e8238@gmail.com \
--to=larsm17@gmail.com \
--cc=bjorn@mork.no \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hashcode0f@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).