Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org,
	Mathias Nyman <mathias.nyman@intel.com>
Cc: John Youn <John.Youn@synopsys.com>
Subject: Re: [PATCH v2 4/7] usb: xhci: Workaround undercalculated BW for fullspeed BI
Date: Wed, 28 Apr 2021 14:57:14 +0300
Message-ID: <76ecefd7-d294-485a-1e2b-e5e556e2a3f7@linux.intel.com> (raw)
In-Reply-To: <ed5ddb78abd157ef2bb9317545b9fec63c6a5b66.1618014279.git.Thinh.Nguyen@synopsys.com>

On 10.4.2021 3.47, Thinh Nguyen wrote:
> DWC_usb31 host version 1.90a and prior undercalculates the bandwidth
> available for interrupt endpoints. The controller will return bandwidth
> error on config endpoint commands if there are already 6 or more
> fullspeed interrupt endpoints with bInterval of 4 (or 4ms) associated
> with a single fullspeed bus instance (BI).
> 
> To workaround this, configure and use the endpoint at a shorter
> interrupt interval. Lower the ep_ctx interval from 5 to 4 (or 2ms)
> for interrupt endpoints of the fullspeed BI. Note: we have not observed
> functional impact to the fullspeed devices by lowering the interrupt
> service interval (at least for a few devices that we tested).
> 
> To simplify the workaround, let's just check and apply the workaround if
> the endpoint is a fullspeed interrupt endpoint with interval of 4ms and
> if the top parent device is also operating in fullspeed (i.e. associated
> with fullspeed BI).
> 
> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> ---
> Changes in v2:
> - None
> 
> Note:
> Checkpatch will give a warning below for getting top_dev:
> 	WARNING: suspect code indent for conditional statements
> 
> Since this logic is done everywhere else in the driver, I'm keeping it
> consistent here.
> 
>  drivers/usb/host/xhci-mem.c     | 23 +++++++++++++++++++++++
>  include/linux/usb/xhci-quirks.h |  1 +
>  2 files changed, 24 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
> index 1053b43008e4..e01d0ddb012a 100644
> --- a/drivers/usb/host/xhci-mem.c
> +++ b/drivers/usb/host/xhci-mem.c
> @@ -1463,6 +1463,29 @@ int xhci_endpoint_init(struct xhci_hcd *xhci,
>  		}
>  	}
>  
> +	/*
> +	 * Check for undercalculated bandwidth quirk for interrupt endpoints
> +	 * associated with fullspeed BI.
> +	 */
> +	if ((xhci->quirks & XHCI_LIMIT_FS_BI_INTR_EP) &&
> +	    usb_endpoint_xfer_int(&ep->desc) &&
> +	    udev->speed == USB_SPEED_FULL &&
> +	    interval == 5) {
> +		struct usb_device *top_dev;
> +
> +		for (top_dev = udev;
> +		     top_dev->parent && top_dev->parent->parent;
> +		     top_dev = top_dev->parent)
> +			/* Found device below root hub */;
> +
> +		/*
> +		 * If the top device is operating at fullspeed, then the
> +		 * controller is using fullspeed BI for this device.
> +		 */
> +		if (top_dev->speed == USB_SPEED_FULL)
> +			interval = 4;
> +	}
> +


If we write a new xhci-snps driver then adjusting the interval could be done in the
.add_endpoint override, after calling xhci_add_endpoint()

If not then something like this should work.
Maybe turn it into a separate function for readability.

xhci_tune_interval_quirk(xhci, udev, ep, &interval)

-Mathias

  reply index

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09  1:41 [PATCH 0/6] usb: Set quirks for xhci/dwc3 host mode Thinh Nguyen
2021-04-09  1:41 ` [PATCH 1/6] usb: xhci: Move quirks definitions to common usb header Thinh Nguyen
2021-04-09  6:50   ` Greg Kroah-Hartman
2021-04-09  8:01     ` Thinh Nguyen
2021-04-09 16:26   ` kernel test robot
2021-04-09 19:54   ` kernel test robot
2021-04-09  1:42 ` [PATCH 2/6] usb: xhci: Check for blocked disconnection Thinh Nguyen
2021-04-09  1:42 ` [PATCH 3/6] usb: xhci: Workaround undercalculated BW for fullspeed BI Thinh Nguyen
2021-04-09  1:42 ` [PATCH 4/6] usb: xhci: Rename Compliance mode timer quirk Thinh Nguyen
2021-04-09  1:42 ` [PATCH 5/6] usb: xhci: Workaround lost disconnect port status Thinh Nguyen
2021-04-09  1:42 ` [PATCH 6/6] usb: dwc3: host: Set quirks base on version Thinh Nguyen
2021-04-09  6:53   ` Greg Kroah-Hartman
2021-04-09  8:01     ` Thinh Nguyen
2021-04-09 13:22       ` Greg Kroah-Hartman
2021-04-10  0:44         ` Thinh Nguyen
2021-04-10  0:46 ` [PATCH v2 0/7] usb: Set quirks for xhci/dwc3 host mode Thinh Nguyen
2021-04-10  0:46   ` [PATCH v2 1/7] usb: xhci: Move quirks definitions to common usb header Thinh Nguyen
2021-04-10  0:46   ` [PATCH v2 2/7] usb: xhci: Move xhci-plat header " Thinh Nguyen
2021-04-10  0:47   ` [PATCH v2 3/7] usb: xhci: Check for blocked disconnection Thinh Nguyen
2021-04-27 13:08     ` Mathias Nyman
2021-04-27 22:30       ` Thinh Nguyen
2021-04-28 13:32         ` Mathias Nyman
2021-04-29  0:54           ` Thinh Nguyen
2021-04-10  0:47   ` [PATCH v2 4/7] usb: xhci: Workaround undercalculated BW for fullspeed BI Thinh Nguyen
2021-04-28 11:57     ` Mathias Nyman [this message]
2021-04-10  0:47   ` [PATCH v2 5/7] usb: xhci: Rename Compliance mode timer quirk Thinh Nguyen
2021-04-10  0:47   ` [PATCH v2 6/7] usb: xhci: Workaround lost disconnect port status Thinh Nguyen
2021-04-28 13:48     ` Mathias Nyman
2021-04-29  1:00       ` Thinh Nguyen
2021-04-10  0:47   ` [PATCH v2 7/7] usb: dwc3: host: Set quirks base on version Thinh Nguyen
2021-04-19 21:07   ` [PATCH v2 0/7] usb: Set quirks for xhci/dwc3 host mode Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76ecefd7-d294-485a-1e2b-e5e556e2a3f7@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=John.Youn@synopsys.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git